Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   "Romanowski, Rafal" <rafal.romanowski@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "Drewek, Wojciech" <wojciech.drewek@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Simon Horman <horms@kernel.org>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported
 cloud filters
Thread-Topic: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported
 cloud filters
Thread-Index: AQHaEAenTBr/sLVOWEaQ2WLzKu4YDLB9BSvA
Date:   Thu, 16 Nov 2023 13:41:56 +0000
Message-ID: <BL0PR11MB3521D6872712EAFF01B239B58FB0A@BL0PR11MB3521.namprd11.prod.outlook.com>
References: <20231105164602.1107498-1-ivecera@redhat.com>
In-Reply-To: <20231105164602.1107498-1-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/39neU4JN4A3o8poaE08s1Y8lGhfetEDDXUurVIKJpojxigMCrdjeGg1KVsK?=
 =?us-ascii?Q?kc6aIr8TkbY+9lLqVoHB7BzPiBUh1yzfpq06sWrJe4OK7MzRTxHmkuwg1AoV?=
 =?us-ascii?Q?JegBGtGckrs+Gr2Q2X5aEKuYoStXt9GV3AzZJv+jHVUPThxc0U6C4gy3V+DK?=
 =?us-ascii?Q?pM4XB6+OaV1u4FrTsREtxgnMh432qHHrDbmQIop/EAXR3TtVmc3i3AKQC4p5?=
 =?us-ascii?Q?A3WD5N5BpWxvnI5BlQ3V6rRAl27ZzNfzVZMeq0AgUloxznkU/WbGc4y3LBpc?=
 =?us-ascii?Q?wOD2JoHq1xuqb6B2/+R2KbUR7lK1lswMdO2DcvPmyeKNazovbvGQcNumWFXD?=
 =?us-ascii?Q?pHMZZCqVwo1HWGno4U88UoVXBkIS82JzUOs/p0mwkKUyaNdZuB09ftFIgmhK?=
 =?us-ascii?Q?9WU/ZUBFimXFGvRMTnj+VkZPSDIEbilhFxRh686DF4ZBlh6GQTZf6cydHPGP?=
 =?us-ascii?Q?s1QrLvUax28uxtRM4sBHkEbZfhIvIIx1BCVgSZACV5lrso/hS6Labhro/vKM?=
 =?us-ascii?Q?u7pGgSX1GoFZYzod+/p252plWabQQfzTehU8RYAOVmqGijyMVRQSv+mwpoja?=
 =?us-ascii?Q?0lsm6Y4XBEtqgWYeKxu9+vM1EFBlSO3ERjhSQn1Rqg7TWsE90xNVd1mT4Z+0?=
 =?us-ascii?Q?Ywwheu62whAXY8QW93/1vWlw5eAA/NYGNwPFmx/IR5z13D+NJ00vknFU/A4V?=
 =?us-ascii?Q?waxylXm5TYCf2bNGtg7joGio1pjrX857zwcEIR9Nok1a65y/274hKtTNoqD+?=
 =?us-ascii?Q?OxQU1HrpHystrRSyYLbu2tCRoWYU8243/sPcZWDbQXnSzGIa5QUVk0USfxmc?=
 =?us-ascii?Q?4Q02AgaaNbXg5GPjsjbprwgAvqZ5ZXkItUUBbXCR3SjJdjeVrIVidh4glxzB?=
 =?us-ascii?Q?+1Du9ZOphZJfGVVaA6YaXYeV8HJ3Jzscc0n18ZhwWrVRy86PX43yt3bWiE0e?=
 =?us-ascii?Q?7QTC6g0u2zQMZeko+AwtTLoZTkudHiRV9VtLjPwOkvzex/tGQD7x3zbjPKV9?=
 =?us-ascii?Q?CITaxoKjPWhPpy4sGBX+7hvQeiod4zhVeZsVq+zHfrjaSNIwh230p1oYgs7Q?=
 =?us-ascii?Q?8jLmEtuoPih7fgZQnUb9wD24e57unLPvYCtiunSVihI/mF4/STOotcFLqFMc?=
 =?us-ascii?Q?eqLwGynMBn12Z7O1Dd+tZKKQ0LKQ9CFvw28U7lbxcdEvSeXLPgpkblgytOPr?=
 =?us-ascii?Q?Q0GsPo9+lyQE3yj3fEaGV62EqYup8QA0Mi436Bhvh2alPqS3qdjf+PtW3650?=
 =?us-ascii?Q?tXWcSeYgM+F+YuNQf3kD7IHSj8VZ1mHuvuaDC6FFFAtB9RP2wwU9M7QVg1LD?=
 =?us-ascii?Q?rlGCRgG0reHyS3w0rFeF80bCuzXpXxgKy27PM+SitSNJ7a2CR0JFBswB2t+8?=
 =?us-ascii?Q?Rz5rpc5UjBBLIqTF013hSON6MkJHpKy81Z72xFIDSDuRfh8C5oHCR5gY1hwF?=
 =?us-ascii?Q?rxKUp9km6PSCJRUORTSJyK53nvhaKVM/GY5R5zdOR0bHxFu/f3Es/Lmr0CzL?=
 =?us-ascii?Q?jgE5PV/UgL8c3+83pmvyRaO6BXRmQDsBs/Bstn4qqIT1NWbM6dyUtOrrhIhD?=
 =?us-ascii?Q?iWBxoGlr1TnKbqpF+2s+o2n3M8BnASeeMFT0K5Znk9kmt+lFjoL8p6GZYHkl?=
 =?us-ascii?Q?0Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3521.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2350f0-1738-4ed6-ffe2-08dbe6a9ccde
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 13:41:56.3882
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ddHc7p1SlYsMGNEq+97Vm6Mv/jwj9dhAiPFLjSfKatPCdmwsD/QnshPmxHJixS3XVaMTyQzvD2kbvsOOCCmVKsLdhLT5pVYQ6r2zvu+RN+w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8434
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 16 Nov 2023 05:42:22 -0800 (PST)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Ivan Vecera
> Sent: Sunday, November 5, 2023 5:46 PM
> To: netdev@vger.kernel.org
> Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; intel-wired-
> lan@lists.osuosl.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>; lin=
ux-
> kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; Simon Horman
> <horms@kernel.org>; Keller, Jacob E <jacob.e.keller@intel.com>; Jakub Kic=
inski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix adding unsupported cl=
oud
> filters
>=20
> If a VF tries to add unsupported cloud filter through virchnl then
> i40e_add_del_cloud_filter(_big_buf) returns -ENOTSUPP but this error code=
 is
> stored in 'ret' instead of 'aq_ret' that is used as error code sent back =
to VF. In
> this scenario where one of the mentioned functions fails the value of 'aq=
_ret'
> is zero so the VF will incorrectly receive a 'success'.
>=20
> Use 'aq_ret' to store return value and remove 'ret' local variable. Addit=
ionally
> fix the issue when filter allocation fails, in this case no notification =
is sent back
> to the VF.
>=20
> Fixes: e284fc280473be ("i40e: Add and delete cloud filter")
> Reviewed-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c   | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 08d7edccfb8ddb..3f99eb19824527 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -3844,7 +3844,7 @@ static int i40e_vc_add_cloud_filter(struct i40e_vf


Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>