Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 16 Nov 2023 15:03:57 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH] drivers/soc/litex: drop obsolete dependency on
 COMPILE_TEST
Message-ID: <20231116150357.6a2fa8f9@endymion.delvare>
In-Reply-To: <Y4DKYqgecIlGTxQK@errol.ini.cmu.edu>
References: <20221124161618.34ca07b3@endymion.delvare>
        <Y4DKYqgecIlGTxQK@errol.ini.cmu.edu>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Gabriel,

On Fri, 25 Nov 2022 09:00:02 -0500, Gabriel L. Somlo wrote:
> On Thu, Nov 24, 2022 at 04:16:18PM +0100, Jean Delvare wrote:
> > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> > is possible to test-build any driver which depends on OF on any
> > architecture by explicitly selecting OF. Therefore depending on
> > COMPILE_TEST as an alternative is no longer needed.
> > 
> > It is actually better to always build such drivers with OF enabled,
> > so that the test builds are closer to how each driver will actually be
> > built on its intended target. Building them without OF may not test
> > much as the compiler will optimize out potentially large parts of the
> > code. In the worst case, this could even pop false positive warnings.
> > Dropping COMPILE_TEST here improves the quality of our testing and
> > avoids wasting time on non-existent issues.
> > 
> > As a minor optimization, this also lets us drop of_match_ptr() and
> > ifdef-guarding, as we now know what they will resolve to, we might as
> > well save cpp some work.  
> 
> Acked-by: Gabriel Somlo <gsomlo@gmail.com>

Despite your ack, this patch was never committed. Was it forgotten
somehow? Should I resubmit?

Thanks,
-- 
Jean Delvare
SUSE L3 Support