Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f307b4f1-4dff-4925-829f-20459d25bdcf@intel.com>
Date:   Thu, 16 Nov 2023 15:21:24 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 3/5] i40e: Add helpers to find VSI and VEB by
 SEID and use them
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Simon Horman <horms@kernel.org>, <mschmidt@redhat.com>
References: <20231113125856.346047-1-ivecera@redhat.com>
 <20231113125856.346047-4-ivecera@redhat.com>
 <3c640be7-8f1e-4f9e-8556-3aac92644dec@intel.com>
 <36889885-71c7-46f7-8c21-e5791986ad5a@redhat.com>
 <72250942-17af-4f8d-b11f-ba902fbe2b58@intel.com>
 <483acf53-fe96-4ef3-933a-c5fd446042f6@redhat.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <483acf53-fe96-4ef3-933a-c5fd446042f6@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STVlQzdSNUJSeXBLR3MvcTdzSVpYSGNqakN4d1NlU0lsSFJwaDdFaWpsVGNl?=
 =?utf-8?B?elRMR1R6MEY3SE56UkE5dCtDa0VDUFNCY3NDS09Wa1ErR01XSVl3anRrUjla?=
 =?utf-8?B?VnhCaFpvRFZpYkxUTm4xQlVWaHJKdEtHV2FjV1A5QW0xMmZ2UmNZbjB0akpT?=
 =?utf-8?B?TGdOVzRPQVltQTJGSGNpWDdQTTZFT0pmTk5nVDBzcjlxbGg5SDhHSS9JWUI1?=
 =?utf-8?B?MFZVQkdmbnpOc3V6Ykh0eUcveG45b0oxOGFKWlNnQmg3dHJFMUFQRVlQajAz?=
 =?utf-8?B?eDZhMmhxQUxsY1VWT25RY1VHdTJXbFRPM1ZXaTU5WVlPRVA5YU5JWEY0S1p1?=
 =?utf-8?B?R2xSSUNqUzdVdTlkNmdocCsxYWRSUTJUYjIzc1U3L0JmSFNPK0plOXRUUWVh?=
 =?utf-8?B?MmcwSWxha3locmMzT1ZxdlhDZk5XZi9rU0ZtM2FPNkVjSzNZQnAyb29KUWxJ?=
 =?utf-8?B?R3J5RG5nVDh0MCtENmJ4ZDVUbnBIMzlmWWgrM1Y2a3B0eDZRM2ltRml0VXlq?=
 =?utf-8?B?QnNHaVR1RE5abGFrbVpIek1BWFozNjRORGY2NzRaVlljeU1RdmFmVVNLYldm?=
 =?utf-8?B?N2Rpa2tRdnd2V1BZTEt3dVhQTmZpSittN0NJNXl0bmc5dXNJSGpyQnZ4T3VJ?=
 =?utf-8?B?SGJKM08wQUtQTUhjS3R6dFJWSitrVnNxNFBFZGcyQnIzeHQzdzhoTlJsRzdM?=
 =?utf-8?B?bXFwRDRZdmxpK2c3QjVOcCtHZUhvTktCdGRaODhrYVNUWEN1d094eGEwK2sv?=
 =?utf-8?B?WXBhYTBTZ3MzNTBWbDJHUStoQ1UxY29kai9JaWtWcC8xTTJYTDdtWWNMMW9N?=
 =?utf-8?B?ZTZYOFpCaFdMOXN0T1c1bVdwUUJBUS9kQ1NJOVdmeXdzd29wSFB3bk1Oazgz?=
 =?utf-8?B?Q3N1Rlk1SStzaEtiRjJaRFVLOWJqUXJvS2JZQnRoMnkrajE5Z1JFcUh0MlZV?=
 =?utf-8?B?UGhvUW0vbWhlZW5HU3ZZNW8zYmRGLzFKZXNvWUxNYlFJbVFnRFVEb01UcHZG?=
 =?utf-8?B?dVZTNnc0VVFndGpxRWd5bkp1S1I0RWN6NHBpdzBpNmd6T2cvM0k2NnhRWUZq?=
 =?utf-8?B?OUJPZ1R6aXM5bzRjeVY4MTNCOUpmNG03KzREdXRJOGFTNDZjbzNHbHJkT2pW?=
 =?utf-8?B?UGdDbW1zUUFmdWJOa1NzeXY0R3MwZEhnQmN5bXNrSjlYTUFYT3EvRUdOQ25j?=
 =?utf-8?B?STIveTFzR1dzSUFiWnk5OGJBSkc1WllLcDZtclpwZXZqL2JsTE9DS3dPTENh?=
 =?utf-8?B?Ykx0aEpJVW13QW5jcWM2ZVlPdWNvb1dhNXBRTmtiTStBaGdBakk0U1lxU2JB?=
 =?utf-8?B?NE1tRXRIOU5aaHdrckdxaEhJY0JvS0Y1dHBpV1JVMHdxejZyVTFXMzArRGIy?=
 =?utf-8?B?SmdOZGFxTzdjV0l1NjE0UjJDRUU2cXp3VTltQXgwWnlUakxjaEFpZ1JlU3JB?=
 =?utf-8?B?bzBSZmpIOVhvYjFsaE1OZ1UvZVI4MktCdE16RkxiSzBNeGIzS0dJejFIRDFM?=
 =?utf-8?B?MjJVYXZWV0cvWWQrNktBYi9rRldFMTZER1lQZDFVSk5WNDEwNFh5QzBseURv?=
 =?utf-8?B?VjIzdWZtZ1RlcUpYeG5HUzUwQjd2NFBWWWZCRHRGR01aQ25sL0ZPZXN3Y0tP?=
 =?utf-8?B?bWZpOWxBZ09RYzVUMU9rcURjUU8ybFhGYkdqU2dvb0ZvdmNKczk4Qlk0UndT?=
 =?utf-8?B?b1JoS250eWNBa2Q2QzZoL2NyQkhPbTRqVjB0Rld2YlFyNUtOMjVGUSs2OCsz?=
 =?utf-8?B?aGRIT2tmTmtwYTgxWlJjZ0RDa21zWk5OQXBVY3R3RDQ3N2NoYU92N3UxamRW?=
 =?utf-8?B?WElacFNubmRkT0dLOUh3enhvcEFjUDY0MlRGOVJMT0ZJSmVzVXk0RWxCN21a?=
 =?utf-8?B?aVNiOFJ1R3VVWWtYTXlXWVUwQXZUeHZJcDNvQ3kwOHV5MFovOFlkVmY1Snc1?=
 =?utf-8?B?TThpUVFiU1dpbGdrbHEwTEwwRWtPSThxK3Mwc1dXcjY4MHRJcEVqMWNHWnlX?=
 =?utf-8?B?QUxNM1FQN0pDa3ZpUTZUR2ZmVnhkbUVGM0ZjOTJqaHpzWlZTcmo3L0ROUkY2?=
 =?utf-8?B?blV5TUVYUjZGM0FVOEVnTGl1K1ZnanZmc2kwS3Z6V1NHOUdmdG9hVnMwVGhK?=
 =?utf-8?B?a2RrM1JVc0NDVjRmbHJsWEs4d2hwQmJlTnE0ekRhT1N0NHgyT3Z5M3puUTE3?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd68347-b8f6-4b77-45fd-08dbe6af522f
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 14:21:27.6743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8S96/42WwalFzHrEZJyxgfZk4cHxbGYS/HHCnfYp/tE/VIKlhnssdiLafIlKW9I/rT8sq3FDgjJiJPpwztH+M57FSdJpZxknmMz7VJM4lfA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6772
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 06:21:57 -0800 (PST)


On 16.11.2023 14:59, Ivan Vecera wrote:
> 
> On 16. 11. 23 13:37, Wojciech Drewek wrote:
>>
>>
>> On 15.11.2023 18:01, Ivan Vecera wrote:
>>>
>>> On 13. 11. 23 14:27, Wojciech Drewek wrote:
>>>>
>>>> On 13.11.2023 13:58, Ivan Vecera wrote:
>>>>> Add two helpers i40e_(veb|vsi)_get_by_seid() to find corresponding
>>>>> VEB or VSI by their SEID value and use these helpers to replace
>>>>> existing open-coded loops.
>>>>>
>>>>> Signed-off-by: Ivan Vecera<ivecera@redhat.com>
>>>>> ---
>>>> Only one nit
>>>> Reviewed-by: Wojciech Drewek<wojciech.drewek@intel.com>
>>>>
>>>>>    drivers/net/ethernet/intel/i40e/i40e.h        | 34 +++++++++
>>>>>    .../net/ethernet/intel/i40e/i40e_debugfs.c    | 38 ++--------
>>>>>    drivers/net/ethernet/intel/i40e/i40e_main.c   | 76 ++++++-------------
>>>>>    3 files changed, 64 insertions(+), 84 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
>>>>> index 1e9266de270b..220b5ce31519 100644
>>>>> --- a/drivers/net/ethernet/intel/i40e/i40e.h
>>>>> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
>>>>> @@ -1360,4 +1360,38 @@ static inline struct i40e_pf *i40e_hw_to_pf(struct i40e_hw *hw)
>>>>>      struct device *i40e_hw_to_dev(struct i40e_hw *hw);
>>>>>    +/**
>>>>> + * i40e_vsi_get_by_seid - find VSI by SEID
>>>>> + * @pf: pointer to a PF
>>>>> + **/
>>>>> +static inline struct i40e_vsi *
>>>>> +i40e_vsi_get_by_seid(struct i40e_pf *pf, u16 seid)
>>>>> +{
>>>>> +    struct i40e_vsi *vsi;
>>>>> +    int i;
>>>>> +
>>>>> +    i40e_pf_for_each_vsi(pf, i, vsi)
>>>>> +        if (vsi->seid == seid)
>>>>> +            return vsi;
>>>>> +
>>>>> +    return NULL;
>>>>> +}
>>>>> +
>>>>> +/**
>>>>> + * i40e_veb_get_by_seid - find VEB by SEID
>>>>> + * @pf: pointer to a PF
>>>>> + **/
>>>>> +static inline struct i40e_veb *
>>>>> +i40e_veb_get_by_seid(struct i40e_pf *pf, u16 seid)
>>>>> +{
>>>>> +    struct i40e_veb *veb;
>>>>> +    int i;
>>>>> +
>>>>> +    i40e_pf_for_each_veb(pf, i, veb)
>>>>> +        if (veb->seid == seid)
>>>>> +            return veb;
>>>>> +
>>>>> +    return NULL;
>>>>> +}
>>>> I would prefer i40e_get_{veb|vsi}_by_seid but it's my opinion.
>>>
>>> I'd rather use i40e_pf_ prefix...
>>>
>>> What about i40e_pf_get_vsi_by_seid() and i40e_pf_get_veb_by_seid() ?
>>
>> Sounds good, my point was that I prefer to have "get" before "{veb|vsi}"
> 
> OK, got it... Will repost v2 with this change + "too many also..." issue ;-)

Thanks

> 
> Btw. what about the last patch?

Reviewed :)

> 
> Ivan
>