Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3326945rdb; Thu, 16 Nov 2023 06:46:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwdJybWOzVUWITHOPqU3PZ8KIgjA76ILr0pNtGEyf7kMTjFojoUXAQiQexTXly9Lr86G9i X-Received: by 2002:a05:6a00:1e0e:b0:690:d4f5:c664 with SMTP id gx14-20020a056a001e0e00b00690d4f5c664mr13162996pfb.11.1700146012348; Thu, 16 Nov 2023 06:46:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700146012; cv=none; d=google.com; s=arc-20160816; b=ni1Lnkg7Klu79nsjaDl0nl9lKHC+jOa0/1ekpLl4T6aeMfFUEIi2Cie0KOTSKV6sC/ r1sUAtDA5PfeP1gTaUyUxgB+WdLymzn5m+cMvSkKVkkIhk+IE+Z96z58cxebgGIhQECn yEe6QuoQ9DbWPnV9g2lY8IqBmjKhw+9PpkwdEpQXnb2aKVAIZBmOJ1kcHk4OioFz6xvK hE12ljbhg7bkHioXiu8oCB4p1sj9wpSFZ9XFT944JJT5ELzW6jP1j/wBlEJHiX+XFtDd w0cYmM8wb6Ul/grjWJsW8K9fo0hXaPDruG3nb/IFvI/XOk6QFSoYtyOpkYbrzmHJdUxw Kh+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=Vt1juP8BW+EFOrLOig6p70yYVk9YIU8a9DpVV73kcO8=; fh=wgf/9nXwgxujU15+ffHTv0WX54ajIUeceNg3MuTPDGk=; b=u2ajSvw02IqUI4H59JnR0IyE3YudTZXrAeEnUYrqZQge7vtfWi0aATBegH1DspmJ0o qhC0eEcVFbuUAQUCYTo7G6un7kRBuRnDRkGd4Cjku/2xQtPqN4dogLXSPcLHB8kDnVOa gqp7MrzTiJh/40sd6vfIPLiSViW8h4AoSb6F27yBOVqkh8BKeEmuquQnKddtdTWGOuq7 pyuA2NN1zZOUZCGq163LSDTRLz7t/p5e81aNdh2rPRsLoBkQvrIkrZxkRqz2PO4jSyNd 4XMI07bD31m0naETjqF6RacD59Fcksd0K+p4vyb0jSTVJVJLhORf7zRU/c0eulBSl3H+ F20A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qs9yFL+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u15-20020aa7848f000000b006b61871ae27si12119508pfn.367.2023.11.16.06.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 06:46:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qs9yFL+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B7382802FB47; Thu, 16 Nov 2023 06:46:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344251AbjKPOqm (ORCPT + 99 others); Thu, 16 Nov 2023 09:46:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345330AbjKPOqi (ORCPT ); Thu, 16 Nov 2023 09:46:38 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD32D53 for ; Thu, 16 Nov 2023 06:46:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 853C1C433C7; Thu, 16 Nov 2023 14:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700145995; bh=/30pqYAYvbLO5clNyYNAxMIkYml49mHmkWtOEU+eKRQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qs9yFL+rJ8S5JrQ1r0HYHOzOZkmCeyt0exmJXmo+wTshdvxU5exIxZuoDxDPfDz/f ldSU9YqF9Ro40bhOLXSD1v9zdGMd8pQL441095W1E5/gHtSru2eTquTZP4ZRavHefO 2usjF0R4E+2aaOXICzIIvPCucoFjSju6ag9xpSf7mQMe+mHKLxTuYnOcrZ/kYOv3FS Y132Svmc0u5p+Hneq/r8YJlRMyF2EMjam9G0poHyGnkClvv+j/+5Xa8qSeDq93USWt hlnmZdphgE9SV144OwxX9F7wge/rc7jxiax7OZ9pjbhzIyJkT0/VPi/zv+z1++hnXd ZYpJOOTmF4hqQ== Message-ID: <830940d3-c5fe-444c-a53c-b8ba03075871@kernel.org> Date: Thu, 16 Nov 2023 15:46:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs Content-Language: en-US To: =?UTF-8?B?SmFtZXMgVGFpIFvmiLTlv5fls7Bd?= , "linux-kernel@vger.kernel.org" , "linux-realtek-soc@lists.infradead.org" Cc: Thomas Gleixner , Marc Zyngier References: <20231102142731.2087245-1-james.tai@realtek.com> <20231102142731.2087245-2-james.tai@realtek.com> <72024444-da43-47e3-a76f-4107bda8e402@kernel.org> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 06:46:49 -0800 (PST) On 16/11/2023 15:37, James Tai [戴志峰] wrote: > Hi Krzysztof, > >> >> Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can >> be ignored, but the code here looks like it needs a fix. >> Feel free to get in touch if the warning is not clear. >> > > I will run checkpatch.pl to address and fix the reported warnings. > >> Please use scripts/get_maintainers.pl to get a list of necessary people and lists >> to CC. It might happen, that command when run on an older kernel, gives you >> outdated entries. Therefore please be sure you base your patches on recent >> Linux kernel. >> >> You missed at least devicetree list (maybe more), so this won't be tested by >> automated tooling. Performing review on untested code might be a waste of >> time, thus I will skip this patch entirely till you follow the process allowing the >> patch to be tested. >> >> Please kindly resend and include all necessary To/Cc entries. > > I will fix it in the next patches. > >> >> It does not look like you tested the bindings, at least after quick look. Please run >> `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. >> > I will test the bindings using 'make dt_binding_check'. Please do all above before submitting patches. Best regards, Krzysztof