Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <d46a6f38-7c3a-4ed4-8038-8c6a2417a8b7@linux.intel.com>
Date:   Thu, 16 Nov 2023 10:20:48 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND PATCH 2/4] x86/smp: Export symbol cpu_clustergroup_mask
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        artem.bityutskiy@linux.intel.com, rui.zhang@intel.com
References: <20231116142245.1233485-1-kan.liang@linux.intel.com>
 <20231116142245.1233485-2-kan.liang@linux.intel.com>
 <20231116144034.GG8262@noisy.programming.kicks-ass.net>
Content-Language: en-US
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20231116144034.GG8262@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-11-16 9:40 a.m., Peter Zijlstra wrote:
> On Thu, Nov 16, 2023 at 06:22:43AM -0800, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> Intel cstate PMU driver will invoke the topology_cluster_cpumask() to
>> retrieve the CPU mask of a cluster. A modpost error is triggered since
>> the symbol cpu_clustergroup_mask is not exported.
>>
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
>> ---
>>  arch/x86/kernel/smpboot.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>> index 48e040618731..376387ca6be5 100644
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -747,6 +747,7 @@ const struct cpumask *cpu_clustergroup_mask(int cpu)
>>  {
>>  	return cpu_l2c_shared_mask(cpu);
>>  }
>> +EXPORT_SYMBOL(cpu_clustergroup_mask);
> 
> I made that _GPL.

Sure.
> 
> Queued the lot.

Thanks!

Kan