Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Romanowski, Rafal" <rafal.romanowski@intel.com>
To:     Simon Horman <horms@kernel.org>, ivecera <ivecera@redhat.com>
CC:     "Drewek, Wojciech" <wojciech.drewek@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking
 fields from iavf_adminq_ring
Thread-Topic: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking
 fields from iavf_adminq_ring
Thread-Index: AQHaB+gUbHAaPQzHrE2HZOs0BH2JpLBo4TEAgBRYnhA=
Date:   Thu, 16 Nov 2023 15:52:06 +0000
Message-ID: <BL0PR11MB3521C0334FF07B3C3DD69D9D8FB0A@BL0PR11MB3521.namprd11.prod.outlook.com>
References: <20231026083932.2623631-1-ivecera@redhat.com>
 <20231103170928.GD714036@kernel.org>
In-Reply-To: <20231103170928.GD714036@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rYsfQEZFedn6fZqC9pxW6qtOJ8b6U6wnld9Bs6i2mvZEMRMerUG2vntQuoQr?=
 =?us-ascii?Q?bSm4fhNTvOLeBoNKArAwssD9/3X5XHEJ8X7JznMk1FMurbzYvCCpoRT3LWNN?=
 =?us-ascii?Q?2C6SRRN+4adb2UF6GKWWyB/u6gbu34zm0VYX0Cr7fi3d1YPcoxfUF7/6/jOw?=
 =?us-ascii?Q?YBhjO3AR5azX48zyLzxm6Quq8fkN/C6U/u6XovLEmYldat1dxhHqZKbOLa55?=
 =?us-ascii?Q?ENzhjSlrv0dYoeo2COJxVumw+LoDSP7eIz/8TQv4w+b6opkWuvpzNIhjxdo9?=
 =?us-ascii?Q?qFYLp1yXLsV7GrMUcGJ4BwgNO7HB3pVIh/hgNykY/OF6HZckzDSCs/+zgE5W?=
 =?us-ascii?Q?pn8XP+8YWdoSC/ApUVTJxRuHvK5TNzQ8aD50LPXOlGNZIrGOC793VrtAtvDd?=
 =?us-ascii?Q?DQsnVqONGMgcMDCoJ8jw67+JkKi4iSMQM2EyIj4tQOIzOlaqAcdTBsmdcbxX?=
 =?us-ascii?Q?ZX3HARVWnloDz1Z45bAgDLJzcWZAfupFPRVkGwXM5CBSX3SgDQ2aqjR/3XRw?=
 =?us-ascii?Q?FMuEfv5qpEgOe05mdZXnDQg+7qb7WzlyduXzDpBJ0VgsGqm6i1on+kI/Uweu?=
 =?us-ascii?Q?JI3JNHaQ+LT6t/BID/OP+RTCFH2uAJhWO3IiNOeMZJ/o2fo/mNa0Tj/8CRkW?=
 =?us-ascii?Q?l9V+66oCtiWBSqrNqSrWDlsuQkmfIUo7dxz5owKMaj2MPimqNnfkT5YBkt9q?=
 =?us-ascii?Q?Na0SOASBIPji2X0Cib34it4JlFgQxCSodR3HvTaND18/zx94gdJLDONenKQm?=
 =?us-ascii?Q?vxgMlA2GCOGWqXJvXvXUhzSQIsCAMErGThi8zaWbj/hk7w4+1LWRfkFbSXnq?=
 =?us-ascii?Q?woLYR92QYCkbldQOxoafjk6fnrzmA3Fxff5pVm3Hr9yoe9olfncxlFB9yRMw?=
 =?us-ascii?Q?Ml0cDElM+5uDA2Iu3/WkEdAxbeXY7RAO86tvOPUDs7sAHpOADNHrbefmt/FC?=
 =?us-ascii?Q?lXTcddMIZsSP7zLPDeNQXtBZUhiVYrpZRtP/xPnQiM9/nvMPFWrQucR+Av5o?=
 =?us-ascii?Q?ZN5DBr8AacqRwHFzPfscFvRFIdL9a61e0WGXS8mVWpPGXtAahxHNU7wbQsI+?=
 =?us-ascii?Q?l4b1eJNObGliuAEpJ6Oj+Rhy8UYCh5P+bS7rtf4CMnEugywnv8duQJC0hxjV?=
 =?us-ascii?Q?Y7qGgEKKBuBEi1NgWBBQMizOKw6ehsTMJJJgJ6eZT5U862XUVP7a5IjkOeW6?=
 =?us-ascii?Q?hHBSttPfjjoNP0KggOPkP7mBlntq2OCYt2tKy3WFye2YrfSu5uAua/BNfAW4?=
 =?us-ascii?Q?eXSrYI4Ak5gFIPerldhzcqJj2GbQ2RO+YpuM1sW2SM3ob9uxrZtfcDcjqbJ7?=
 =?us-ascii?Q?6uABMvKDgWptuKICBwstGFf1bFRLxgZOX9qhzEkFU6vnrfWTvhuziwhnjIeH?=
 =?us-ascii?Q?TKN+4Uz+ktP4yBQ3Yf7MdPUCFgDN/JjIqLeV1g9Xyvv6HJVRJV1bpteovotc?=
 =?us-ascii?Q?U2sxvbGibuoDuLN1q7zXSb3FOgk+0bO3KAayOWcxvdHK68odx+2Y/jD1tqt+?=
 =?us-ascii?Q?zcpTVDsjUj5yeXcFQ3Sw3fs5BsSyQFe98BHcA73GxOMxtS110JmLupMXYsPY?=
 =?us-ascii?Q?S2NkoOagEblplEEJMjNWrPgKsZLvRROr7i9Lp+ejEBSXIBG2OvYvun5/uQ5j?=
 =?us-ascii?Q?tg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3521.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c23fe34-5b00-4ff4-138b-08dbe6bbfbff
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 15:52:06.3798
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8Wwc+fiwKQwMa5MRzBJeDh2rhEbdHJX7H2PXB0rRD/qOl1uuqIQo/27Q/mlcmJZHoeMcH1+5DsLUiHpDV55SxXMR3kE/4vZgopVxPxvMkEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6768
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 07:52:24 -0800 (PST)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Friday, November 3, 2023 6:09 PM
> To: ivecera <ivecera@redhat.com>
> Cc: Drewek, Wojciech <wojciech.drewek@intel.com>;
> netdev@vger.kernel.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> linux-kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>; intel-wired-
> lan@lists.osuosl.org; Keller, Jacob E <jacob.e.keller@intel.com>; Jakub K=
icinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracki=
ng
> fields from iavf_adminq_ring
>=20
> On Thu, Oct 26, 2023 at 10:39:32AM +0200, Ivan Vecera wrote:
> > Fields 'head', 'tail', 'len', 'bah' and 'bal' in iavf_adminq_ring are
> > used to store register offsets. These offsets are initialized and
> > remains constant so there is no need to store them in the
> > iavf_adminq_ring structure.
> >
> > Remove these fields from iavf_adminq_ring and use register offset
> > constants instead. Remove iavf_adminq_init_regs() that originally
> > stores these constants into these fields.
> >
> > Finally improve iavf_check_asq_alive() that assumes that non-zero
> > value of hw->aq.asq.len indicates fully initialized AdminQ send queue.
> > Replace it by check for non-zero value of field hw->aq.asq.count that
> > is non-zero when the sending queue is initialized and is zeroed during
> > shutdown of the queue.
> >
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>=20
> Thanks, this is a nice cleanup.
>=20
> Reviewed-by: Simon Horman <horms@kernel.org>
>=20
> ...
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>