Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <696b7c76-6672-4c33-b729-992ccbcf786f@xen0n.name>
Date:   Fri, 17 Nov 2023 00:15:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] LoongArch: Implement stable timer shutdown interface
Content-Language: en-US
To:     maobibo <maobibo@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20231114114656.1003841-1-maobibo@loongson.cn>
 <21c772c3-b1ad-49c4-b6ca-204cb65042de@xen0n.name>
 <762523c4-5452-bfad-e5dc-f3bca035fb69@loongson.cn>
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <762523c4-5452-bfad-e5dc-f3bca035fb69@loongson.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/16/23 16:21, maobibo wrote:
>>> arch_cpu_idle_dead is called. Timer interrupt for this processor should
>>> be disabled, else there will be timer interrupt for the dead cpu. Also
>>> this prevents vcpu to schedule out during halt-polling flow when system
>>> is running in vm mode, since there is pending timer interrupt.
>>
>> The logical relationship is a bit unclear, is my paraphrasing correct 
>> in your opinion?
>>
>> "Timer interrupt for this processor should be disabled, else a 
>> pending timer interrupt will prevent the vCPU from scheduling out 
>> during the halt-polling flow when system is running in VM mode"
>>
>> (I don't immediately know what a "schedule out" is. Is that a 
>> translation artifact or some KVM jargon?)
> how about "prevent the vCPU from giving up scheduling"?
That's very easy to understand, so no problem and thanks!

-- 
WANG "xen0n" Xuerui

Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/