Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <c10bd6c4-9701-4888-8277-851c5ac76beb@virtuozzo.com>
Date:   Thu, 16 Nov 2023 17:37:11 +0100
User-Agent: Mozilla Thunderbird
From:   Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: Re: [PATCH 00/10] KVM: x86/pmu: Optimize triggering of emulated
 events
To:     Sean Christopherson <seanjc@google.com>,
        Dongli Zhang <dongli.zhang@oracle.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jim Mattson <jmattson@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <20231110022857.1273836-1-seanjc@google.com>
 <6e101707-f652-73f8-5052-b4c6c351e308@oracle.com>
 <ZU5Euc29B_UjiUot@google.com>
Content-Language: en-US
In-Reply-To: <ZU5Euc29B_UjiUot@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzJSalJtajU1bDZFQXEyYWh2VFd4SWFldnZSeE5pNGI0UU1US0trVlVJS21W?=
 =?utf-8?B?U3Y0OGp1ZlplTDNTWTBCTVhIQmg3cmFVM0tTdXdaYzByeXZWUENDNFNsMm85?=
 =?utf-8?B?cGY2NDlPdlBUSTJmWFFRWDhwZEE1NTZybk1oMEM2cjZNb21CY2xYUjUyZ1VD?=
 =?utf-8?B?WUlCOUowbEhzcisvdkhXVG55aG9rNnJGN1B2RXZVQ2xSYjNTZFNPc3hEVDZl?=
 =?utf-8?B?RlkwcnBZOG95U3h1UFg4VG1CSEpnTlNkYkZORmczRmdhTmtxd0ozWU80WmxH?=
 =?utf-8?B?S3ROQlRIQ1J3S1pSU0piV3dxakxDUlBLMVh5dExnbS9qR1lRdWFoeXFZdlJC?=
 =?utf-8?B?NnZmYm16dGlveEpRSjU5Y0lDd0htRU05RjB2UlBlRmNQaWZZRTgrSjJJRmE1?=
 =?utf-8?B?cDI2VGRZWTV0cHQxeDEzY3J3bko5UmJoelBmb1krbXVWUzJhWUFSYTBWc1JF?=
 =?utf-8?B?QW4vYzk2MDd0WWQ3ckdQQ2pRUnRvNlRZenVFVlhQQkt0cjVCdTU3bExKUUd1?=
 =?utf-8?B?SjlwYlVUYm81LzYrL1l5ZmVrUGd4NnVNMG1aOXpsYzFENmh4VE9XMjBhZDJY?=
 =?utf-8?B?WlZZNlJ3eUt0UTNUMVZoQVdJVFUzVkZ6d1VaVGVuQk9YRVlUVjl6MWVtTS9H?=
 =?utf-8?B?aWViaW9XSW10d2J2UkVEb0IvMGE5QWdMYTJ6TXZaeEozL2puZ2VBMmhlVVQv?=
 =?utf-8?B?Y29Xd0VhdG95Z2I4T2JVWjZkYkxpbVBxM3hBYXNyQUlpWlNqMnhzSCtrV2NK?=
 =?utf-8?B?OW1rYXduTmF4VFF3Tlh4c1BCZkczWWpUZ20yVFpqNk5iYnNMYnZjeHV4RUVX?=
 =?utf-8?B?WUJwTDB0OVZZKzlxVUcyZFM0SGxUNW9SR3ZFbGozSWwzSVIySElieWRtM2RQ?=
 =?utf-8?B?QXpyTlFYelVYYlRMd0hkM2VKb0g4MTlSbFN1WnVEVGEyM2lJeUtqN3FaalZN?=
 =?utf-8?B?UzlUM3ZQL3c2YWtZRjlzY1Y3Nnl3RGRsZEg4NFFIUUZOM1pURWNDZ0Npcy9D?=
 =?utf-8?B?WGtlZGs3d0ozbzI1MUNtaHROYU1VS2NZdHFvVGJwdjVLbUl0TnNwczFrRUJU?=
 =?utf-8?B?aVkxQ2pzL05HOVNwcGhYRDRodElacHArcW5MdHFPWHBFelJhcTREeVFoRlRS?=
 =?utf-8?B?U3RDSnFDOEh4TmVYQThJT1VkbFVvYUZ6RERrNklLWGJwWEx0QlNVenU1NGht?=
 =?utf-8?B?RU53d0cwWmFTZ0tzZmFuUGxGTEtGNkcwQUp2VEg3aDFVWlVVUTB3SGNMd0M4?=
 =?utf-8?B?cTkxVUZXQ0hXUng5bE5QRXNjQ0JaN1hFTTB0VWhLWmlySlUranBBdTdnU0tv?=
 =?utf-8?B?cjJFS244Qm1wS3M0eWtBQkFnclFiVDhsbWdEWW1XeWNlQVRKS1VQQ04zRUVu?=
 =?utf-8?B?aG40dXBocTRCR3AvN2pSLytWWVBYRkxjRlkyUUd0OGRrL0oyYWpBeFdkYmJO?=
 =?utf-8?B?cFR6eFpvTTdsclFZNXduUHBYWFN4Ny9DdlZ0VktLV2NsM3dNNUdVMy8vaVZj?=
 =?utf-8?B?ay80MWpLR3RxaFNQd2czQUE0d201UHJzdVBjSjVtVHY5dVNEZS9UdFo1Mk9s?=
 =?utf-8?B?TnR6am8xN3NxYnVtOWl1bG9rN2tCZ1N1bkVLWm9uelBBbXVzN0dsZFVEcGtW?=
 =?utf-8?B?NkhTMzE3eUk4ZWxZRnY2Nm1razZSaW1nandvdzVDL01WSkxiQ3ljN2pwZEdY?=
 =?utf-8?B?NTBvYW13UkY1eVVyRXRPTmNDblRNa3NTdFlsSDluWVJzTDBocXNWU2V1Qkl5?=
 =?utf-8?B?ZjRMMk95VGp4dXNBMVhvZmNjQ09iQWNlcjVIYlB4NzU1VkRUVGtGQktNUnJ0?=
 =?utf-8?B?aWlwRFNvbTZMWWh3NVZwNnFCT2w4SDJrOVlUVTVzUDdtOHlQYzNVVGtQbElN?=
 =?utf-8?B?eGhSQXdlZTk3RUVFZFJvMFhHZTQ1OXJxZDVYN0FwVUR1NHFMbExjREttdXh3?=
 =?utf-8?B?cnlVMDBLcWtYVkhtV21MdC9OampOWXAzODVvMlR2Q3Z2MnBZKzBLUEJWWGZ3?=
 =?utf-8?B?VU81UENyOFlydTRNQTVOYVlDcmYxalVRSFdlSGdMckdzelVyNjh0eDJMWUhz?=
 =?utf-8?B?NkVXeTFBdmtaMXRkQUJuelNuWWh0RHhmY0FtcDZrcy9xemxTZVFiVExXeGE2?=
 =?utf-8?B?aGR3M3JyRnFtWHAvU2RtMlF3Zisxano3czg1NzIyZnM4bkt1OE8zWmwxbnhs?=
 =?utf-8?B?ekE9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb53cbe2-59c3-4cc1-0a0a-08dbe6c249ec
X-MS-Exchange-CrossTenant-AuthSource: DBAPR08MB5830.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 16:37:14.3834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8tmTDGT873eLJ4CFAYm56AoLq1/Xx6TJEqkqh6l3L3F/NGn6YDIO+ft9ugoMoLMg0zlarleZ7OS1o2v8gK0fEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10465
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 16 Nov 2023 08:37:39 -0800 (PST)

On 10.11.2023 15:56, Sean Christopherson wrote:
> On Thu, Nov 09, 2023, Dongli Zhang wrote:
>> Hi Sean,
>>
>> On 11/9/23 18:28, Sean Christopherson wrote:
>>> base-commit: ef1883475d4a24d8eaebb84175ed46206a688103
>> May I have a silly question?
>>
>> May I have the tree that the commit is the base? I do not find it in kvm-x86.
>>
>> https://github.com/kvm-x86/linux/commit/ef1883475d4a24d8eaebb84175ed46206a688103
> It's kvm-x86/next (which I failed to explicitly call out), plus two PMU series
> as mentioned in the cover letter.
>
>    https://lore.kernel.org/all/20231103230541.352265-1-seanjc@google.com
>    https://lore.kernel.org/all/20231110021306.1269082-1-seanjc@google.com

Hi Sean,

i have tested my testcase on your patchset, results look impressive, thank you for your work!
Note, for AMD node PMU totally disabled case gave a bit worse results on kvm-next kernel vs stock 
latest mainstream.

The difference is tiny though.

*AMD node*: CPU: AMD Zen 3 (three!): AMD EPYC 7443P 24-Core Processor
-----------------------------------------------------------------------------------------
| Kernel							| CPUID rate		|
-----------------------------------------------------------------------------------------
| stock ms 6.6.0+ (commit 305230142ae0) 			| 1360250		|
| stock ms 6.6.0+ + kvm.enable_pmu=0				| 1542894 (+13.4%)	|
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=1	| 1498864		|
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=0	| 1526396 (+1.84%)	|
-----------------------------------------------------------------------------------------


*Intel node*: CPU: Intel(R) Xeon(R) E-2136 CPU @ 3.30GHz
-----------------------------------------------------------------------------------------
| Kernel							| CPUID rate		|
-----------------------------------------------------------------------------------------
| stock ms 6.6.0+						| 1431608		|
| stock ms 6.6.0+ + kvm.enable_pmu=0				| 1553839 (+8.5%)	|
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=1	| 1559365		|
| kvm-next ms 6.6.0+ + patches from Sean + kvm.enable_pmu=0	| 1582281 (+1.5%)	|
-----------------------------------------------------------------------------------------


Note: in order to disable PMU completely i used "kvm" module "enable_pmu=0" option
(not used KVM_PMU_CAP_DISABLEthis time).

Hope that helps.

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team