Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 16 Nov 2023 13:05:58 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        rafael@kernel.org, lenb@kernel.org, lpieralisi@kernel.org,
        andre.draszik@linaro.org, quic_zhenhuah@quicinc.com
Subject: Re: [PATCH] iommu: Avoid more races around device probe
Message-ID: <ZVZL9kZuVsb9VPnM@nvidia.com>
References: <16f433658661d7cadfea51e7c65da95826112a2b.1700071477.git.robin.murphy@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16f433658661d7cadfea51e7c65da95826112a2b.1700071477.git.robin.murphy@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7MWARaY9twvNtNKM959wEebynYWRNAMTlEFK4UEFwSoRm4A9wl5b4fLO1JNL?=
 =?us-ascii?Q?OAkoyP4e+LNDIUGX6zE60TSzMjpdlkPvwmRaDvBLKoJHNo4txEe+5SNr2wom?=
 =?us-ascii?Q?VOvnMv5Y5CJGZ3TjUsEeHqzeZaGe8LuH6CfldS9R659jkhjKGqlyDTAR9qdm?=
 =?us-ascii?Q?GIhdAQc9IrCBu9nX4+2GeNvWDpe0vHtaM7o0yYOioYSLAD7volBz4KCnTw5u?=
 =?us-ascii?Q?Q/uY6eMTeSUCdl1D3ABV6Zh9TJuBeRaEKLkVfF4U6ByzB0L2Rs8F9rJW0fsj?=
 =?us-ascii?Q?JhU+SZc8DM6oTisjpoZFQX5UyYhhOTfkWREgizmGpYZNCCS0y/9CRPSvjrEa?=
 =?us-ascii?Q?KvBGzkBGWDpbJKdKR4yo5yYJsZCSpfJp3Ho4XoHK/bPB7fDvMELxvSHIeHLs?=
 =?us-ascii?Q?tmLZA70OZ/rRXf18OHIkGazd3fzi2oo3/ERahq8o3QMjzKCUcESKtgferF/c?=
 =?us-ascii?Q?Y8D+Li5O9IVj1XP6llIAplHl9N1ClWrsGSOxHhmU4REWAQ+cAqSAV/6/YRKW?=
 =?us-ascii?Q?OYi8k8YSMCYQREKqiiX50p4WAenhK5EpAX9uRWyQus+Wi9SA9qN1TMyBilHl?=
 =?us-ascii?Q?VyRNWngdr0CvzAaLahFaUWdk4kEe5eqMjX8Tg8swx+ftTlcx1bsyscmo1x7o?=
 =?us-ascii?Q?R2ar0ClGXqpDAH0dGphoHL7GKLEn2gyZMB1OV4aGNXPZ0fwQ0mJdUBvqaGyp?=
 =?us-ascii?Q?kL6F+kOZpGi+Ef3QebtU7WFXiXroyNF02lTHzUrL35Bj5VAk+kGMCFBfRCUi?=
 =?us-ascii?Q?diH4jK0xo6Jv2huUDZgrZpzL6MY40NXJEzi7zgoTMwt6Y7wLjXyTeqYbWMCL?=
 =?us-ascii?Q?KAuWz8mv2j9FKZNToO5Bro0XJ2MVW5so7Oat0kk0Q/tA9gk7VI8B07HhZz4w?=
 =?us-ascii?Q?BwpXpWPoHmXdVaIruqSM4BXrp042pkhgC8LKAc8Kah4jKg3CJ/EGIx1UPbaL?=
 =?us-ascii?Q?c7kqPabOXaBXE5QHP+G5R901/Hz3rgVeix29/2cOqlsXQFlJcSObD+Dzz6HN?=
 =?us-ascii?Q?ygu75ckaOUTRjKrQnVVk8ArZjv2+2E79vnQDlNkuVFFOLSBZBHnmdhAPLwbt?=
 =?us-ascii?Q?YQB0U0THmIEAd2xVGyEWBbNzXO9EJ8Na8zQgG8JJIG5z8xeODZ9k4hcGygb9?=
 =?us-ascii?Q?Ha56rSa/PR8TLrbmviul8vPEQlEV7AtSvjz51sIw81nSI0py4MFQu6aC9BZN?=
 =?us-ascii?Q?/IMWuiBlzniSHS45e0ZMleum19cccIL0QDjldNHgoX7V/E2bITQj/qddjZ5U?=
 =?us-ascii?Q?hXWuJfdDvwCAY3ggBuLSBBksnx2IUXbgqLjJgnhUo+qgXi7moAhQwoOo5xK6?=
 =?us-ascii?Q?e+myX2j3iN4p9Rj6X8ddppmVsPKr6RyD94KRjglvr/QeDW5EQWnsCHse+U1E?=
 =?us-ascii?Q?gjlj3INWrIVa8iENKUMtOpI4STY9mVF8aGWlIqVDNwDTgXINW/l4wfng42W3?=
 =?us-ascii?Q?nmMz2RpcapV9Mzx8V0igJuTfOUQIp32BmAhOtiGFX/7v2/fF/k5LpA1p2KfB?=
 =?us-ascii?Q?kPWU4x7dlwsMS7yDVtiOrw5B/jKKnHqs9MjvzA8DEcVa+D8IQhMBQlY8ufQ/?=
 =?us-ascii?Q?lhia8T5tgAiX83xR6WExDZidj64gNczSjNbWBJLx?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60c0caaa-4eb9-43c5-8024-08dbe6c64e7d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 17:05:59.8747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T0cKHpYt3kxWhjpKj3HN9SgQePNnx2JmVLfYV2EZup/SJdlh9YtgDVxsvw5bsjU1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6458
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 09:06:15 -0800 (PST)

On Wed, Nov 15, 2023 at 06:25:44PM +0000, Robin Murphy wrote:
> It turns out there are more subtle races beyond just the main part of
> __iommu_probe_device() itself running in parallel - the dev_iommu_free()
> on the way out of an unsuccessful probe can still manage to trip up
> concurrent accesses to a device's fwspec. Thus, extend the scope of
> iommu_probe_device_lock() to also serialise fwspec creation and initial
> retrieval.
> 
> Reported-by: Zhenhua Huang <quic_zhenhuah@quicinc.com>
> Link: https://lore.kernel.org/linux-iommu/e2e20e1c-6450-4ac5-9804-b0000acdf7de@quicinc.com/
> Fixes: 01657bc14a39 ("iommu: Avoid races around device probe")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> 
> This is my idea of a viable fix, since it does not need a 700-line
> diffstat to make the code do what it was already *trying* to do anyway.
> This stuff should fundamentally not be hanging off driver probe in the
> first place, so I'd rather get on with removing the underlying
> brokenness than waste time and effort polishing it any further.

I'm fine with this as some hacky backport, but I don't want to see
this cross-layer leakage left in the next merge window.

ie we should still do my other series on top of and reverting this.

I've poked at moving parts of it under probe and I think we can do
substantial amounts in about two more series and a tidy a bunch of
other stuff too.

Jason