Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3436211rdb; Thu, 16 Nov 2023 09:21:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3s4afn1want6UMrYadtTFkM7kBXQOAAhBM564yf3jY8sqHeK5JDmCl5KorkGNjcN/AKOl X-Received: by 2002:a05:6808:22a2:b0:3b6:c3af:b67f with SMTP id bo34-20020a05680822a200b003b6c3afb67fmr23074398oib.30.1700155316694; Thu, 16 Nov 2023 09:21:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700155316; cv=none; d=google.com; s=arc-20160816; b=BZFbNsm3ONDs9Wj9+nFilfxg2sCw4Pv63fzglgUtGjj004a16I5LFlom+92xjnTsar dy91nPi7+wGYSKYbBoP7yKwnGZxTS93tgn8AjwzQ1md3aV5jP27kWkTurki9DebpsTWH ZOWkVrheBaNSJGvOoyQwp7XLF9S9FJtRYSSWwEllJxrUFUu+BwpbClcg0v1h0Phtdtts ZPvMTozzsYgBE7TTnf8yCt7/wvYy3HEQ4Q2kJpvF2UltYWIZEL4BBVEcBaLndiOB3vMh Wu2ih6HA7oI5TIAPFukzjnqmDyFLUEOmMejmrNjINZ5cXO7Hr0zhx1d4H7RQPsKcEiVU 3p6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kK3KutISbyzM/gZLq4IFiwimjsmvHKjNrd1uA1A3zdk=; fh=Dz4XB9vAk6fRDFz98grJ/EA/Tj8GsQegDbU/hWBWYzo=; b=0Sax4zLWKZrm/p+T6QqiIVeVOfrZgJbsFvtv4Cgbd5Rd0l4eBRgDZwyvwhDLVyjQbG HESkecRzV6ZSrJolYkKZEwQRWHKUotgDSksR7eIoeX80CBYCVWSc4ovEHLtVKBqJCj44 rQbWzqmrXCxH3s/FJlAx9mjwzX5DqeHkLlbZEq9ZFdtUeevsnZqhUBM4rkaX40/AQN0q iSiVQPIqEjzZizMv5QxwE6IH6yQrNRaAVToMO6RUEXIC7CIwkNQflpz4t5Kn75fkMUbt HTeyItqDxQU3b8rzeU5oZxGV6ioLRHhMmApGkczJX8Ob9wyfBYNb+rNaXW16dwaVl0sG 1FEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Cymw9iWC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id k185-20020a6384c2000000b00577f87e6210si12860446pgd.332.2023.11.16.09.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 09:21:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Cymw9iWC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 5C2CB8080D64; Thu, 16 Nov 2023 09:21:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231327AbjKPRVB (ORCPT + 99 others); Thu, 16 Nov 2023 12:21:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbjKPRU7 (ORCPT ); Thu, 16 Nov 2023 12:20:59 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A308F101; Thu, 16 Nov 2023 09:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kK3KutISbyzM/gZLq4IFiwimjsmvHKjNrd1uA1A3zdk=; b=Cymw9iWCOK3pJBrbiAyPOtls8Y RFFPgN0hIKnaOnVu0b2o52K1veB+NB7Y5os8q3N+Ckf55ZTL9qZQWPMg5k5FBMNcaMX4XuT0Bfy9H 2W/x9f6h+sD3gqaoJ+tnwhp7MsWCEspFf9oK0sx7AZKfHXZuGLTOyjDzBGsJEQd89F4g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r3g2p-000NKU-Pf; Thu, 16 Nov 2023 18:20:47 +0100 Date: Thu, 16 Nov 2023 18:20:47 +0100 From: Andrew Lunn To: Jie Luo Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com Subject: Re: [PATCH 3/9] net: mdio: ipq4019: Enable GPIO reset for ipq5332 platform Message-ID: References: <20231115032515.4249-1-quic_luoj@quicinc.com> <20231115032515.4249-4-quic_luoj@quicinc.com> <33246b49-2579-4889-9fcb-babec5003a88@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33246b49-2579-4889-9fcb-babec5003a88@quicinc.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 16 Nov 2023 09:21:10 -0800 (PST) > FYI, here is the sequence to bring up qca8084. > a. enable clock output to qca8084. > b. do gpio reset of qca8084. > c. customize MDIO address and initialization configurations. > d. the PHY ID can be acquired. This all sounds like it is specific to the qca8084, so it should be in the driver for the qca8084. Its been pointed out you can get the driver to load by using the PHY ID in the compatible. You want the SoC clock driver to export a CCF clock, which the PHY driver can use. The PHY driver should also be able to get the GPIO. So i think the PHY driver can do all this. Andrew