Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 16 Nov 2023 09:32:16 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     xingwei lee <xrivendell7@gmail.com>
Cc:     syzbot+93e7c679006f0d4e6105@syzkaller.appspotmail.com,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, llvm@lists.linux.dev, muchun.song@linux.dev,
        Nathan Chancellor <nathan@kernel.org>, ndesaulniers@google.com,
        syzkaller-bugs@googlegroups.com, trix@redhat.com
Subject: Re: [syzbot] [mm?] general protection fault in hugetlb_vma_lock_read
Message-ID: <20231116173216.GA7883@monkey>
References: <CABOYnLzpDMPd3fJhi38N_jcQS6ZSa8RNik5j_APKQYNk0kJRkw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABOYnLzpDMPd3fJhi38N_jcQS6ZSa8RNik5j_APKQYNk0kJRkw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?urn8AzUmorxU0hLDWLLbwGtmVNIfyA71wFiQvRUdHacuIAxK1pNCw8RLEFeX?=
 =?us-ascii?Q?RyO4Bn7bGl4/dUDMkdd0jgfcb3XONK63Awye7vcGPcHwHNr7oxvEaXzuHwhq?=
 =?us-ascii?Q?aS5h39qsmxDX+ZtT0s496nIpfoJV2ezo8MXWXj+TUGStHMO4mZhb1W5+Mt7V?=
 =?us-ascii?Q?lB+QA+90ticTgKCGpCwyVdry8t87FJBlopESvOJhuEFLQzhaNoBXdVISf5jf?=
 =?us-ascii?Q?9VvrXjIbss6BZkPc3r8Oiz3avi3XYGftbFxm3HG+QVOYES/LaoltlBS3iiDC?=
 =?us-ascii?Q?gR/MWk+qejI8dCHP+u2cYBSvVMw6XwNevBDYZyvztfYIWH/VdKCchf7LxCO4?=
 =?us-ascii?Q?CpT0w2YI2Bq+67ECXAXgLqCsHF6tCrSuX6oXLWl5B/CYGH7TkcP2ZV7rTDdL?=
 =?us-ascii?Q?adrsbfYXo5XBqhJDbqcc9H8eHIJe9VwT1MIfA4k78L0bVPKsyft/vBIJZwgd?=
 =?us-ascii?Q?4YRYzQMRpqLkVOC7SwvICA4Z9Gxdd1FPpsoiz+2kxmCifuF6gNBp42Ww4Bic?=
 =?us-ascii?Q?PMFluZiobgkudvgbbquT06aUc34f+ACgHYwmTIeq7l6psZ+aUhyvB0xms04p?=
 =?us-ascii?Q?T8CMOtJoY4YQ8ZgtemM0+nj0P49N3U3/5JURGqqKSrIJ1wi2xUgeb2eiEf5N?=
 =?us-ascii?Q?yOb879UnHnftU6+kWRNtn8k7iQTL936kUsxzjIqJpZYykcrYQchDAGblYKHs?=
 =?us-ascii?Q?qulBBYpGRs994xcTsj+bIBrKwPsKXnlpVP2jSP1vnyDQXjqYUUjDFAq9BvHb?=
 =?us-ascii?Q?IDl2+ffjNXFIs1/sWJijz2CfCEd/EKHbCjZvOV+CQl3Z+FKyPg78OiPT3IHe?=
 =?us-ascii?Q?f9KkhYBejUuiBV5e+UyQI63daSDAROYqvNMVjHOaeXuKcDqv4ppM/W5rOcpv?=
 =?us-ascii?Q?kmT5oYe335i8azh1fytwa7gSveAzax8OdYH17YGGyhJ99nhkfYZ4oiKYTDHw?=
 =?us-ascii?Q?dewIVSSqYFhlGWG303KhUURoy5v4jG5l/fbubWAfJ33UU8pDKhcCcKEstmiS?=
 =?us-ascii?Q?oD4gsJuKjrO/QnVuOqANRXvWiv7rFUUcHofhE6hBEpAKhtIAx0TtCf8ShjL5?=
 =?us-ascii?Q?Giz8ceYlW+ewcChJ6Xcx29UF6HP3frdFoVkon752afhpDMLpJo9XG4g9ExfU?=
 =?us-ascii?Q?yf5gl7xtfXHPBOLt+dJ2W+n/HuhN8q7axrHQXpESDHUJwpNCaDQWZrhaNEUc?=
 =?us-ascii?Q?h4qhqG9w229hQ4fLEr1YJAOvwcl5jyXHbz46BF0HpG/+dkgE53bJwYmZf3+8?=
 =?us-ascii?Q?MKMRz/EcMdeiEhEtJruSWlAcv1m45GnYIXcjIA7FbgBdETorxl/A6nF25Xc1?=
 =?us-ascii?Q?FmL2H8ZIQfdu6P+HOwbXiBC4RoSIwhHRJggiT8ZPwFa0eoqx4LZ14Cc+Hb/v?=
 =?us-ascii?Q?E4/YXJBIes1xjHC1WbA8n7vYmqchTpkkUEXWgvc4eiA/WNEpKDWTjnruj/uq?=
 =?us-ascii?Q?9BKft3Vw4DnfX3nfVIsrG1eWOhIOQnETT8KKPo7a6Rh4QYS8lqCq+NZRKbiU?=
 =?us-ascii?Q?K6qo2iUukssDt0xxdkdOdUMt3vyqzQSqfj5hQ4bVw9sqi7nzG29goU98zcKl?=
 =?us-ascii?Q?eZh8dOFNUOSRCddqXRCm2Bj2fh4XE4pri6SEB9eg?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?pFOX2yoRkkCZRuguJ4wMgW6KeMmvjrRytnXq92B72lVnDznPBxyyZ1b4Cwl9?=
 =?us-ascii?Q?rS73z1ugtMTSyN8jwDpiU/EmZr0idsfgVI9jMgg45X6fMY3YOTNmenukymTV?=
 =?us-ascii?Q?wbXGRHbd02BtRwFTeS2++5Nj6SqSApGYBUAcHt4at0Z9M0YxKLYnkDiPSuYP?=
 =?us-ascii?Q?7EIT3xb2OYhSr4pKmhVzoKO42y++djKZpxIp9xqM4dXOuckDomVN+3ixC5Kr?=
 =?us-ascii?Q?h8dAQKEgsggXww4EFLF6+8d3Hcx+VffwFHKThaKz8V4GhOBWQC3aejGqWfcJ?=
 =?us-ascii?Q?ojkV3rEZo3LALzvzqrABiUniNzzipunJtfKY6OteFp5K8jPLWV8Nq1F7KuwB?=
 =?us-ascii?Q?BORTChXOHmEODj9gwhNB475IhxR4zsOU2d3olu150Oaw9/x+Jo8S5Fgv25eO?=
 =?us-ascii?Q?5iM7vNbPNce6n7UNvqkFG1/7aUZSgUzQCs+tSYnnNJfqdTkvcxL04C46JCp2?=
 =?us-ascii?Q?xedkRIDielQJbWnhsRVlAoxj8WnrK1umL07Niooy9VNzxa10LSYabeX7m7l/?=
 =?us-ascii?Q?CxwbeG+7RsBiXcLoxMNohF1SvhGdVIJtYYr56aVNKoaG8v7FVYefGAv4MUlb?=
 =?us-ascii?Q?3qCtPhUS70J27yF+zCaa8vgXB33Q+48JJ7roFGX8+wKDeOTonRofYf1bHXsr?=
 =?us-ascii?Q?bW0LD9+6/q2VllaQ5b3Tfx7+okf3EWdjhsYQRYrolknuUF+nTSn409JWHS4I?=
 =?us-ascii?Q?uxui34eN4E42KlO0ITGSPy6rrr411zC5vfXPAw89eEqYhn2tffTG1cgfI307?=
 =?us-ascii?Q?unAv71EVKiekIhtkQDxWOjYivk4V29Dzp0Jzmh+LxxPqQgwJ2VmOw/uXiu2s?=
 =?us-ascii?Q?idAYqkyd9izqUV03P83H94OBzeV5Kgl02pt2G83hWzUbXuhc3ja8FJaluHEX?=
 =?us-ascii?Q?h2sCQHUoRLFKjvzjtTzT73e5NXsS6Fny+NqRzE8rMDYBSrrorS9FXP4qKi58?=
 =?us-ascii?Q?eGyxZeqx0OFv92owsknmyD0Cx22sJS9IflVU+TvF36B0gfz+VUVm6+3KyRIY?=
 =?us-ascii?Q?BTBdNhWwzcMuPBGz6ih2ZrAVedPNeYcv5LqBEXLjFKnkRNre4CF9cPxRbdBo?=
 =?us-ascii?Q?iIRlxhB0Me5PldiSQHuwY1FJCjzfk40b7iWpmqCL/FmhgaBCMHAK2Y+7O7pD?=
 =?us-ascii?Q?gOhX8N8phW7QS+trz3AjekYuLUPyzebmGw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a14b14ae-24a7-456e-6997-08dbe6c9fbbf
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 17:32:19.1605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HscHnyLP241b43Sv0+TxPc+LxEhwH9LJVHkkU4/G6CTzsW36JbvSSKN3Ambq27IonIrGWalN6AgeLX/m2ibm+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6715
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_18,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311160137
X-Proofpoint-GUID: Ksz4E0u7JAwgvOgGmjsyByygKROZ5GAA
X-Proofpoint-ORIG-GUID: Ksz4E0u7JAwgvOgGmjsyByygKROZ5GAA
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 09:32:54 -0800 (PST)

On 11/16/23 15:53, xingwei lee wrote:
> Hello, since I found there is no reproduce from then to now. I try to
> reproduce this bug to generate repro.c.
> Maybe this bug is the same bug as [syzbot] [mm?] general protection fault
> in hugetlb_vma_lock_write I guess...
> But no matter what, with the reproduce.c, we can quickly fix this bug or
> check the correctness of our fix.

I am not sure what fix you suggested for this issue.  The following was
sent upstream and is now included in Andrew's tree and linux-next.

https://lore.kernel.org/linux-mm/20231114012033.259600-1-mike.kravetz@oracle.com/

I tested with a reproducer previously provided by syzbot, and assume this
resolves the issue with your reproducer as well.
-- 
Mike Kravetz