Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <f9360f2d-ad2d-4f06-bf01-85b2630cd237@oracle.com>
Date:   Thu, 16 Nov 2023 09:55:42 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 02/13] Documentation/x86: Secure Launch kernel
 documentation
To:     Alyssa Ross <hi@alyssa.is>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, luto@amacapital.net,
        nivedita@alum.mit.edu, kanth.ghatraju@oracle.com,
        trenchboot-devel@googlegroups.com
References: <20231110222751.219836-1-ross.philipson@oracle.com>
 <20231110222751.219836-3-ross.philipson@oracle.com>
 <scpu273f2mprr2uvjlyk2xrjjtcduhse2eb45lmj7givn6jh4u@i2v4f2vbldu4>
Content-Language: en-US
From:   ross.philipson@oracle.com
In-Reply-To: <scpu273f2mprr2uvjlyk2xrjjtcduhse2eb45lmj7givn6jh4u@i2v4f2vbldu4>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXdtUjFtWXVSWUp0QkNPSTQ5c0I4RUpKUG0rTml5UTJVNzhqUW44cWUxV2lF?=
 =?utf-8?B?YkVyN0VxMVoyUUxxcm1ZWW4rWTR1azg0VHRXcGJkMSs4OUZrVVY3clh1a1hn?=
 =?utf-8?B?WUVQL2hWSURZbmN4VEFBbFp2TFZTOXZqRDBCSDRNMG1FMElGMnducWRSSHNG?=
 =?utf-8?B?aUYxcER6ZEJYY2FOTysyb09DaTIwaXZnQXVxNXNYemgxWUloSDl4alJjSEpC?=
 =?utf-8?B?eUxjQm1VVmxNMDVnL1dsbDNlc3l0VjdGcC83RlJkWEIxaUEyNzU0Tk9URnV2?=
 =?utf-8?B?aExmak5abEp6YmwzT2lXc2RES2xTb2pvMXA4dkg2UkRqcEV4TmplUzhFTkRQ?=
 =?utf-8?B?dTZ6bUpoMldHcmFlQlJmRXdZNzAwQ29jUDhvT3A2L1IwNjlQajMwRzltNWgr?=
 =?utf-8?B?eEFoOUs0TGh0cHA2cUMvbUxCQTJhdmZJQXhBRUNlM3B3b1FIK1dld3I4azRl?=
 =?utf-8?B?WDUwYTcyRDdERVpsZDNzSElZb0w3N3lvT2FVNDhmVVQ4NFFCZENpbzhxa3BL?=
 =?utf-8?B?a3A3T292UzB6S3hSdVJ3SXJISUNnRkQ2WUc4Q0VMek5HUkMzVTVkS2x3UU42?=
 =?utf-8?B?bXREM09TUUNLTk1WNnRZN1c3Zjgrem9ZT1RvTWJ4SHdQL2tvM3VhUWZGaXJL?=
 =?utf-8?B?NlhkMHgwZWh3ODdoWXhJdjU2VlRqeUJwRnBabWVLemJITWRpcjJ1cGhMbGQy?=
 =?utf-8?B?ai9Xbkh1ZHNDNklEekFZcElvYVZsS0t2clFWMnY3QnpTVFRISW1BcWhzL2du?=
 =?utf-8?B?TlQ1Z1dZU25Lc3VFeEsyNjEydmNwaVkwb3N2WkQ2TkdvYTJ2Tlgvbis0MFZ4?=
 =?utf-8?B?UVB0NGEvRnRsWm9Kell0Uy9YOFN2cllwR3FBMzVXU3VOZytLTklRbXJScWZn?=
 =?utf-8?B?cWJSUEJ0TktMTnVwdHhPcmFBU0hxbVBCMkdVUm1BTGJ4L25LVFlyNkFMWGox?=
 =?utf-8?B?Qkl5T3JvQW1VbW1hL2FHTjdabmFuZGZSKytyVnRzMUNxTm9kZmxuenh5MnU4?=
 =?utf-8?B?QlQ5cEFGV3A3a3Q2aXBsZjc5OGNTeUJYNmxQQ1BaRkE3RWRYVVc5NkRiUnkv?=
 =?utf-8?B?d1VmT0VpeXg4elJKeEdGbFBWaVNlc3dFRWFjcEVBaXQyNHJEYVg0R0x5NWUy?=
 =?utf-8?B?R21LclJiRFFvZ2NUMGNMM1BXZzFmUXRBM1RTdFhFQzViWEZXRmVzb29ZaFJO?=
 =?utf-8?B?TWt4UkU0TGFJSkxhaWE5QU1iQm9pMXExaVdNOE1rdFF5NWJwT0dGTDIrSGtL?=
 =?utf-8?B?VzNDcHBKaC9kUytuOTlsa1MzdzVpNUlSNEFKd2l4dndCVExkWWxoeFFTOTl1?=
 =?utf-8?B?VjJRaTV0aGdCUDFvbGdCVW94MjZ2Yk90a01hKzhweTkwQXh2Und2eUpLRitt?=
 =?utf-8?B?eUFZcE5wOC9pNXJQbENVUTk2K2ZURERiaGxHdEwxa2lrbFVISksvbWVlMGRu?=
 =?utf-8?B?b1pObkVNTVQ5cGt0UTZ5QlBZNXZ0V2owY1plbmRaQUppTHlzTFoyYlQxR1Rr?=
 =?utf-8?B?ODl1VkVoNEJPSWhxOFY2SncvY01lU2ExbGFDZXBrNGFBUndjMDBvOXFRdUhv?=
 =?utf-8?B?SE5YWDA4UXd4R1hGT3F5Q2JxcTFLNUExd3I3V1R5d29Zelk5UGRpUTlEa2Ri?=
 =?utf-8?B?M2xDT3ZOMnZBa0owVGw4K0ZkVkRQaTIrSk1xT1BJY2Vuem93a2I2M3NRZjRM?=
 =?utf-8?B?MlIraU0wcHR1WEtpbUF4S0hYN1VocEVJRHUzeDZvblBEcVRmUUR5K1VkYjkw?=
 =?utf-8?B?NHNrVlBTTkkvZ0EwaGxCVmhYeXB6STA3UW5iWlF6ZkpPT29BMDlHOTV1SmdW?=
 =?utf-8?B?dm5PVFN2Q2lQclhkWUpPRkVHZ1AzRzJDRXI5UWdrTzgzSlhwbVhkSlplK2Ez?=
 =?utf-8?B?VWdTSmZKSFNyelhKNXNsaGo5ZXQyLzgvSHcwUlJleVY2c2xwbVpLMWhaSEV6?=
 =?utf-8?B?cG5rcFdLZG9yMHp0VzV4cVBCSkdGdFdyWG9iNkp6Ti9UMHRPSlJHemVQK2Rh?=
 =?utf-8?B?S0pmWnhtU1JsckZ2eSs0eDcrcFNOT1E2M21VaWNsWndvaWFkcU84RWFZKy9G?=
 =?utf-8?B?cEI4ZzBXNHE2WjhVUTR6RDhDbXduVWN0K2dPaG1ZSFIvQ2cvUE9IengyK1I0?=
 =?utf-8?B?V05qbHJEeUR6RmdIU2twVzVtYnVTN3RBTXpsMVU4ODE1ZHlQdnI5RzAvUUQ4?=
 =?utf-8?B?aXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?TXlLMDRvTy9RdDQ2WnowdElKai83bEhvY0NZajh5ZXU2WXQ5bHhLM2NIKzh2?=
 =?utf-8?B?eFBsYk5sKzBCQ3ZNbDNLUDJUdzRJZkZ6TXlzYVNYS0YycXVMU09UakVaTVpr?=
 =?utf-8?B?cnBwRkVvZVJsVXBtbk13UGw5WTJBWDRNQUhFQ0hUK01ub0Q1ZFhJNU1pZzVH?=
 =?utf-8?B?c3A1UkE1ajh4d1VKU3JiamRobGNWQmdMODZQYzhzd3NOVWE0emhtSmhaSjBs?=
 =?utf-8?B?N3pEVWRJYTMwcGFVdnVVNlVkbjFJS3dDcmhWMTBuOExIOHR5NmRlbDQ3Tnkx?=
 =?utf-8?B?bWcrTnUyd2lGVU5UNUhwSGRIWkJxaGZyR2x3QWxjOWFmWFlaSU1KaEJPUStC?=
 =?utf-8?B?b1JvVEsxOWxuQUd1WnhFMzlBUVIxUnA4SDAyOW9iMmp4WTBMUjh0TndsbmRr?=
 =?utf-8?B?VXI3ZDA0dDNMTmdpRFZTRFY2THFMRzloRG4rUllFMXVmR29NUndVOEFVanJq?=
 =?utf-8?B?OHJYUlp4S2ttTktMZDBBUUNwM0ZvOGpBNjNMckFlMk9mbXNOT0tBZ2ZYUVFE?=
 =?utf-8?B?bmpDelFYTE5seS92d1NEYldLa0F1WnE5NEVkaEF5b0dWVXVPaTBqd3pVVndl?=
 =?utf-8?B?a1B6WFdnRjZmNlhGbS9lamc3dlNBTGtUNmxHSHJFeWpoUW5VRnFFTVRmK3ov?=
 =?utf-8?B?UHp6YlBTU1U4ZS9mazI0ekJJbndOOWNENUxIUlJWVmR6ZTQwb1VjNHdUVTk3?=
 =?utf-8?B?c1lrR3MxNFRxb3NCMVNTMDJQbjg0Um1vZm03YVphVXQ1Nlo3eElJM1Q2Sk9X?=
 =?utf-8?B?MWVKUGVXcUZyd04rTWx0UTl0L3BKYVRPaGR6SFV4eW1IVThlOTBMTTlOQ0Jk?=
 =?utf-8?B?MmZhU0tnMHJoTnA1anE0QXFuRmlJZE50VlJSWUE4UlNLZThQWENmRVBYQVV1?=
 =?utf-8?B?WDVyU0JUc3Jab0sySS9xdlZpdmc4NVV3UHNSQ1JDWHJCWUxmTEFjZmNTRUJv?=
 =?utf-8?B?MjZYY2puUkM1YU1jS1RjU1BremVCM0dOTUVlaGFFNndLdWxxbzgxRjF1ZnFK?=
 =?utf-8?B?TExiSTBGSlNMSDFtZWV4YXd1RUZBbEl1SGo1dEJoMUM1cXRiQjBwQldKZmJJ?=
 =?utf-8?B?dmhaUzMrcytFRjRXSVRldmNCakF6cEN0QUlLOG53N2JnR3FpZFNyS3ljZDF4?=
 =?utf-8?B?LzNRSHMyRmN0eVA5RGZlcDdiNHo3a2x3UXU0NTI2V3lzSklza1FuYmtBZjY5?=
 =?utf-8?B?OXdWQnZoL25XLzlWWEpYMEZvYkZ3amN4UlpQNW5hZUZPNTNJQk5tRCtrQlUz?=
 =?utf-8?B?cmZlN1NOZkYxczdYYTI0NWZIWkl5aTBDV2MwRDhDeVJBOG1VYmNpZEc3Zy9K?=
 =?utf-8?B?V3g5Y0M2SGpualhOZXYrdXhXemg5VG9jRkNXVi82VlprSSs5OU5xVkEwb3Jt?=
 =?utf-8?B?VzNXR0hjMEhxdmVldC9KUmpUcmJlL0hHTkl0TnNwR3Z4RWhzNk5OdTlldjN1?=
 =?utf-8?B?ZXpZQ3k5c1NTNlk4T2dyZmh5cHJaY1RkQitOUy9vTzhmYS9WdkFOSEF4NnF3?=
 =?utf-8?B?K3FWVXpvY3BkR2FqYTRMbVFDRXg4WDE4eUdXcFpESVNFbU9DM0FuQ3Q3Qits?=
 =?utf-8?B?cHN3ZzNSMTBoOW4rRFp0SkxZY2NXUHdGcDl1RWEya2xlaTU0NUZxcnNJR3Ry?=
 =?utf-8?B?c3ArT3VyQnVXakVJOXY5OVpnTnBDTVlNSDFIeXcwOUJlSU9UclJJcm93Z2I0?=
 =?utf-8?B?YzRNeFByVE8wSUFzWUMvVmpCODd2aFZNMVJWT05qZFZldXNqc284U012T3NO?=
 =?utf-8?B?Q0RwWFFjVEhiSXlxaElPMlJZS1RLeDJPNHIyZVNIZ25WVDUvaUxCazZ0bFUv?=
 =?utf-8?B?VEZpRWtaNGFxQ2dUbkc0QT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d373ba4-e543-4709-b630-08dbe6cd4272
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 17:55:46.9372
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cQZEfYB4oKdkOy0ugUVcM13N1m1Q5t8PVgiqfaSK8DLGmaFPL9adiQzsCE779Xr/77IVRU+zBbH34HPjNs/de9HUaDAJMwAT1kAIS2RjmOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5070
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_19,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311160141
X-Proofpoint-ORIG-GUID: yKGFYHt22MuYq_Za1nipAg2Dace2of0y
X-Proofpoint-GUID: yKGFYHt22MuYq_Za1nipAg2Dace2of0y
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 09:56:46 -0800 (PST)

On 11/12/23 10:07 AM, Alyssa Ross wrote:
>> +Load-time Integrity
>> +-------------------
>> +
>> +It is critical to understand what load-time integrity establishes about a
>> +system and what is assumed, i.e. what is being trusted. Load-time integrity is
>> +when a trusted entity, i.e. an entity with an assumed integrity, takes an
>> +action to assess an entity being loaded into memory before it is used. A
>> +variety of mechanisms may be used to conduct the assessment, each with
>> +different properties. A particular property is whether the mechanism creates an
>> +evidence of the assessment. Often either cryptographic signature checking or
>> +hashing are the common assessment operations used.
>> +
>> +A signature checking assessment functions by requiring a representation of the
>> +accepted authorities and uses those representations to assess if the entity has
>> +been signed by an accepted authority. The benefit to this process is that
>> +assessment process includes an adjudication of the assessment. The drawbacks
>> +are that 1) the adjudication is susceptible to tampering by the Trusted
>> +Computing Base (TCB), 2) there is no evidence to assert that an untampered
>> +adjudication was completed, and 3) the system must be an active participant in
>> +the key management infrastructure.
>> +
>> +A cryptographic hashing assessment does not adjudicate the assessment but
>> +instead, generates evidence of the assessment to be adjudicated independently.
>> +The benefits to this approach is that the assessment may be simple such that it
>> +may be implemented in an immutable mechanism, e.g. in hardware.  Additionally,
>> +it is possible for the adjudication to be conducted where it cannot be tampered
>> +with by the TCB. The drawback is that a compromised environment will be allowed
>> +to execute until an adjudication can be completed.
>> +
>> +Ultimately, load-time integrity provides confidence that the correct entity was
>> +loaded and in the absence of a run-time integrity mechanism assumes, i.e.
>> +trusts, that the entity will never become corrupted.
> 
> I'm somewhat familiar with this area, but not massively (so probably the
> sort of person this documentation is aimed at!), and this was the only
> section of the documentation I had trouble understanding.
> 
> The thing that confused me was that the first time I read this, I was
> thinking that a hashing assessment would be comparing the generated hash
> to a baked-in known good hash, simliar to how e.g. a verity root hash
> might be specified on the kernel command line, baked in to the OS image.
> This made me wonder why it wasn't considered to be adjudicated during
> assessment.  Upon reading it a second time, I now understand that what
> it's actually talking about is generating a hash, but not comparing it
> automatically against anything, and making it available for external
> adjudication somehow.

Yes there is nothing baked into an image in the way we currently use is. 
I take what you call a hashing assessment to be what we would call 
remote attestation where an independent agent assesses the state of the 
measured launch. This is indeed one of the primary use cases. There is 
another use case closer to the baked in one where secrets on the system 
are sealed to the TPM using a known good PCR configuration. Only by 
launching and attaining that known good state can the secrets be unsealed.

> 
> I don't know if the approach I first thought of is used in early boot
> at all, but it might be worth contrasting the cryptographic hashing
> assessment described here with it, because I imagine that I'm not going
> to be the only reader who's more used to thinking about integrity
> slightly later in the boot process where adjudicating based on a static
> hash is common, and who's mind is going to go to that when they read
> about a "cryptographic hashing assessment".
> 
> The rest of the documentation was easy to understand and very helpful to
> understanding system launch integrity.  Thanks!

I am glad it was helpful. We will revisit the section that caused 
confusion and see if we can make it clearer.

Thank you,
Ross