Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3458460rdb; Thu, 16 Nov 2023 09:57:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBYPZWCQOAFf3qs3LeRPZiZgdGLAKopGzaSRAMxunRhTl+7742uMIr4gplVwMM181eDVvx X-Received: by 2002:a17:90b:3805:b0:27c:f845:3e3f with SMTP id mq5-20020a17090b380500b0027cf8453e3fmr18385451pjb.1.1700157466270; Thu, 16 Nov 2023 09:57:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700157466; cv=none; d=google.com; s=arc-20160816; b=lW791FunkvNFBC5K40JqrYt1Fb9bfxJ8bXR0uH2x+wPA5QXInGnax+xIRWyde4j/d3 w+KtpBUW1mA5L/9AkR8IJV9GEJr1nwdeVfFzBjQ3iUS2TR0DOenRPjPXaIpR8LxLWO0R L0TpKdghdZe4jtAofX6cDt5/w0UIapWypOs1yAECgAdUwdeK5OVOADVsoVlORkD8pTVJ KncXty5TJTL3T3QgYuaVl5L44F9Bk+THxwhmWVcutLAXsprxdXb8XGnNEHe/vDMtmrzm ENDQFQev/LtyZx8HKRs+EGAN/wFsMfdGKdOnyChrkuaxUgnLMj8hf3vwlzxrQlOWEpwQ U/JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CpcCp7hyGCbYjsJZtxVhbV/XYGj5kIEIa20LIsTiit4=; fh=lfCD99QXWXkhJyfR4zt0DZybmnFbOPhGpoONGwjc3FI=; b=dJx58VrSpbWw1ldcluNXE9MLFncZ5IzxEuWjs7n5qhoULLdDIGO8+dc42WW2yCUrmW KqsOPxsH0tdzv9dDwfmrA01LP8pPZ9XjWj2+DooD0CnHWtbFFaB+YQmQSzSaj0Civ/bO Npfw5vyTT6iPGDucF6YdLL37a6QBOPUP8Nz/VRdgg9sLjQgtpU2wpWWq66MZM7B9AWGn Mp+DlcGdC+tEVm2hlIajxUBdkJaiummwDoRnbWI0g/H7JuGt2oVVXVxhfWMc/MK7LDsj wbfu4fCHUpyJUfOLctKBcF/n7/Lf0c8mYvf5ZQ9Xm0/rSIKQgMKUN6yir24Cle0WAGlx DyzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvkSz397; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id qj13-20020a17090b28cd00b0027d60ad5caesi4023pjb.110.2023.11.16.09.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 09:57:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvkSz397; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id EBC718041EA5; Thu, 16 Nov 2023 09:57:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbjKPR5g (ORCPT + 99 others); Thu, 16 Nov 2023 12:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjKPR5f (ORCPT ); Thu, 16 Nov 2023 12:57:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A04A189 for ; Thu, 16 Nov 2023 09:57:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CABEEC433C7; Thu, 16 Nov 2023 17:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700157448; bh=079Pe3XGihXMQHu0ceh9H6g0JWvnDy8gtyhx9MMkQNk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hvkSz397Sn+qS6t4bocQTXP8ivxDxbDs8N5vHG64NgRh0S91nKa8456WVf+EXFJkU OBxWj0fuTlrwoSrYAiuXflr+ZQYCTx86ss4V3lhVPYJe5yqSc5Amzx1c/RP6NbiaWr kk6lhBYsgofdEUxCY8QyaOIS9VXSP2O5LH6zpUL/oJwdoglLfNNyY0Y46v9dXH1sh7 oHoL2Ji404/Lw5DeAihBhYGTrXfG6g9XVYAl5BVPXXaunVDPljtMrU+aSIjc1MWqRK EQ+C56T69LcJXvu4qEI0ifULiP1kpI8I6J+UUseEqJdqc+L6CiOevvw9ZglJpaPBl6 RhjOY/dTlEfLQ== Date: Thu, 16 Nov 2023 17:57:24 +0000 From: Simon Horman To: Justin Lai Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, andrew@lunn.ch, pkshih@realtek.com, larry.chiu@realtek.com Subject: Re: [PATCH net-next v11 00/13] Add Realtek automotive PCIe driver Message-ID: <20231116175724.GF109951@vergenet.net> References: <20231115133414.1221480-1-justinlai0215@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115133414.1221480-1-justinlai0215@realtek.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 09:57:44 -0800 (PST) On Wed, Nov 15, 2023 at 09:34:01PM +0800, Justin Lai wrote: > This series includes adding realtek automotive ethernet driver > and adding rtase ethernet driver entry in MAINTAINERS file. > > This ethernet device driver for the PCIe interface of > Realtek Automotive Ethernet Switch,applicable to > RTL9054, RTL9068, RTL9072, RTL9075, RTL9068, RTL9071. ... > MAINTAINERS | 7 + > drivers/net/ethernet/realtek/Kconfig | 17 + > drivers/net/ethernet/realtek/Makefile | 1 + > drivers/net/ethernet/realtek/rtase/Makefile | 10 + > drivers/net/ethernet/realtek/rtase/rtase.h | 353 +++ > .../net/ethernet/realtek/rtase/rtase_main.c | 2542 +++++++++++++++++ > drivers/net/ethernet/realtek/rtase/tt.c | 2542 +++++++++++++++++ > drivers/net/ethernet/realtek/rtase/tt.h | 353 +++ Hi Justin, Unless I am mistaken, by the end of this patch set tt.c is identical to rtase_main.c, and tt.h is identical to rtase.h. If so, why? $ cd drivers/net/ethernet/realtek/rtase $ sha1sum *.[ch] | sort 9762c7f0fc1acb214d1705905495fad6b902a3c8 rtase.h 9762c7f0fc1acb214d1705905495fad6b902a3c8 tt.h ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291 rtase_main.c ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291 tt.c