Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 16 Nov 2023 11:02:20 -0800 (PST)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Shuai Xue <xueshuai@linux.alibaba.com>
cc:     Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        kaishen@linux.alibaba.com, helgaas@kernel.org,
        yangyicong@huawei.com, will@kernel.org,
        Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com,
        robin.murphy@arm.com, chengyou@linux.alibaba.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pci@vger.kernel.org, rdunlap@infradead.org,
        mark.rutland@arm.com, zhuo.song@linux.alibaba.com,
        renyu.zj@linux.alibaba.com
Subject: Re: [PATCH v10 4/5] drivers/perf: add DesignWare PCIe PMU driver
In-Reply-To: <7e383d7f-8df5-4d49-a45e-3dbe23b2c925@linux.alibaba.com>
Message-ID: <f18a97f0-a629-21c2-a772-b098262629e5@os.amperecomputing.com>
References: <20231104133216.42056-1-xueshuai@linux.alibaba.com> <20231104133216.42056-5-xueshuai@linux.alibaba.com> <32626689-c8b1-9bd-b00-5285c633bfbc@os.amperecomputing.com> <7e383d7f-8df5-4d49-a45e-3dbe23b2c925@linux.alibaba.com>
Content-Type: multipart/mixed; boundary="1372433909-1814920884-1700161374=:2081"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGZZVlpjSCsyVDZjSllSQzhNNXROemdXKzQ3RDVVSFRBNFUvRG5lYXZxRno0?=
 =?utf-8?B?dUVkMyt3NWI1cHZLaGlyaEVLc0l5UG1zOVdudmxTa2NGc1RvNzR6QnlXV0Yx?=
 =?utf-8?B?Nzc0VkxXczBoRFFGZ1BrOGZ4KzllcWhQMnJudi83Sk5NRTZaaHRNc0dQMElq?=
 =?utf-8?B?L0xqbzdUZ0dmTk0rRVV6cHIzY0xFeWRUenRFanNhL2FtNkkrNnBEZWtTQWph?=
 =?utf-8?B?cGl2V216dU1XWFk0SzBVV1BOZTRjcWNvSnBLbXJ3MzRCNUlyMEkzMjN0SkNR?=
 =?utf-8?B?UThSN3Q4VUs5dWZNZnJ6eldRWE1QZnRYbE5QNkRLZmxFd1hxT01KbzF6YU1O?=
 =?utf-8?B?VlVCeHN2Q0ZOL2VnSlJxVVhDd2hYaVVySWVqclRJenJWa1pLT1JBYjFkTUsy?=
 =?utf-8?B?eFdKSHhkbUxmOGZrSzNrWkRJZkV3UlIvNmQvNXg0SlVtbEplTkNlY1N3NG1R?=
 =?utf-8?B?SnZycDJMcVp1ckVVa0NJT2NiamZXa256MFNWajlQZmxFRmo5aUJQNnB4ajlJ?=
 =?utf-8?B?T1o3SFBGS0I1NkFGYUJ4T1dUSzhBM2tXd0drNFNDdFBMN0JHNGc1TjJodDRa?=
 =?utf-8?B?OVN5QnJpelRyQUo5NnJSV0toL2dDa3VsejdTa1IxZXRUSWR2dk1WWEdNUThD?=
 =?utf-8?B?WVBHYjZoZklYMjdkS3A1NHFIVThLS2dyK3pWUUorMCtFQ0RZb0R1cEwyaFg4?=
 =?utf-8?B?S0lJMm9SM2RPY3I5QWFZVDBlZyszYzdxVEJtZFI3SGM2dm94UVF6cTdyZDVh?=
 =?utf-8?B?UUVCQjcvMi9WN2l1K1FwZWxnRHdVR085VU5nS1NNU2JQYWNLRW12S2oxclNk?=
 =?utf-8?B?MWFYdkFwN3ZWdkV2cmtQd1VsQW5JeUlialUwSXlMWWpkYVNRZkgzN1crK1Nn?=
 =?utf-8?B?eTk2cHdEeFRhM2gzakc4WloxT3NHSG9ieUozWGdsZXJPOFpyTUFTYTBEYjBy?=
 =?utf-8?B?NlV6MzkzL0JIcmRxU2didE5NNVRsWTM4WEFHdCthWVRqNDNKeHB0VGxWajg1?=
 =?utf-8?B?ZDVIQnBVRFBIMHFMSEVmRHZmdXZMb010L21NVU5OYVIzQkhucnZNRmhXRHZI?=
 =?utf-8?B?TEZadUxpRXZad3VpcjU4dnFaN0lOSEFjenFoc0Q3alJYZlM5aVhjYWxMejZ4?=
 =?utf-8?B?S3JTeVQzQTFwanNreWIyMTNvbkdjeXhJRU4yNXFGemd6Z3N3YWZpeU5Xd3Ri?=
 =?utf-8?B?ME94RVZTb2xkcUQ0eHlSSnF4VjJyaDV6aVFCbWV0cTFXNGM1dUpjY2xQQmc4?=
 =?utf-8?B?dGdtOUs1NElCMTZiWm45US9vUkF5bEJtSW5iZWdVK3haaWNHc0tUTS8xM3k4?=
 =?utf-8?B?eWdxNmhvOE1RZUx3RFVRQUlUdWVVdkFaWW1CMFpucFpTSkc1eWJLVVlYdmcv?=
 =?utf-8?B?NXNrcFNnekRuUmwxZHVYdTNha245VzA0WmVOTUJmQmR6dG52aGVEaThlbmFU?=
 =?utf-8?B?dUZTa3h4WFE0Sy9udTg1akw3KzZ3Z2pqWFNBQVhvT0k0OFRodUc0L0ZYNDZ0?=
 =?utf-8?B?OGpoTEZBNyt1c2VuOFhPQ0JsMVIwc3VLb0VrZGQ1UkNRNDF0ZWtiSFcxa1Jn?=
 =?utf-8?B?alh4ZDVkZVB5Zmo1dXRpREVqUUVRQ3o2SVZKK2lBMnZyN2ZTbVV4YnhRR3Fi?=
 =?utf-8?B?bEpCWWIxbzRNL3k4REprZ245WUlGRDc4cGlIRXVwQllqUStQall5eiszcFQy?=
 =?utf-8?B?emp1RXlJVUQ5YXQ3SDIrV2VubG12SUxiSW12S2NKOHB0Nm9ZWS92cWRTWXZX?=
 =?utf-8?B?a0JxakpjREd5WEdvWGh2OU54VUxyTkhTb1hoMkVqZU1XR1lLZG9UaEVDUDlS?=
 =?utf-8?B?VU9iWUJGTDNoWm00OUFnSjFyRXdtUjZtckk1c0RzYXByNGJITGVkYVF5RUkv?=
 =?utf-8?B?ZklWTXZtc1hMemFSdW5QbTB3enp3YkdLS0lNSDRnbGozclFOZ3dUdDUrQnJp?=
 =?utf-8?B?OHlEdlFLK0dNRGFaSUc2TFBtZVVUbzluN0hnMHRtcElSd3RKcmtMaFhTaHBj?=
 =?utf-8?B?ci9qZTVtVmVCTlU4Tkl5LzUrVnhJVTB0TldkdStWQkloU2I4dmZpbHA0bzdq?=
 =?utf-8?B?MjMxVWcvSVIrZ2VYQ1Q5NnUrWlU2Ylh6M1dZZ1VWTzlmalJwT1FHdkN1aWhR?=
 =?utf-8?B?VkpVcEJkZ09FWUowQllHZ0xNWlBvRHRtQ2M0emhTeUUwR01FOHh6UTdVNnVl?=
 =?utf-8?Q?XdPlcxZKu0sZIuWZg6YZP2o=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5a0560b-e0c5-4d4a-bdaa-08dbe6d6a42d
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 19:02:55.7152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LTaRF6bupbLnDSqrcSAORZm9wS9L+F3uBYiq3u+uGSQqHVNEFG0gCTIFrC6Pslld0jAqxQ/k+62rEJL1VLPVTWsyHKnWFXBfU4MFO9zKLK+gJ5VpnJXo1rJGzqSVXDGp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7872
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 11:03:33 -0800 (PST)

--1372433909-1814920884-1700161374=:2081
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT


On Thu, 16 Nov 2023, Shuai Xue wrote:
> On 2023/11/16 11:50, Ilkka Koskinen wrote:
>>> +static int dwc_pcie_pmu_probe(struct platform_device *plat_dev)
>>> +{
>>> +    struct pci_dev *pdev = plat_dev->dev.platform_data;
>>> +    struct dwc_pcie_pmu *pcie_pmu;
>>> +    char *name;
>>> +    u32 bdf, val;
>>> +    u16 vsec;
>>> +    int ret;
>>> +
>>> +    vsec = pci_find_vsec_capability(pdev, PCI_VENDOR_ID_ALIBABA,
>>> +                    DWC_PCIE_VSEC_RAS_DES_ID);
>>
>> You nicely changed to use vendor list in this version but here the driver still tries to find Alibaba specific capability.
>
> Sorry, I missed here.
>
>> I guess, you could search again using the vendor list. The other option would be to make dwc_pcie_match_des_cap() to return the vendor id, pass it to dwc_pcie_register_dev(), which would add it to device's platform data with
>> the pointer to the pci device.
>
> The dwc_pcie_pmu_probe() is called by device which has DWC_PCIE_VSEC_RAS_DES_ID cap.
> So I guess I can use pdev->vendor directly here, e.g?
>
> 	pci_find_vsec_capability(pdev, pdev->vendor, DWC_PCIE_VSEC_RAS_DES_ID);


Oh, right. That seems correct.

Cheers, Ilkka

>
> Best Regards,
> Shuai
>
--1372433909-1814920884-1700161374=:2081--