Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231113112344.719-1-hkallweit1@gmail.com> <20231113112344.719-20-hkallweit1@gmail.com>
In-Reply-To: <20231113112344.719-20-hkallweit1@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 16 Nov 2023 14:14:29 -0500
Message-ID: <CADnq5_O66nHTSuLNfu42bPYZ_4ZOeoq7UzpxiWfGuixbgSyJvg@mail.gmail.com>
Subject: Re: [PATCH 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Maxime Ripard <mripard@kernel.org>, linux-i2c@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 13, 2023 at 6:24=E2=80=AFAM Heiner Kallweit <hkallweit1@gmail.c=
om> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

>
> ---
>  drivers/gpu/drm/display/drm_dp_helper.c       |    1 -
>  drivers/gpu/drm/display/drm_dp_mst_topology.c |    1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/di=
splay/drm_dp_helper.c
> index f3680f4e6..ac901f4b4 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux)
>         if (!aux->ddc.algo)
>                 drm_dp_aux_init(aux);
>
> -       aux->ddc.class =3D I2C_CLASS_DDC;
>         aux->ddc.owner =3D THIS_MODULE;
>         aux->ddc.dev.parent =3D aux->dev;
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/=
drm/display/drm_dp_mst_topology.c
> index 0e0d0e76d..4376e2c1f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_d=
p_mst_port *port)
>         aux->ddc.algo_data =3D aux;
>         aux->ddc.retries =3D 3;
>
> -       aux->ddc.class =3D I2C_CLASS_DDC;
>         aux->ddc.owner =3D THIS_MODULE;
>         /* FIXME: set the kdev of the port's connector as parent */
>         aux->ddc.dev.parent =3D parent_dev;
>