Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231113112344.719-1-hkallweit1@gmail.com> <20231113112344.719-8-hkallweit1@gmail.com>
In-Reply-To: <20231113112344.719-8-hkallweit1@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 16 Nov 2023 14:16:17 -0500
Message-ID: <CADnq5_OQ+hX5_vtKKRndSGZf1Gv8pW9E52ij7LdGb_eeQCgSQg@mail.gmail.com>
Subject: Re: [PATCH 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, linux-i2c@vger.kernel.org,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 13, 2023 at 6:24=E2=80=AFAM Heiner Kallweit <hkallweit1@gmail.c=
om> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Technically two separate drivers, if you feel like splitting it.  Either wa=
y,
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.

Alex

>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |    1 -
>  drivers/gpu/drm/radeon/radeon_i2c.c     |    1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/am=
d/amdgpu/amdgpu_i2c.c
> index 82608df43..d79cb13e1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
> @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_=
device *dev,
>
>         i2c->rec =3D *rec;
>         i2c->adapter.owner =3D THIS_MODULE;
> -       i2c->adapter.class =3D I2C_CLASS_DDC;
>         i2c->adapter.dev.parent =3D dev->dev;
>         i2c->dev =3D dev;
>         i2c_set_adapdata(&i2c->adapter, i2c);
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon=
/radeon_i2c.c
> index 314d066e6..3d174390a 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_=
device *dev,
>
>         i2c->rec =3D *rec;
>         i2c->adapter.owner =3D THIS_MODULE;
> -       i2c->adapter.class =3D I2C_CLASS_DDC;
>         i2c->adapter.dev.parent =3D dev->dev;
>         i2c->dev =3D dev;
>         i2c_set_adapdata(&i2c->adapter, i2c);
>