Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp47376rdb; Thu, 16 Nov 2023 11:28:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfsqpjw9efUhGs9S8AjoeH4ixLdlYVAOYewAxKrkmFY+Z5JR+beDQ7ofDvROrtSylrpM8B X-Received: by 2002:a9d:7442:0:b0:6d3:2584:b093 with SMTP id p2-20020a9d7442000000b006d32584b093mr9592970otk.11.1700162898677; Thu, 16 Nov 2023 11:28:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700162898; cv=none; d=google.com; s=arc-20160816; b=wN+a+1wC7NsAL04qssy6yVEuxtshFfMryLjJyfBoH4IXsiQ09rRwLG+nekerd5jJL7 wfp9mLM35Hqv1ITnKdJ45nHwAPkiPkrx044lVkFvJW6H3zaJezzpo4D+LtnfhfDOo9IE czrSY/EpwtHQzay5T5UKjAl1GmmH7De2Ol35lAAWfYk8GKj9W2ZhQ846JsooPtJQUATI 2o4p+oqicQVXgf0dZjkjjLiIOAjnX225LYpTBLJRF4asroUVE2Ej8FJEQGnitcP7VokY OHiOxRFEO2H1TUlYej1Y/7S6L/VDRtnEIDfRVYSPyKckk1s3fTjNZm8jZqmOrwBtq3GI vqww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=59iPbAMZiyZTi7WKmjnZ41LKuD87nn5zGs86cqkNHGo=; fh=DbV7s3hSFIqgggl1k1H5rha5Ox9HaHfFGskaIUlrB00=; b=FC3Q1z38eQYzt79KLxrCYbqOFgdX2Ns4VXGK6i4KA7LAqM2sD/Ly14O/iVuaiEsMps yJwHK4eMXK3TO2eF4iYGq1m4RY0E1vLJZgCx6uAWsB8e4VkVz8TpPi2AdL4K6F19MQhr iNSH2FGt+ssHc6Nzp7Z4c29lqDwlI6eWQmQOabrwj631sKKEzb/ubklIVbVkp0icHwi0 Pn95c3gux5zbwZuzzvJRn2QoL8tOPlMNzWhUEBLljYzs7KZOH0W/p54QUfjD1EB20kw4 Y/mIzsnRMZEQDyShlbYCRwkpWRFZEDFNlaYv6OTivWKR7wgFTSjNFzN66IcB2hqlg9AZ L1rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id w38-20020a631626000000b005bd03d2fda6si103396pgl.350.2023.11.16.11.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 11:28:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E94608031D68; Thu, 16 Nov 2023 11:28:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345496AbjKPT2A (ORCPT + 99 others); Thu, 16 Nov 2023 14:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbjKPT17 (ORCPT ); Thu, 16 Nov 2023 14:27:59 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76ACB18B; Thu, 16 Nov 2023 11:27:56 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D571BC433C7; Thu, 16 Nov 2023 19:27:55 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id AF8EF10613A1; Thu, 16 Nov 2023 20:27:49 +0100 (CET) From: Sebastian Reichel To: sre@kernel.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, Su Hui Cc: r-rivera-matos@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org In-Reply-To: <20231116041822.1378758-1-suhui@nfschina.com> References: <20231116041822.1378758-1-suhui@nfschina.com> Subject: Re: [PATCH] power: supply: bq256xx: fix some problem in bq256xx_hw_init Message-Id: <170016286968.830118.5959829920078266260.b4-ty@collabora.com> Date: Thu, 16 Nov 2023 20:27:49 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 16 Nov 2023 11:28:16 -0800 (PST) On Thu, 16 Nov 2023 12:18:23 +0800, Su Hui wrote: > smatch complains that there is a buffer overflow and clang complains > 'ret' is never read. > > Smatch error: > drivers/power/supply/bq256xx_charger.c:1578 bq256xx_hw_init() error: > buffer overflow 'bq256xx_watchdog_time' 4 <= 4 > > [...] Applied, thanks! [1/1] power: supply: bq256xx: fix some problem in bq256xx_hw_init commit: b55d073e6501dc6077edaa945a6dad8ac5c8bbab Best regards, -- Sebastian Reichel