Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Timur Tabi <ttabi@nvidia.com>
To:     "dakr@redhat.com" <dakr@redhat.com>,
        "gustavoars@kernel.org" <gustavoars@kernel.org>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH][next] nouveau/gsp: replace zero-length array
 with flex-array member and use __counted_by
Thread-Topic: [Nouveau] [PATCH][next] nouveau/gsp: replace zero-length array
 with flex-array member and use __counted_by
Thread-Index: AQHaGLhk0tg241wav0u8A6kt0NXJMLB9WXwAgAAC4oA=
Date:   Thu, 16 Nov 2023 19:55:54 +0000
Message-ID: <6517a6a41eb72d16596c913dc56467e0390287a3.camel@nvidia.com>
References: <ZVZbX7C5suLMiBf+@work> <ZVZxXiXYIzEwUE3N@pollux>
In-Reply-To: <ZVZxXiXYIzEwUE3N@pollux>
Accept-Language: en-US
Content-Language: en-US
user-agent: Evolution 3.44.4-0ubuntu2 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KnKaf+/6jXQ7y8309b6zVHZvkJZkFrBwdu1OaF70hbg3GJn2sjZA+gMApd?=
 =?iso-8859-1?Q?zlc7Dnv0ZMcf3UhOt3YmPnw6VZUQhEQ5OlUnFCCzEiFQeSd3wVyoZ0tqQp?=
 =?iso-8859-1?Q?FRJ7O4ujn2E1zyUGD54+VWjBYB0UUjJ6zoDwwHI4bHO85d13GGBEcDubfc?=
 =?iso-8859-1?Q?NwYHBpseiK+hrViPsa1ZBv473afmukOITqWsNVM6DojgKDrmAtiuEyPoBQ?=
 =?iso-8859-1?Q?OHZHnrXGqZpWOfXFIaA5xDMS1bl5cdnsxPl8mqYZqmytM3ArfEJ/fNpnpl?=
 =?iso-8859-1?Q?kpyFx/ai0voT9rOa6tSDm39rdQvDJQ0LtFDzF1N3e/b7wvsq2Pybr0u3NZ?=
 =?iso-8859-1?Q?xxpgJkXXw8UvINUyuwtBJC5nMUhpG2tWjfmoGH0PgtN4hLRrWmWgfRF9C5?=
 =?iso-8859-1?Q?c4yEB6b2EhWdFHRyOAQdpXoiK9hKeT5uv5UzjXK+4JEAbzPF/ROE6dg2Dk?=
 =?iso-8859-1?Q?VoxNSP9jRzIWwh5xDNoR5npTxVVffh/UKpUO7ySxxO9d5Q1g0oDhO+FYEh?=
 =?iso-8859-1?Q?uNq4HgILKv4HGpJbDGfLdH26EUP8RTlfSgfxPvSOXaxX/T3NOAMxdsRQBI?=
 =?iso-8859-1?Q?k8CIG55wcfR0dhD2gFdlgHyDBarHmxOKp6H71zEV6TW5EHdl4p8B/QrP0N?=
 =?iso-8859-1?Q?UNBokphK1P32L5m4tueaZidKfHK7QjBoiuuu3PsnOSalRrz5MXr796GocK?=
 =?iso-8859-1?Q?rVyIDhgxDYiX0MlZBLoG3qfu+PXAuh14GZ/4GAm9LfmTalqbpP0+Offy7w?=
 =?iso-8859-1?Q?QbIpU2VVN1zxtKhpBGJojz1C0gE/4XkE8BNJVge4iuyQAHKZYtNqsBbSsQ?=
 =?iso-8859-1?Q?8GX7C32H5aWPkfTgloYX40hpmSJ7/OSZv5hPawWXqfXUnX5s778bhe3EaL?=
 =?iso-8859-1?Q?wGcjtVAJlRolizFeZor7AFcrz80e8yXTxoUdRYIsYSbUoK+rfF4rUnzyrA?=
 =?iso-8859-1?Q?W74o1fHyNkZUq60JNjhLf/J08Ixf0LzybIKr+D5AZijDjN3mBq3lh/v3AU?=
 =?iso-8859-1?Q?SA12hfHK6Ha09KgNrnd3mdImSYiUc7oeYoMKuv8oXy7OKk3HW1/xIT5w4Y?=
 =?iso-8859-1?Q?HK1B8PWhlMgLDMoK7qjwhdpK5B7LJvrDSKtGkR67PVT7g6xOjjaY70SezT?=
 =?iso-8859-1?Q?P2lZIx3d/zjip/D7Es2U8MNUmnDIICzXcNO+FXd1dDvg8x7Kso6WFwD3xu?=
 =?iso-8859-1?Q?wmE+o7tm+E4Q0ERBQ75HWYq811+K/7Fdu2lsXxccKjlRfIc4rZqJGGOemo?=
 =?iso-8859-1?Q?j3hBxDdHLhFAzfMHxAA7VRG4NFDmUkPx0blRDbbTX5v5OB6ltrRAKhKQLW?=
 =?iso-8859-1?Q?R0kHRazzpkmhR7tPGIObZNo+BMtx1CtOuB2JQqwfXTorZBAV9Gt+EGSB4N?=
 =?iso-8859-1?Q?cC96XMiBwtlyCzDXzCjmMLU+mKgUK4Fc/7GpJSRt0APmSzmG69SgaTQr6I?=
 =?iso-8859-1?Q?WCJcyt2kIyaXT7IWMRlbkHM4tIh2nn9edyARqZndeVC57AN5Mqt1VKpk+g?=
 =?iso-8859-1?Q?OIAMT82rL45oSU+tV85CVjU+FlhBgcTSL7DzBYQRXIDRWDWTcT2RzI4uXz?=
 =?iso-8859-1?Q?Cac2v2WLcCwqoLLlcs5s7IDhu3j8cbw13u6WrKRUDFg1t97CSo8AQ/fmHj?=
 =?iso-8859-1?Q?7NyMrWH6YbCguvkJSnS1eMwnKQDBb4g8WR?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C355FBBF27F44A49A1800CE9B90D8F11@namprd12.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 361e3613-a0c6-44d3-7a16-08dbe6de0aef
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 19:55:54.3283
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yLL2j+o5j+hOPs4ZmCG812Pmiax8Q5lH/pv7SHVy8rnnNRAU/wtAdikYW1xatPjXura63UPkyLrmEhesiIXcmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7912
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 11:56:08 -0800 (PST)

On Thu, 2023-11-16 at 20:45 +0100, Danilo Krummrich wrote:
> As I already mentioned for Timur's patch [2], I'd prefer to get a fix
> upstream
> (meaning [1] in this case). Of course, that's probably more up to Timur t=
o
> tell
> if this will work out.

Don't count on it.

Even if I did change [0] to [], I'm not going to be able to add the
"__counted_by(numEntries);" because that's just not something that our buil=
d
system uses.

And even then, I would need to change all [0] to []. =20

You're not going to be able to use RM's header files as-is anyway in the
long term.  If we changed the layout of PACKED_REGISTRY_TABLE, we're not
going to create a PACKED_REGISTRY_TABLE2 and keep both around. =A0We're jus=
t
going to change PACKED_REGISTRY_TABLE and pretend the previous version neve=
r
existed.  You will then have to manually copy the new struct to your header
files and and maintain two versions yourself.