Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp116469rdb; Thu, 16 Nov 2023 13:35:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7V4dhPUNEGIFnfDOJB97CFKMC7L1z79kgPQHPctfh2ZdVq7s9zXlBlu1mHaMoQdG7SdvR X-Received: by 2002:a05:6a20:3ca3:b0:187:eb60:d6ef with SMTP id b35-20020a056a203ca300b00187eb60d6efmr1828626pzj.1.1700170500701; Thu, 16 Nov 2023 13:35:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700170500; cv=none; d=google.com; s=arc-20160816; b=vnKsHHfHljgIEnegxVw92Ag7dNpGVWRpuNrQ+zaGC7UI6PR367/U9SIAMgYp/nbZz8 FIYeeOatglEvhgFU+IF7YZ8R8zlVC+nYSRS3dGsb7latDC8c1MrZuWB4W56sbBwbqWmI FD+CAtJ8wGIwDSAJE+T/Rk164R0VnDs/U1KUtFtRj4lN/Z2DbMCWoQX8CO1AhSMY/I/4 xpv+yLl5ND88d+bk2Z4JLD7SeKUbzRrXJp8Tnbtt03TCYfGzpZhmEgXW9zuvXGf6tNNT kvMuD3Udg1l8PcusNQEXbksYK+p4lcukLlaFQTrRfmQX7AXMvFpauR2ez8QfhcdW2AxW +jcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3p7j5jcBqUIq0ecU8MHF9zvEfrHef9rNKNyPZHyMRyM=; fh=4sx+i3klb2tStYZtkZk7yrywgrGsFO93YtLYmMtXEXc=; b=hECQYuCZGEopUE2fExkGFbEq7mdN44T/sCwN2804wF2VjRCcwPLSOZGECGdTc0B4BP JqKk2BNQLlpwMfDvLHrZW8QJ3oCtJXWpFJxMH7D9tfZoqkR2d1zB7UcOGk2avNzScvxB qnq3niIS2Fklg1B3bgJbCGsZcR7WddjPI1uiHjyqE6cBy0SEUSNMvynecVVUznmnZ0uA YhMHy1QvYUGPe0SOpX8Df9eCzKgTI05p1kHk0Rcs+stXG8gCYRTCiYY10TFKc/fQU4TT gD+sgbvx9pBtzx0vpoDkBqNvJm067DqVGd7mk1wB+MsRxU9HxzHJqTmYlmVQes/7njYs VCAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vz9TUSeg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ls10-20020a17090b350a00b002810ae70420si2929021pjb.121.2023.11.16.13.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 13:35:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vz9TUSeg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 208FA815CDB6; Thu, 16 Nov 2023 13:34:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbjKPVb5 (ORCPT + 99 others); Thu, 16 Nov 2023 16:31:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjKPVb4 (ORCPT ); Thu, 16 Nov 2023 16:31:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F498182 for ; Thu, 16 Nov 2023 13:31:53 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07F05C433C8; Thu, 16 Nov 2023 21:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700170312; bh=HkqW/xbxkGnLq1viptkMdud4OyAiGVdBsU1lpf5TE20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vz9TUSegoI7rqv//v7Cqe/+3+YqU9uRvzmIzQ8nHFagHeFeuhIQJeI2U/j3BH+bDH KzKEsLIy5+ryc5ae8pcTCdeScD7/geUH0qLHvIHcvXpePlpfXMti2xu0vUl7YtNKfC Rdu8rUiDYIMQ14XgCRihB56d86XXeRA//c2UFvekXJWByh2fYBsNWrs50wT7oX9VrH aMnheh2RrHl1cEljKEgrlgf+7OKjhm10Ah0ZmLD1vxdfFRpkA5QZrdTlT3/GxXTEz9 R06QnSlaEjDdH6UR0K8HhkmMJCRCqqeZjC66QNRrsH9Oxvk5en0ydWc+V/juPEIySk dzt5lUokVfXug== Date: Thu, 16 Nov 2023 21:31:42 +0000 From: Conor Dooley To: Krzysztof Kozlowski Cc: marius.cristea@microchip.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: adding support for PAC193X Message-ID: <20231116-uncork-onscreen-d041bbe3bb3f@squawk> References: <20231115134453.6656-1-marius.cristea@microchip.com> <20231115134453.6656-2-marius.cristea@microchip.com> <20231116-channel-variety-cc7c262924ad@squawk> <9d0749ee-08e5-4630-b1b4-27d6aa436b29@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Qy1pUtZjnv7Y8u6G" Content-Disposition: inline In-Reply-To: <9d0749ee-08e5-4630-b1b4-27d6aa436b29@linaro.org> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 13:34:58 -0800 (PST) --Qy1pUtZjnv7Y8u6G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 16, 2023 at 09:00:50PM +0100, Krzysztof Kozlowski wrote: > On 16/11/2023 19:21, Conor Dooley wrote: >=20 > >>> +allOf: > >>> + - if: > >>> + properties: > >>> + compatible: > >>> + contains: > >>> + const: interrupts > >> > >> > >> I don't understand what do you want to say here. I am also 100% sure y= ou > >> did not test it on a real case (maybe example passes but nothing more). > >=20 > > As far as I understand, the same pin on the device is used for both an > > output or an input depending on the configuration. As an input, it is > > the "slow-io" control, and as an output it is an interrupt. > > I think Marius is trying to convey that either this pin can be in > > exclusively one state or another. > >=20 > > _However_ I am not sure that that is really the right thing to do - they > > might well be mutually exclusive modes, but I think the decision can be > > made at runtime, rather than at devicetree creation time. Say for > > example the GPIO controller this is connected to is capable of acting as > > an interrupt controller. Unless I am misunderstanding the runtime > > configurability of this hardware, I think it is possible to actually > > provide a "slow-io-gpios" and an interrupt property & let the operating > > system decide at runtime which mode it wants to work in. > >=20 > > I'm off travelling at the moment Marius, but I should be back in work on > > Monday if you want to have a chat about it & explain a bit more to me? >=20 > Sure, but which compatible contains "interrupts"? Yeah, I did notice that - I figured you understood that that was meant to not be a check on compatibles, but rather on regular old properties & the rationale for the mutual exclusion was what you were missing. --Qy1pUtZjnv7Y8u6G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVaKOgAKCRB4tDGHoIJi 0smuAQCNpa1dlXPZqWLjgqP8b+I5SvrWhzNufcLR2XSaUA5qdQD/WziAESAZdybU 8u9x2hZK43Ao6LkoE6nWOYKlAOu0uw0= =zWfv -----END PGP SIGNATURE----- --Qy1pUtZjnv7Y8u6G--