Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Avadhut Naik <avadhut.naik@amd.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
CC:     "rafael@kernel.org" <rafael@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alexey.kardashevskiy@amd.com" <alexey.kardashevskiy@amd.com>,
        "yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
        "avadnaik@amd.com" <avadnaik@amd.com>
Subject: RE: [PATCH v6 1/4] ACPI: APEI: EINJ: Refactor
 available_error_type_show()
Thread-Topic: [PATCH v6 1/4] ACPI: APEI: EINJ: Refactor
 available_error_type_show()
Thread-Index: AQHaGN74xSOLtQ8hMkyb4EchiBhjfrB9jflg
Date:   Thu, 16 Nov 2023 22:55:44 +0000
Message-ID: <SJ1PR11MB6083540990D4929381FD3358FCB0A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20231116224725.3695952-1-avadhut.naik@amd.com>
 <20231116224725.3695952-2-avadhut.naik@amd.com>
In-Reply-To: <20231116224725.3695952-2-avadhut.naik@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jVs6HJqajTqedBJTwoh+DzbPS9ZzRlcKQKtsLmqEGdUDUIkgSShvb/aEUiEL?=
 =?us-ascii?Q?y6tDYFGQVH5oDthTzIPq4wN7Mo7XSYBapi2hD/pE3JeSav0DT04I7iKTFwUn?=
 =?us-ascii?Q?/wd6GFWH3UNY60jQgAnfgGYUMS5g3bDiBY8eBIZUNPp888U0h6vXVFuj5Fu7?=
 =?us-ascii?Q?Ov7JWK7OVVjYLBVvWcCRu4d1mGHcqrzixc/2AiFERE10NGLrhH4ulqRQmcv1?=
 =?us-ascii?Q?6/kVix0O5jx04edDJx8fxVOlvlgaiNSY+jasCn2cCiXbWe4EQxfAC3Kf6/cu?=
 =?us-ascii?Q?O4gH3XLhjwdDA1rybTVlaCO0N8NxEEu4EUgXUdrxk9Pm3BzkDCoZu/i6FoJ3?=
 =?us-ascii?Q?A9YquegD47s14Ve3y8lQ+bwdbMmR7+1zd4gFcPguF1kM5vso+kk5YW34Q2sn?=
 =?us-ascii?Q?MnWF8iO5Kw40seOVJ1joVsu5bVFzzHiVFoD9n/FiI+Edg/khSj6+MqjKli/D?=
 =?us-ascii?Q?TIDi1L67whgMhabL8S4r11+Ffn+MB/gN5gEr8CCRbs8D5V4DrgpKWhQrLrmE?=
 =?us-ascii?Q?V4hFzTupIHkgW2egtsxpzoeH8aWCYKPUivxew/XEsWFpI+HFNVCKVuyAYdPX?=
 =?us-ascii?Q?HS79DfDfH2Ur5bEES5l3JPHjxG+AKWiMFLgE3fohbyVzl9EPzS3jHv0rl0Jr?=
 =?us-ascii?Q?ZKugUZa1vcb8zlwb0kAE1AekF3Z+7LwEGbrtNtG+zr4kkvUKjOMWLI44h0lF?=
 =?us-ascii?Q?bOvlMpBhwzjU9YPTXkK1N32bWjSIAcvAj+PKThw7CV/0SVSiwlU4ITze5LBB?=
 =?us-ascii?Q?ofIY6fwkutwiVcSjvONzvuOkCaFZCg9m8u0JpYl5qHvZQSbksk5HORSg5IEn?=
 =?us-ascii?Q?Y0lnFfiJ65dkQOIflo0LCn4pL6lnnLfqYi/dreacdR9J/CgtskKeBA+90Q9u?=
 =?us-ascii?Q?85NJBcSQN75sac4c5kankmPFxiqDZZTIg908Nd4jj0BIaIsIXhnAdzQNk2EL?=
 =?us-ascii?Q?P7X0VqTVOyVI4qrHCHxa/sYN3lrBxaW0rsSTLjI7T3WgxRNVdGsoymA+mkBE?=
 =?us-ascii?Q?OAjbSHyL2CsBbDSL9bQm6XUUgoo2J0eCjJjgeNosVDMmqMXraUiMlS5bx/ik?=
 =?us-ascii?Q?xNRP3+3PK6fxI2zX1JZzJD29DwtL91m1z5xvkHKVVxWVA0bSrfzJ5fm73fHZ?=
 =?us-ascii?Q?VZKS5F82jAn68HGWgGddnnepKydPijfL7QdtPw4riUCs4Gx9lwHX8JTq22IE?=
 =?us-ascii?Q?Jb/9UNuRb7W6Zu1Pk3DueVq+r0GC+iuKMPsN1gOC/YhocNFk1dN0zFk4xI+B?=
 =?us-ascii?Q?y2clRMt0dsofXMl4QbnI4/PX+Y7JVNz/YhrJ3QTIay08jK4SP2L6U9y6wjaX?=
 =?us-ascii?Q?gsxyNV5qoh4WUoZnEg+JUf8g8vaZn3eVoEIgdAq4WYOBGqs4FtSgx76VZfYT?=
 =?us-ascii?Q?jhGzFZF4vN48JU9xYkCJWzF4WwyINgDRGgCgaC/5VUoCC+9WE3ChXyr6x96C?=
 =?us-ascii?Q?JlYFbq9iISeDDhVQB3mxo2URtfR9ADqULabu5+tMRFKlEE28a1fcCyqAMyxw?=
 =?us-ascii?Q?vqLmanPRwjtTyney0bb9TFoFeGL4OMIum3MJ5eTggDqGGraPwj2aMda8z33V?=
 =?us-ascii?Q?3pGCWwYWdgfMCssA8vjL5MV1znD1RUZpMbG18Ogu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebfd6992-2c3d-4528-4fdb-08dbe6f72a65
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 22:55:44.5303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QQsD+/3GygOxIsV8qbhIFMAwAlgmjq/84Ox1GxpCA/k9uOYic77Wn2yV6rvqDcXMDMk3lQKliuJ73pFMPUrN2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5361
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 14:55:59 -0800 (PST)

> From: Avadhut Naik <Avadhut.Naik@amd.com>
>
> OSPM can discover the error injection capabilities of the platform by
> executing GET_ERROR_TYPE error injection action.[1] The action returns
> a DWORD representing a bitmap of platform supported error injections.[2]
>
> The available_error_type_show() function determines the bits set within
> this DWORD and provides a verbose output, from einj_error_type_string
> array, through /sys/kernel/debug/apei/einj/available_error_type file.
>
> The function however, assumes one to one correspondence between an error'=
s
> position in the bitmap and its array entry offset. Consequently, some
> errors like Vendor Defined Error Type fail this assumption and will
> incorrectly be shown as not supported, even if their corresponding bit is
> set in the bitmap and they have an entry in the array.
>
> Navigate around the issue by converting einj_error_type_string into an
> array of structures with a predetermined mask for all error types
> corresponding to their bit position in the DWORD returned by GET_ERROR_TY=
PE
> action. The same breaks the aforementioned assumption resulting in all
> supported error types by a platform being outputted through the above
> available_error_type file.
>
> [1] ACPI specification 6.5, Table 18.25
> [2] ACPI specification 6.5, Table 18.30
>
> Suggested-by: Alexey Kardashevskiy <alexey.kardashevskiy@amd.com>
> Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>
> Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>

Reviewed-by: Tony Luck <tony.luck@intel.com>