Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <fb86a4c9-1fcb-41c8-bcda-c7b1e9a949ed@amperemail.onmicrosoft.com>
Date:   Fri, 17 Nov 2023 10:50:56 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: irq: set the correct node for VMAP stack
To:     Catalin Marinas <catalin.marinas@arm.com>,
        Huang Shijie <shijie@os.amperecomputing.com>
Cc:     will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org,
        arnd@arndb.de, mark.rutland@arm.com, broonie@kernel.org,
        keescook@chromium.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        patches@amperecomputing.com
References: <20231114091643.59530-1-shijie@os.amperecomputing.com>
 <ZVZO55IjQSbzWnfG@arm.com>
From:   Shijie Huang <shijie@amperemail.onmicrosoft.com>
In-Reply-To: <ZVZO55IjQSbzWnfG@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3dyMjMwZmVOZ09qUG5HRHNIQm52WlZGYitYVFl5Nm05SGlvMGU4TGl3MTZK?=
 =?utf-8?B?MU5oV0VjODNOa2tJQmZOMTErZ3Q4R2Q1UzJ1WWpScWpJVyt0WVVkeXlYYVZM?=
 =?utf-8?B?R1paaXhWQzRrd0hkcDRnTlduNm9yWGppaHRFU1N3ay9zM2swS1h0Y1REMHBa?=
 =?utf-8?B?elZWUmJrVVdhNmpGQllWZ09DeVM5QmJrQ0syUEhrRVh0Q2xnc3ZvVXB2ZVUw?=
 =?utf-8?B?bTNmaTM0WVhpTmF6Z2NOQnlhbGI5c085NkFpQzVQRFh4NHlrS0UwR3h5ZDFS?=
 =?utf-8?B?Z3BGaWpWbi9YcHJyaDJUSEpUUUJ0b1ZnRGEvNzNGM3ZCa2hzOEd3Mm90SHFk?=
 =?utf-8?B?RmhVUWg2QnM5ZzdDanVDeUtBQkpZZGI2b2pISG82amRWZ0hGQWthamgrVDVL?=
 =?utf-8?B?UHlJdDVvYVVHcjNoVnNxQTEwY0hiU3VTT0plOGpZRWdVRVdDZVZVRVIxT2c3?=
 =?utf-8?B?eWQxcDFHMDJRcksxaDNuY0VHb0xzTHBDL1JiZmx0M2FhNk15NThZSlIzcEFF?=
 =?utf-8?B?NGN1RTJZbW1FUFl2UytFMlBFRDBpWDRZWlF0YUZBR0dXZWFLRG5DVFF4N0Jv?=
 =?utf-8?B?MFgwdVQ5ZFlOVVBJbXd4eEh2RmRUSS9DeTFDZmJseGQ1OWZUbnAyRVloTGdD?=
 =?utf-8?B?SDBwelFLTDQvYmhPRlFGR1VxTnJsOHJ1UzM1TStmT1NIYnpOU3lZWmVwamZ3?=
 =?utf-8?B?MEhjMU1jK0NoTXZHUkFTUmNWdU16ODMrWVF6YjdPM3BGcFNkcS9HVVZuVUd2?=
 =?utf-8?B?ajRxR2hlL0oyMlNUcEthWTlUbm1YNUhKZGtnSFI5UVZhTFJMVkkvVG1mVHc5?=
 =?utf-8?B?UEU4NXJrZzBENzh1Z2dBckJ5cEJpdGQwSnJYMHdnS3F2VWdPM1lJaUtMYWNI?=
 =?utf-8?B?MDdIUTNtb0xOcDQyT0gvUm5XQmFuMFl0Vk1OaU0wamZVM3VYZWViVllYRGJi?=
 =?utf-8?B?K1lodVgyTGp0WmRtZUxPbm1GeGEyeFBPS1l2YldIVllpRXVMSmJ6SU55Z0Mr?=
 =?utf-8?B?MmJqZzRNTXZ1bzNWMDNnOHc5cFBGaitLMUlTSjhRUGhSQ2pta3RVWUFWc1BX?=
 =?utf-8?B?UFhrU2VtaHY1V1k0bHpQZDVBRjdRYXN1UDhQenc3MXlEZ1NpaXdYRW01Qlgx?=
 =?utf-8?B?UzhTcWttTVN6dHdzY2s3Qk5pdmN5YmNJdy9wbWt1eVFDRVVSVW5pRURxbDA0?=
 =?utf-8?B?SmhWMzhFL3h6V2lCNmVCVGdsczl6YXdWMnRnVlRLR3Z5ckVlV1NLck1TNmJG?=
 =?utf-8?B?T3VmSlVQUTYwZDROVnJGZjJNNjNPdllPelBKSkF3b3ZqY2JSTm1wQ1YvcXBs?=
 =?utf-8?B?MEtCMmU5UEcvL0hqdyttb1Zic2hkK2gxOThEaVhrbkhwZlp3ajBINUR6cjh1?=
 =?utf-8?B?YXEzOFF2emRPMTBEUGpWc1NVK29QS1RWeGR6RURML3JOV2JXQlRRb0lTaUhQ?=
 =?utf-8?B?QzU3NmlndVRjK3FvV2hkYWgrbUhmdFR6WGpxbTRKTG5TTm9kdElnN0hvd2hl?=
 =?utf-8?B?dHNCYW84TjZEQ3IzcFh1TWs4VVJkMmFUVnR2STU4NkxyNEY3NGRkMmIyUGRr?=
 =?utf-8?B?d2hSVC9sV2ZBMnppcXNOTUtVMFdGZUY2MFJUbElLTk41UEI4N0F1dHhEVmJQ?=
 =?utf-8?B?SGFHR3FQTDB2cnh3T2dvQVNxMUxxWXlVc2pOWjJqVHhxcVN6aDRoSTVyRE9z?=
 =?utf-8?B?ZXVPUm9WZGpRS0FBNlh6aGE4aGdJVldJaEpIMzZDcVJBeWxwcHRmRUdseEZK?=
 =?utf-8?B?WUhqWnFSdjVCRjZzQzJMNW94QzRBSUdkdWJjSnVrcnprZyszYXQxZVZGYVpX?=
 =?utf-8?B?d3FybWQrSlEzcGIxTVpjbTNSSnhsV1VxdWlZTEpFam1YeFREdk5wUnI4cURn?=
 =?utf-8?B?VnhvNDlva3grdXBhVHRvNjZDS0xzM1BNMDRCQXFJbWlQRUNuSFhoRnRBYjBi?=
 =?utf-8?B?bENrRC9ZWDEwWlh4REhCUXkrYlFPcXBQcFBRTUZGR0JqY1JMeW56dVNyVmtO?=
 =?utf-8?B?VHhmRitCb29SaGd2Z0czNHlaODAyWUxOTFQvOFM4VURORWozQzAzZnNhUm1a?=
 =?utf-8?B?eDVkb2FiTGJoYXZQRzlSTXh1RXJiUGZQaXo0M2RFeFZ0Q3BmOVhXZXdHNWZO?=
 =?utf-8?B?ZWFBL2txZ1d3SnFONnhSbVlnTnU3SDBkYmNnZGpORHRZTUZVSmlJb3ZRNDIz?=
 =?utf-8?B?cFE9PQ==?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35a41879-a5a3-49d6-f200-08dbe7180e1c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 02:51:10.8307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ATZmuhS3I7+1mbnog8TqKu23jJDZ6xy46sG7u3qRqgNjpJ1485fCofl/iKx7GFmUe7Uz83ODBGiFVj0wRAdaEQ1ebQ+sdFdqA1tMh95Hx1RJcBRwFV9MzQd1XPGDkN2i
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7931
X-Spam-Status: No, score=-0.3 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 16 Nov 2023 18:51:31 -0800 (PST)

Hi Catalin,

在 2023/11/17 1:18, Catalin Marinas 写道:
> On Tue, Nov 14, 2023 at 05:16:43PM +0800, Huang Shijie wrote:
>> diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c
>> index 6ad5c6ef5329..e62d3cb3f74c 100644
>> --- a/arch/arm64/kernel/irq.c
>> +++ b/arch/arm64/kernel/irq.c
>> @@ -57,7 +57,7 @@ static void init_irq_stacks(void)
>>   	unsigned long *p;
>>   
>>   	for_each_possible_cpu(cpu) {
>> -		p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu));
>> +		p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, early_cpu_to_node(cpu));
>>   		per_cpu(irq_stack_ptr, cpu) = p;
>>   	}
>>   }
> This looks alright to me, I don't have a better suggestion. The generic
> code already has the cpu_to_node_map[] array populated by
> early_map_cpu_to_node(), so let's reuse it.
>
>> diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c
>> index eaa31e567d1e..90519d981471 100644
>> --- a/drivers/base/arch_numa.c
>> +++ b/drivers/base/arch_numa.c
>> @@ -144,7 +144,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid)
>>   unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;
>>   EXPORT_SYMBOL(__per_cpu_offset);
>>   
>> -static int __init early_cpu_to_node(int cpu)
>> +int early_cpu_to_node(int cpu)
>>   {
>>   	return cpu_to_node_map[cpu];
>>   }
>> diff --git a/include/asm-generic/numa.h b/include/asm-generic/numa.h
>> index 1a3ad6d29833..fc8a9bd6a444 100644
>> --- a/include/asm-generic/numa.h
>> +++ b/include/asm-generic/numa.h
>> @@ -38,6 +38,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid);
>>   void numa_store_cpu_info(unsigned int cpu);
>>   void numa_add_cpu(unsigned int cpu);
>>   void numa_remove_cpu(unsigned int cpu);
>> +int early_cpu_to_node(int cpu);
> Here I'd move this just below early_map_cpu_to_node() and, for
> completeness, also add the dummy static inline for the !NUMA case.

Thanks a lot.  It seems there is no need for me to send the V2 for this.


Thanks

Huang Shijie