Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <d01ea2be-176c-aa0e-38d6-f721a1a29edb@quicinc.com>
Date:   Fri, 17 Nov 2023 09:59:44 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SC8380XP SoC
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <djakov@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
CC:     <agross@kernel.org>, <conor+dt@kernel.org>,
        <quic_rjendra@quicinc.com>, <abel.vesa@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_tsoni@quicinc.com>, <neil.armstrong@linaro.org>
References: <20231025134049.9734-1-quic_sibis@quicinc.com>
 <20231025134049.9734-2-quic_sibis@quicinc.com>
 <67345a93-2c29-4b66-95dc-34917affd3b1@linaro.org>
From:   Sibi Sankar <quic_sibis@quicinc.com>
In-Reply-To: <67345a93-2c29-4b66-95dc-34917affd3b1@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey Krzysztof,


On 10/25/23 19:20, Krzysztof Kozlowski wrote:
> On 25/10/2023 15:40, Sibi Sankar wrote:
>> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>>
>> The Qualcomm SC8380XP SoC has several bus fabrics that could be controlled
>> and tuned dynamically according to the bandwidth demand.
> 
> 
> ...
> 
>> +  reg:
>> +    maxItems: 1
>> +
>> +allOf:
>> +  - $ref: qcom,rpmh-common.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - qcom,sc8380xp-clk-virt
>> +              - qcom,sc8380xp-mc-virt
>> +    then:
>> +      properties:
>> +        reg: false
>> +    else:
>> +      required:
>> +        - reg
>> +
>> +required:
>> +  - compatible
> 
> By convention we put required: block before allOf: and that's what
> existing recent code has (qcom,sc8280xp-rpmh.yaml or
> qcom,sc7280-rpmh.yaml' for example). Please use recent files as a
> template for new bindings, so there will not be a need to fix the same
> things again.
> 
> With fixes like in qcom,sc7280-rpmh.yaml:

Thanks will fix ^^

-Sibi

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
>> +
>> +unevaluatedProperties: false
> Best regards,
> Krzysztof
>