Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <b8f6d4be-8aeb-4372-927e-9820f0dd3323@intel.com>
Date:   Fri, 17 Nov 2023 14:30:36 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 7/7] vfio: Add vfio_register_pasid_iommu_dev()
Content-Language: en-US
To:     "Cao, Yahui" <yahui.cao@intel.com>, <joro@8bytes.org>,
        <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>
CC:     <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <joao.m.martins@oracle.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-8-yi.l.liu@intel.com>
 <99115148-d0e3-4920-aed6-669ae45aa2fe@intel.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <99115148-d0e3-4920-aed6-669ae45aa2fe@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UncvUjZURkkyaHdNa0xKOStOTUJ2L0NKUnRzNkwxbDl0a3psaW9YM1BZYkRn?=
 =?utf-8?B?VCs2RUJhZHBaWmpmUjZ4azBUMkx6YWFMNktBclo2VmQ5RUVnYjlIOEF3TGha?=
 =?utf-8?B?ZWUyRkovZkk5c3ZqZm5CbEVaYU1HRDFmQlFsM2g0Z1RXTzZOVUpocEc5cThT?=
 =?utf-8?B?eDI5SEdPRlZ2aFVJNlhCMFUwS2hwSjEyNXpIZlBTSjY5dldBWEVUdEdTaWMz?=
 =?utf-8?B?ekFsTlF6elBlM2UvZGVQTThBclpZdFArWHVmczUyQjJ2blliY3hrdU5OWjRV?=
 =?utf-8?B?M3ZWZ2hwUjhCN01BVjAyanRDQmpISFVnOGRXYnRWU1RIV1o3QUlSNVh2NGd6?=
 =?utf-8?B?cDgveFZ6K2d3RENoaWw2VUlObjdrQjhlYUdXTFhWbDRIbURmNm9hNHVjY2dX?=
 =?utf-8?B?SDgvZXZwVWVYOWE5b3ZFSHUrQUxKT2hZNngvcXJDQUVsNzNnQTkrTG55b29r?=
 =?utf-8?B?bVdWeVJkeGU1QkdHYjd1TDNpdGJIYkpmeXRKSnZQSUttNHREcHlhS243MWxO?=
 =?utf-8?B?dVM4Q1J5S1U0UWw4SmZPa0dMZXYzSW5qS29kVEd5WHliOENicFZQK3R0eGg4?=
 =?utf-8?B?eHdaamhNZkkrMkFVMVpWTVRjTGtrNTg1blRPc3Y1YUhJQmZPK3J6S21CN1RG?=
 =?utf-8?B?Z0toQ1Npb1hLV1ZkbmNDUERHbmtWeXVHTytBbWFsZGVZeERpNC9UeEFEY0ts?=
 =?utf-8?B?UWdNd3ZaN01uWkJMd25WQy9ZYnRvMmJOMm9SOU5PdUZ1bk1qTlhRbE01amph?=
 =?utf-8?B?K3RkOXVncVBGWWVoUzdpSGFNZTVNSDZQWTc4QktRV0dXc203S1o4cjJHUEls?=
 =?utf-8?B?UVF6ZFY3YUc5czlSS0xKWGVGZEo0cFo1a0Fac3BkRUt1c2RqUE5JV1VwRCtQ?=
 =?utf-8?B?c3E0S2V4cEV6V1JKbVlBSldZRFhvK01HVThwbW9IUHBubk5lby9DaDM3dVda?=
 =?utf-8?B?THJRUjZTZytFTkZ6VFEzM1p3ZE1EUVBwRjdUb3RUcWQzY3AxUUFPaG0wUXhE?=
 =?utf-8?B?L2tVMGVaN2txNXM4SWl6Tm5WYTNDQllJSEpIQ0NwY0dhWVgyZktzeHZGblYx?=
 =?utf-8?B?TGFGNU1aam1TTFpMa1FrRU15aUdLNDllSFN3UWF4Qmk3TmRoL2c5d0t4MkhP?=
 =?utf-8?B?RnF6cFZ5NmtoMVNLd2RJZmE2UDZDQmJZN0ZYYXQ0UVNTcVI5aDRudGhLN2Ry?=
 =?utf-8?B?dU93UituZWFudmZqMEI3bXlmeUQrQmh2NElzQ0luTWNJb2c5dXVHOHBtSElK?=
 =?utf-8?B?KzY3WWZJbEJHMTNFNUUzaTRFUGcyU1VHYmN3Si9aY2dRcHJLZGNoYlN5dXZ3?=
 =?utf-8?B?MlZkd2l6d3k2ZEE1WXdJeVJEUm9MSHg1K2QxeEhUYmViZ25kVlBuV0lNQlFC?=
 =?utf-8?B?UXY2SkhrcHZYQS8zNjR5NmZoaFdzbmhMTHlzZUxpOTJ3YmJYWDVWQnN2R29z?=
 =?utf-8?B?ajV1b2t4M1MzNDZQNFlLZEx4SzF3WTlXMi9UeThJcHNScDlwTEN1RktwYjVR?=
 =?utf-8?B?S1hYc2FzTE9rMlN3WU9pVVNYMU1Ea2NBelhIL2x3RnFuWHFFV0plL2lla2c3?=
 =?utf-8?B?QlNiM1I4Zlc3Tk5NQktkQmxhRkVHeGlpK252R0k1LzBMUGY4WDh4Yi9JTkZS?=
 =?utf-8?B?d2x3YnhPcWMrbXdRSjNTWStOM1ArS05wOEJNZzlDTk9zcnBoK3BPc1NkYjJS?=
 =?utf-8?B?dm55MXJaN1dHMU1iYVpydWVDMDVjbHJUNXVEREpBdjdXNHZDMUI5c0tNU1ZG?=
 =?utf-8?B?TzFhbVdyeTdJVGovKzRkdlQ0OUVrWFJsUEsxODlQdVc3ZEVHOFNaOUJ6a2t3?=
 =?utf-8?B?KzQ1RkVUTWZ6NDl3dWVaZm5FelBJbVFBcDYvYzBnUUJmL29YckI1Mk1CbUxl?=
 =?utf-8?B?ME1aSjB2dEh3R1B0b2dHWDh0VEdnN0txanRvMUNMM290Rng4Q0hYelJ4Y25w?=
 =?utf-8?B?cDJMcVpWUHVFb2hselNvQjIrVWg1S0N2YjhIK2cwVmliWndKSmZ6RVFwTWRm?=
 =?utf-8?B?dFEyUEdiTDBnL2RXdG1mT2l6T3d6K29sVWFPMlB6dXlIY0grM1NLSS9nSG1S?=
 =?utf-8?B?dXM5dldPNXE0Z09saUlieFpZMHJHUk5hSTd1SmoxMWFaMWI0ckc1cWs2cVVT?=
 =?utf-8?Q?09wyVunH48p7P9MblFdtQMoWv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11372f20-e679-4914-4cf7-08dbe7365c69
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 06:28:07.3463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jsny34yyW/1x+BKnvMpG5jGxnHz38lB5NitbC/DNKDAMXXG2QiaT3vnPSCN/CP71PFfU4wi8H0fuHk5/ozHPww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7137
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 22:28:24 -0800 (PST)

On 2023/11/16 13:12, Cao, Yahui wrote:
> 
> On 10/9/2023 4:51 PM, Yi Liu wrote:
>> From: Kevin Tian<kevin.tian@intel.com>
>>
>> This adds vfio_register_pasid_iommu_dev() for device driver to register
>> virtual devices which are isolated per PASID in physical IOMMU. The major
>> usage is for the SIOV devices which allows device driver to tag the DMAs
>> out of virtual devices within it with different PASIDs.
>>
>> For a given vfio device, VFIO core creates both group user interface and
>> device user interface (device cdev) if configured. However, for the virtual
>> devices backed by PASID of the device, VFIO core shall only create device
>> user interface as there is no plan to support such devices in the legacy
>> vfio_iommu drivers which is a must if creating group user interface for
>> such virtual devices. This introduces a VFIO_PASID_IOMMU group type for
>> the device driver to register PASID virtual devices, and provides a wrapper
>> API for it. In particular no iommu group (neither fake group or real group)
>> exists per PASID, hence no group interface for this type.
>>
>> Signed-off-by: Kevin Tian<kevin.tian@intel.com>
>> Signed-off-by: Yi Liu<yi.l.liu@intel.com>
>> ---
>>   drivers/vfio/group.c     | 18 ++++++++++++++++++
>>   drivers/vfio/vfio.h      |  8 ++++++++
>>   drivers/vfio/vfio_main.c | 10 ++++++++++
>>   include/linux/vfio.h     |  1 +
>>   4 files changed, 37 insertions(+)
>>
>> ...
>> ...
>> +/*
>> + * Register a virtual device with IOMMU pasid protection. The user of
>> + * this device can trigger DMA as long as all of its outgoing DMAs are
>> + * always tagged with a pasid.
>> + */
>> +int vfio_register_pasid_iommu_dev(struct vfio_device *device)
>> +{
>> +    return __vfio_register_dev(device, VFIO_PASID_IOMMU);
>> +}
>> +
> 
> 
> Missing symbol export here.
> 
fixed.

-- 
Regards,
Yi Liu