Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <b05ee1ed-b8ee-4683-81e7-1cbf780432c3@intel.com>
Date:   Fri, 17 Nov 2023 14:31:41 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 7/7] vfio: Add vfio_register_pasid_iommu_dev()
Content-Language: en-US
To:     "Cao, Yahui" <yahui.cao@intel.com>, <joro@8bytes.org>,
        <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>
CC:     <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <joao.m.martins@oracle.com>,
        "Chittim, Madhu" <madhu.chittim@intel.com>,
        <jacob.e.keller@intel.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-8-yi.l.liu@intel.com>
 <39222f73-35f8-4d05-8772-c6df4c8298ca@intel.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <39222f73-35f8-4d05-8772-c6df4c8298ca@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dENVVFJWTTFkeXd5M3JCVnhHU2VlZVZIQldWbEtCeUMxYzVDZkpBd3l1WHZ0?=
 =?utf-8?B?cDJVUWVXTjh5K0g2Zk15V0FZR1NSN2NiSGREWHlaQVZMaFFIR1RtblVwblRk?=
 =?utf-8?B?djBNMDFuaHpwdXpUdmcxUStCVmdsWjlPQTdac01XSGNtRTVLUHl0M0lXZk5L?=
 =?utf-8?B?YjRFVG8zOHg0a04rUndyQWgwZjUrZXZPNXdDM2lUZ1dWVXh0SXhranFKRmQ3?=
 =?utf-8?B?YUxqMC8xa1p2Mmd5T1FWWlQ4VncxUkQ1d09PUmxPUm5paWRscVg5MDV5VWZt?=
 =?utf-8?B?VExSM21CbmVGaDg4ZHc1Uk9VZWVWaGJSRGg5WFpNSmJMaURjblhrZGJFUzh4?=
 =?utf-8?B?Z0RYOW9xUUFDZStJNmFtSVJHWktFR2R6RnBGNXdzeUh6TlA0dTVvTytVaUFy?=
 =?utf-8?B?bjcreDVIN25RRHZhUVV1aEJOeVhnVjkyWDJWM3Y3dnNHL0hmUmJHOEN1ck1a?=
 =?utf-8?B?RmpuYmoxeDdJZDZxb1V2RXV5K2krMTVzNytUTGNoU1ZoZlJuNWVSdHVIcXYx?=
 =?utf-8?B?cnA5Y0dRKzF6RnpsUy8yaGRld0FXMWhpNUEzb3JIUUxxdzJITVNUWENoem9L?=
 =?utf-8?B?bUVYLzFnc2dvTHBueFJzZFV0d2NoTDB0MGMzeHFtQklORVFVYVNlalp5RUZx?=
 =?utf-8?B?YlVFbkRzYTVBa1BCNVJaN2dBZEVGTDh5UWRteWxjeURWZXBzU0VxUXZVMFph?=
 =?utf-8?B?VXRZc1J0dk0yWWVGcERlRDIvWnV5bFkxbVk2K1VXS2ZDYldjTVdpWjVVRFJu?=
 =?utf-8?B?RjRlR0pkZ2Z2bS9nbm9LYkF4WHJHdE5NMHNzbS9nN3pHN2EzUHIzRHN0dzZH?=
 =?utf-8?B?T0VjVVpkOVBKWnVrY3Rpd0FyMUdZZnpMMlIwNkV0SVd1MEJlWDRMNFNlTlFi?=
 =?utf-8?B?U1p1MmY4VFhtdzdwQ0k4TE9tbWNtTWs0ZUNWZVphekZyMHQvRXp5UklLclYx?=
 =?utf-8?B?UHRTejRucXNnODh5SHhaN3ZOMkxhbmdiWldSNUF1blB6ZXRrbGgzbWJBOFVK?=
 =?utf-8?B?QVJ0YllTRDN6V1hFQTBjbVFKMlZHNGphYS9CNWpia2lJbU1QRjVkcUxRRFFH?=
 =?utf-8?B?cVZwZnFmam1EYXkwQUJZdDhDeEEyaUU2TGhVb1ROWERqYnVUZ0tIbyt1NU1T?=
 =?utf-8?B?am1TcDBJL1JzMFdjdTlSeDhzaEg5dWNBYlZTSGU0RW1JU0ZLc3VCNm1EdUZo?=
 =?utf-8?B?ZlV0TkRaUXVmOExpSHRKc0pRTEtGNGlCd2w4WmVUbWh0azhBa3prNjlxbDJa?=
 =?utf-8?B?K0RxQW9ZNDJ2OXV0SDRjZFRUQXp2M2FzV1R0MC8vRFlMSlpzaFFHOTVEOXU0?=
 =?utf-8?B?cTJrcSs4YzJkSkxIWHlTR3kzWnN1TXh3VCtiQllSR2k0RTdFbFA4QUd5Wlp6?=
 =?utf-8?B?NUV3K0lxRDBrcEdOTGQybUJBZ1lkeXd1ZHovRXV4VXVZTmU5bmt5NUVCV0lN?=
 =?utf-8?B?MnE5THZqbkMrbVoyMXYwSTczekRoQ1dZU2ZFWWpwcUdWSHY3dXFPSmxkZk5U?=
 =?utf-8?B?djBBUTNRaGlKMlYydVNxYm9qTXh0MmpYZ2E1TjcvZzEzNkVpb21Tdktib241?=
 =?utf-8?B?T1Z4bWVJalhFU1E5MlpoaThqdHk4bzZKR3FvNklZdkJhVVNTM3QyczlNZTFn?=
 =?utf-8?B?MXFaODNub1FPSnVrU3h2L1lLRzBJZFIrcS85V2U4Y3RSNkkyTUNEdEZRS1NV?=
 =?utf-8?B?Q0JmSDF6OXJwOFdrNlp5UkgrVWFJdXZ1em9Zc2FHMmI0MFRJYWJHK0JIUWZT?=
 =?utf-8?B?TnFDb1JTdjBELzFHcXcxc2l2TkFEd3oxa3VKeUxadVRlcGtwUWg4Y0Z3ajdn?=
 =?utf-8?B?bWsrNCt4WmpYTytvb25SVEZTM1lPTWNqMG5OZDl1aXM2azZiekkra1RLU1Ju?=
 =?utf-8?B?NEdhU1JqMlgxYUNZNWQxNnBtVTNmQVh0RWFmK2hyYVpNanlScHBXd0RidXB3?=
 =?utf-8?B?N0svWXdWMUsraUtXbVpONDk2QlRnTUdVdmsyZVREeTA1ajl2aXcxM2NqN3VZ?=
 =?utf-8?B?OFV1S1U2eE1ENDZ2T0MyVUU4b0YrT2VEalhVNVZMSmNXcWxvclBYTFNDRTQ5?=
 =?utf-8?B?dTA0OUx5OFNEenU0aVBJdXNIblYzckNxNnBKUFlMNHVTL3hLbGR2RkJ1T0xz?=
 =?utf-8?Q?nmDkmJeurgasuXAYf8EutZVKJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c22589de-51aa-47d3-76ce-08dbe736815b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 06:29:09.1309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WdPAXOeyhcdvYMhoUajW3fomBPbFEulaRPpw3DIpjVkhvwto7L+MGNOrxTmtGzbYp449Wkw3aERDZn9Jb/791w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7137
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 22:29:19 -0800 (PST)

On 2023/11/16 13:35, Cao, Yahui wrote:
> 
> On 10/9/2023 4:51 PM, Yi Liu wrote:
>> From: Kevin Tian <kevin.tian@intel.com>
>>
>> This adds vfio_register_pasid_iommu_dev() for device driver to register
>> virtual devices which are isolated per PASID in physical IOMMU. The major
>> usage is for the SIOV devices which allows device driver to tag the DMAs
>> out of virtual devices within it with different PASIDs.
>>
>> For a given vfio device, VFIO core creates both group user interface and
>> device user interface (device cdev) if configured. However, for the virtual
>> devices backed by PASID of the device, VFIO core shall only create device
>> user interface as there is no plan to support such devices in the legacy
>> vfio_iommu drivers which is a must if creating group user interface for
>> such virtual devices. This introduces a VFIO_PASID_IOMMU group type for
>> the device driver to register PASID virtual devices, and provides a wrapper
>> API for it. In particular no iommu group (neither fake group or real group)
>> exists per PASID, hence no group interface for this type.
>>
>> Signed-off-by: Kevin Tian <kevin.tian@intel.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>
>> +/*
>> + * Register a virtual device with IOMMU pasid protection. The user of
>> + * this device can trigger DMA as long as all of its outgoing DMAs are
>> + * always tagged with a pasid.
>> + */
>> +int vfio_register_pasid_iommu_dev(struct vfio_device *device)
>> +{
>> +    return __vfio_register_dev(device, VFIO_PASID_IOMMU);
>> +}
>> +
> 
> If CONFIG_VFIO_GROUP kconfig is selected, then there will be access to 
> vdev->group shown as below
> ->__vfio_register_dev()
>         ->vfio_device_add()
>              ->vfio_device_is_noiommu() { return 
> IS_ENABLED(CONFIG_VFIO_NOIOMMU) && vdev->group->type == VFIO_NO_IOMMU}
> 
> For SIOV virtual devices, vfio group is not created and vfio cdev is used. 
> Thus vdev->group is NULL and there is NULL pointer access here.
> 

yes. needs to be like below:

return IS_ENABLED(CONFIG_VFIO_NOIOMMU) && vdev->group && vdev->group->type 
== VFIO_NO_IOMMU;

-- 
Regards,
Yi Liu