Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp340586rdb; Thu, 16 Nov 2023 23:34:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IErSWJnSwxAXBovQfxzCFOn7JXZFfg1zXuvNczTqx+YqUMRoVgV3h9ZMIwZCxQ2wV10673o X-Received: by 2002:a05:6e02:18cc:b0:359:3920:f943 with SMTP id s12-20020a056e0218cc00b003593920f943mr26544545ilu.27.1700206456218; Thu, 16 Nov 2023 23:34:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700206456; cv=none; d=google.com; s=arc-20160816; b=WlAcEngcYykmMMPoucKLNfIlQLEAxn8L8NZ/ACtOd7Rc4tKoEGQoM6fQ4F7OxcSnQx FCRMJH5lU+ypxLaFNzLDX6Sw7LlAg98Ey+h6kEn/taxGHnw+EsQkJIaxIxdwdYw8nReL EvKw1um6etN87V2i4NdLSU/WuAcl59DtDusZJXE+6J+fsA5cle85CJvXuEN7C1Nclxfx DgIB/wMyLHLILNL+ru7nHfcQ1cYkGc0Q4ANhuzeDQbSL+MEFBDR9JTDtOhioNzTCZsTV vq5dWuw91VU/Uki+uP/z7maFJoil2qSOGYcxJC4i27f5fRlh7Pkq7+8qHZg+0L81HvTW xHRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=at1ne/rWq7oflyNTr5NsoIEOTljtkrgIcuWxm4pqXDc=; fh=hsHVI/ubjJ1TIM0PE8efw8vRWek38EPSGINYsHAUZ9M=; b=o7h8JqK8bhGbWf7ClKXkW3m+lq6piikcLZmK4rmfQkdrYdL0X7zT8hoVAc2IPnAobP tJVhLf6xUruIo8ASS8OJ6td9Lxqiv0AzsjITYXp/YmGiPfJlIcK0nMOODmhXvmQbGlD6 R4yJZJlzfJOzH91De6RfqTqOpACNz1kh4sl7mQ4ieGKloHfhlps98bvJ3j2hegA2l5x7 8eECqdszf8AUQ5fUxN9TvhpzZQM8n0wJ7K1J/JRDzjdDV4Dcs/ATkev71nZqo1u2OGAZ mpbLcLhrrmYf6lWTRASFl5q3dhNaHh9xVFMVBblcXbUTsFSPEk2bBJHIuyuy/QHx2COq SS9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rock-chips.com header.s=default header.b=Nu292DN2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q22-20020a63e216000000b005c16f26b1b4si1284156pgh.440.2023.11.16.23.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 23:34:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@rock-chips.com header.s=default header.b=Nu292DN2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8F11281B4ADB; Thu, 16 Nov 2023 23:34:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbjKQHdo (ORCPT + 99 others); Fri, 17 Nov 2023 02:33:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbjKQHdm (ORCPT ); Fri, 17 Nov 2023 02:33:42 -0500 X-Greylist: delayed 885 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 16 Nov 2023 23:33:37 PST Received: from mail-m17244.xmail.ntesmail.com (mail-m17244.xmail.ntesmail.com [45.195.17.244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B026A109 for ; Thu, 16 Nov 2023 23:33:37 -0800 (PST) DKIM-Signature: a=rsa-sha256; b=Nu292DN2E6gfuHIj233Rh8Mdr+z5CJlMWHO8NWBfbI4ao9MCcWWM5VLf2BnX2BVH9c92Fx09CxiX4W8gRKqXwKDxiAREUGNt1I7x/DpyeAWDV6rYxLJjP9k4eRtbglzyPG0EIa1YuA5UhPKtrAj8LITcaYyVn1FdDw0padxAVRs=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=at1ne/rWq7oflyNTr5NsoIEOTljtkrgIcuWxm4pqXDc=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m12779.qiye.163.com (Hmail) with ESMTPA id 6C5477804C6; Fri, 17 Nov 2023 15:06:35 +0800 (CST) Message-ID: <3e011d52-017e-4360-86b4-781535ef61ad@rock-chips.com> Date: Fri, 17 Nov 2023 15:06:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588 Content-Language: en-US To: Sebastian Reichel Cc: Sascha Hauer , Andy Yan , heiko@sntech.de, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, kever.yang@rock-chips.com, chris.obbard@collabora.com References: <20231114112534.1770731-1-andyshrk@163.com> <20231114112855.1771372-1-andyshrk@163.com> <20231115090823.GY3359458@pengutronix.de> <8f2ebc81-51c5-44d5-b27b-633a6cc85d0d@rock-chips.com> <20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org> From: Andy Yan In-Reply-To: <20231116134757.zu7axb6cvriqjm6y@mercury.elektranox.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGR5DGFYZTU8fSEIfSk5LHh1VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a8bdc1a5771b24fkuuu6c5477804c6 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NxA6Dgw6KDw5MDhKPzJKLA0o DyIwFCFVSlVKTEtLSUtPTEJNSU5PVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBSE5ISzcG X-Spam-Status: No, score=0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 23:34:13 -0800 (PST) Hi Sebastian: On 11/16/23 21:47, Sebastian Reichel wrote: > Hi, > > On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: >>>> vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf"); >>> This already lacks an error check, shame on me... >>> >>>> + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf"); >>>> + vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf"); >>>> + vop2->sys_pmu = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,pmu"); >>> ... but please don't duplicate that. >> It a little difficult to find a proper way to do the check, as not every soc need all these phandles. >> >> Do i need check it per soc? > I suggest adding a u32 flags to struct vop2_data and then have > something like this: > > if (vop2_data->flags & VOP2_HAS_VOP_GRF) { > vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vop-grf"); > if (IS_ERR(vop2->vop_grf)) > return dev_err_probe(dev, PTR_ERR(vop2->vop_grf) "cannot get vop-grf"); > } > > if (vop2_data->flags & VOP2_HAS_VO1_GRF) { > vop2->vo1_grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,vo1-grf"); > if (IS_ERR(vop2->vo1_grf)) > return dev_err_probe(dev, PTR_ERR(vop2->vo1_grf) "cannot get vo1-grf"); > } > > ... I can do it like this if Sascha is also happy with it. > > Greetings, > > -- Sebastian