Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Javier Martinez Canillas <javierm@redhat.com>
To:     Mostafa Weshahy <mweshahy@yahoo.com>,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
        noralf@tronnes.org, mweshahy@yahoo.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        daniel@zonque.org
Subject: Re: [PATCH] drm/ili9163: Add "1.8-128160EF" to spi_device_id table
In-Reply-To: <20231116185124.13887-1-mweshahy@yahoo.com>
References: <20231116185124.13887-1-mweshahy.ref@yahoo.com>
 <20231116185124.13887-1-mweshahy@yahoo.com>
Date:   Fri, 17 Nov 2023 09:03:51 +0100
Message-ID: <87fs1424d4.fsf@minerva.mail-host-address-is-not-set>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Mostafa Weshahy <mweshahy@yahoo.com> writes:

Hello Mostafa,

> drm/ili9163: Add "1.8-128160EF" to spi_device_id table
>
> Currently enabling CONFIG_TINYDRM_ILI9163 driver - regardless of the device
> tree - results in the below confusing log line:
> SPI driver ili9163 has no spi_device_id for newhaven,1.8-128160EF
>
> This commit fixes this false alarm by adding "1.8-128160EF" to
> spi_device_id table of ili9163 driver.
>

It's not actually a false alarm, this is needed if you want the driver
module to be automatically loaded. Because the SPI core always reports
a MODALIAS of the form "spi:1.8-128160EF" even if the device has been
registered by OF.

So this is an actual fix since this driver can be built as a module.

> Signed-off-by: Mostafa Weshahy <mweshahy@yahoo.com>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat