Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 17 Nov 2023 09:38:13 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Sahaj Sarup <sahaj.sarup@linaro.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/ssd130x: Change "solomon,page-offset" property
 default value
Message-ID: <yqneztpzmhhqenommpvhw2pksjspq7srpeba7ckfia5z3c5aap@wmnxhbgcflnd>
References: <20231116180743.2763021-1-javierm@redhat.com>
 <20231116180743.2763021-3-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ugqcnc4hp5qdpf6v"
Content-Disposition: inline
In-Reply-To: <20231116180743.2763021-3-javierm@redhat.com>
Precedence: bulk


--ugqcnc4hp5qdpf6v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 16, 2023 at 07:07:39PM +0100, Javier Martinez Canillas wrote:
> This is used to specify the page start address offset of the display RAM.
>=20
> The value is used as offset when setting the page start address with the
> SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to
> 1 if the property is not present in the Device Tree.
>=20
> But the datasheet mentions that the value on reset for the page start is a
> 0, so it makes more sense to also have 0 as the default value for the page
> offset if the property is not present.

I can see the argument, but that's a DT ABI breaking change.

> In fact, using a default value of 1 leads to the display not working when
> the emulated fbdev is attached to the framebuffer console.

Could we fix that one instead? What is the issue about, exactly

Maxime

--ugqcnc4hp5qdpf6v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZVcmawAKCRDj7w1vZxhR
xT0mAQCE0xcyl9bZKj0rvFdl4wB/NEpUf6ubP/8QlEW1O0uNogEA3sQFl+W/EfEi
L21HM4MkPBXDc8MHyzB/8wbCsrnHQQ0=
=T+Yj
-----END PGP SIGNATURE-----

--ugqcnc4hp5qdpf6v--