Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp368496rdb; Fri, 17 Nov 2023 00:42:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxXQ04d7gyT1bmlPtrMGjqG3yeAVnM9pgGvKGsBOLAL1gOOzI8TPOse1DER3JhzXGaggDq X-Received: by 2002:a05:6871:299:b0:1ef:a87f:5d52 with SMTP id i25-20020a056871029900b001efa87f5d52mr24328061oae.6.1700210555568; Fri, 17 Nov 2023 00:42:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700210555; cv=none; d=google.com; s=arc-20160816; b=L1gvNYAUHT7/9fSx6j6YutQ+H5wyOk+/RRMhoRwS56CR8yFViBdv2UQKeWgPp/+GZx LQ8b/252Wk/h5uL0xnyMhNzxsFsepCku9B5yfLTPGk1KbM6G8duZX7dBwput03x+3/nL 3sJRVDuoJHAFpTcImO7GM0lXhJvQRZm1LMZbA5JAiDwZbCm+6Pn8mdnunLVRfcnF2DKw SRhXExKIEW5egy6zH+errnPHPBawAAkbWdNsISvkL8OkZOT/WXvlYIYt2BYMibu49T+6 OCPfhOhXWiuroBBPqg+f02ImG/yc420mAtCf0vnyP36JvapZZH4I3vb8U1Ghxp8PwqWU H9IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cFDW5qnEieU/7meRfyQHnwLHDXxRrYelxaxapyd4utk=; fh=Vq4vvK5kzRE8q9ndypwBA3eJZsG0/zeXjqn5yOL5+iU=; b=zPUbW9joGHYIWRCfjNL61QUJ/Vp+eCCdZvLYPjjQZftvcHuUFd0HT3qtwaNP9h3FxM c2SkQZcZO0DyJxBtwHDU0sL9Iky6e9mizmwzSo8iRwrKKgGH0EBH2VXPkD6iNbDufiJd RpIurpn8uR77UBM9hNiOv/Zt8aEXHE7XGA8bodz+C7e/lYACJPAWttB/T5MmIhb0Vw4a VTc3yID2/Wge3+TX93+2f6DGEmOFvWTmmkQBiO9HxnJRzLcP7H0YPrStgUZ7WM07twyk HxOgPaIrI5C/zDW5K87vRm4u6yyLetHGRl6r9yC7vzrvjg05R1JhPtIquXGNjWFEq236 kgJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JmVawmQW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z128-20020a633386000000b005b936900e26si1432375pgz.713.2023.11.17.00.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 00:42:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JmVawmQW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2824981C00E1; Fri, 17 Nov 2023 00:42:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbjKQIm0 (ORCPT + 99 others); Fri, 17 Nov 2023 03:42:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbjKQImZ (ORCPT ); Fri, 17 Nov 2023 03:42:25 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08529196; Fri, 17 Nov 2023 00:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700210542; x=1731746542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EEkIXmHOKSdswOgaeNVurkzd4xWtTvPVbwH173FnRxI=; b=JmVawmQWwkubjkpFPPt21FapUn4Oib0i7Uat9NWO/eEdGdTGXHClYWXt ZIj/2AeyNGresgaC/QOTu0JjBBsXtpfXIa7o5JptbPtnEJXCGgBlonzeH v1lRPtyvqtkw3su9uqBVQN0VJXLdTtdcuoFI0R7NOR99Ej/TVhn9wUFZG e9SJM6XcvCKU/9XYLtnXMS+5SvekBt7AELWF/dxzvmL7io8JOCCN6Ioo6 Wb8GfmhHHWG61k/bUGgrNBgdaRGCI3sHzeNeGk20zERrIHA08nzqiM0Em yzVOqzaMJhf8lTgiONbairYJ607gVGqv7jFFXhshzs5d+h2bxG/bwttZm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="390116125" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="390116125" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 00:42:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="883059947" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="883059947" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmsmga002.fm.intel.com with ESMTP; 17 Nov 2023 00:42:19 -0800 Date: Fri, 17 Nov 2023 16:40:33 +0800 From: Xu Yilun To: Philipp Stanner Cc: Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Airlie Subject: Re: [PATCH v2] drivers/fpga: use standard array-copy function Message-ID: References: <20231114111901.19380-2-pstanner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231114111901.19380-2-pstanner@redhat.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 17 Nov 2023 00:42:33 -0800 (PST) On Tue, Nov 14, 2023 at 12:19:02PM +0100, Philipp Stanner wrote: > dfl.c utilizes memdup_user() and array_size() to copy a userspace array. > array_size() will likely never trigger thanks to the preceeding check. checkpatch says: WARNING: 'preceeding' may be misspelled - perhaps 'preceding'? #7: array_size() will likely never trigger thanks to the preceeding check. ^^^^^^^^^^ I fixed it myself. Acked-by: Xu Yilun Applied to for-next. Thanks.