Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231117055849.534671-1-quic_rohiagar@quicinc.com> <20231117090349.GA244633@thinkpad>
In-Reply-To: <20231117090349.GA244633@thinkpad>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Fri, 17 Nov 2023 11:05:34 +0200
Message-ID: <CAA8EJpqj4_HhkEXtm4JNo5+dfUb3eRtHxAF=NUaeRohDADVx0w@mail.gmail.com>
Subject: Re: [PATCH v3] arm64: defconfig: Enable GCC, pinctrl and interconnect
 for SDX75
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     Rohit Agarwal <quic_rohiagar@quicinc.com>, catalin.marinas@arm.com,
        will@kernel.org, quic_bjorande@quicinc.com,
        geert+renesas@glider.be, konrad.dybcio@linaro.org, arnd@arndb.de,
        krzysztof.kozlowski@linaro.org, neil.armstrong@linaro.org,
        nfraprado@collabora.com, m.szyprowski@samsung.com, u-kumar1@ti.com,
        peng.fan@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        kernel@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 17 Nov 2023 at 11:03, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> On Fri, Nov 17, 2023 at 11:28:49AM +0530, Rohit Agarwal wrote:
> > Enable Global Clock controller, pinctrl and interconnect framework
> > support for Qualcomm's SDX75 SoC which is required to boot to
> > console on sdx75-idp platform.
> >
> > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> > ---
> >
> > Hi,
> >
> > Changes in v3:
> >  - Clubbed all the three patches in a single patch.
> >  - Link to v2: https://lore.kernel.org/all/20231116093513.14259-1-quic_=
rohiagar@quicinc.com/
> >
> > Changes in v2:
> >  - Updated the commit message for the patches.
> >
> > Thanks,
> > Rohit.
> >
> >  arch/arm64/configs/defconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfi=
g
> > index b60aa1f89343..4c0cd428d073 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -599,6 +599,7 @@ CONFIG_PINCTRL_SC8280XP=3Dy
> >  CONFIG_PINCTRL_SDM660=3Dy
> >  CONFIG_PINCTRL_SDM670=3Dy
> >  CONFIG_PINCTRL_SDM845=3Dy
> > +CONFIG_PINCTRL_SDX75=3Dy
> >  CONFIG_PINCTRL_SM6115=3Dy
> >  CONFIG_PINCTRL_SM6115_LPASS_LPI=3Dm
> >  CONFIG_PINCTRL_SM6125=3Dy
> > @@ -1252,6 +1253,7 @@ CONFIG_SDM_GPUCC_845=3Dy
> >  CONFIG_SDM_VIDEOCC_845=3Dy
> >  CONFIG_SDM_DISPCC_845=3Dy
> >  CONFIG_SDM_LPASSCC_845=3Dm
> > +CONFIG_SDX_GCC_75=3Dy
> >  CONFIG_SM_CAMCC_8250=3Dm
> >  CONFIG_SM_DISPCC_6115=3Dm
> >  CONFIG_SM_DISPCC_8250=3Dy
> > @@ -1519,6 +1521,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=3Dy
> >  CONFIG_INTERCONNECT_QCOM_SC8180X=3Dy
> >  CONFIG_INTERCONNECT_QCOM_SC8280XP=3Dy
> >  CONFIG_INTERCONNECT_QCOM_SDM845=3Dy
> > +CONFIG_INTERCONNECT_QCOM_SDX75=3Dy
>
> Is there any criteria to make ICC built-in? I'd vote for built-in on all
> platforms to keep it aligned eventhough old platforms do not require it f=
or
> booting.

I'd say, we should be able to open the console without any additional
modules. Thus I support your idea.

>
> - Mani
>
> >  CONFIG_INTERCONNECT_QCOM_SM8150=3Dm
> >  CONFIG_INTERCONNECT_QCOM_SM8250=3Dm
> >  CONFIG_INTERCONNECT_QCOM_SM8350=3Dm
> > --
> > 2.25.1
> >
> >
>
> --
> =E0=AE=AE=E0=AE=A3=E0=AE=BF=E0=AE=B5=E0=AE=A3=E0=AF=8D=E0=AE=A3=E0=AE=A9=
=E0=AF=8D =E0=AE=9A=E0=AE=A4=E0=AE=BE=E0=AE=9A=E0=AE=BF=E0=AE=B5=E0=AE=AE=
=E0=AF=8D


--=20
With best wishes
Dmitry