Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <5165bc9f-4e57-bdda-0640-d6cdcd08f031@intel.com>
Date:   Fri, 17 Nov 2023 10:18:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] net/mlx5: DR, Use swap() instead of open coding it
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        <saeedm@nvidia.com>
CC:     <leon@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFAzTUI1UEFFcTFwZU41YXF0ZERHeU96djZzVjJGN01iNUd6OXlLOWZPSHVZ?=
 =?utf-8?B?ZlkxQmljSG1HejExZk9SMk1OS2RGMGN5MjRlRHJsazhkMlZLU0pZaXhyMUk2?=
 =?utf-8?B?U0JlenB5c2tFT2F1d0M1SklhNHVCSjc3R3NGVUNlZStSaEVUd2ZyanZ0TWJE?=
 =?utf-8?B?eE9YVS9Ld3ZwbEtGMlJKMjRxc011ejFKQ082WnQxdHFUMzJkQkRaMSt2cXc5?=
 =?utf-8?B?c1hPY1k4OEVYenJySzBmVnNRQXFhN2VTT1hTdzFiSHN6SWxmaEQvYnJMWmI2?=
 =?utf-8?B?NzJWV0R2YUIzVS9UNEdIa2lQaTBOa2I5TFg0NkhLbDJVMCtTRGhyVmdMREpj?=
 =?utf-8?B?d2EzWklKbU55QlRDZkkrZncyVGJLWUgrTFRaaldmVlpITXpQdEdkTlViVDZz?=
 =?utf-8?B?ejd3NW9RNityUG1DYVA2aGFiZ2M5MkZCRFJIaTJuYzRGNG1BWUl2NW9HRlFD?=
 =?utf-8?B?OWpTODFTSGo1Z21La1lSVEdBZHY1NUZ5T09WVjZLM0t0eGV2cWs0N1BjM2ND?=
 =?utf-8?B?bjJ1dHpQYU5BT3hPaGdiVWw2Zm1XdzBncHRzVHdqNTl6RUd2cTc0UDRXQTdY?=
 =?utf-8?B?ZmIrdTFCWmJuRVdPb2cwZFJCbWdKVjduc1pqdjQvK3E2ZUdqa1djOTRQMnZJ?=
 =?utf-8?B?cndyTy84Z2thakJmRXp5QXdSSHppdzlSb2dhdzhlR2U0T2tiT05IN0t4bkd4?=
 =?utf-8?B?VnFHTkw5L1E2RnhDTVhpZlp5MDA5NjlSeHRLMU5WVmo3N2FhMTVOUGgxOXFR?=
 =?utf-8?B?OWxnSENVdDd3cXNhQzFreG9sNVhjT0ozZlNRaU41NU52dkRuWE5NVTdrRXhU?=
 =?utf-8?B?RmNVVmk2S28yUVg3Qzdzdk5TajJhcytYMzRVMFRxdUVEQStjcm45ZmphQXlS?=
 =?utf-8?B?WllGSnY1NUdVQlpjejdveU9hQnpyQ0N5TkpCbXovZ0Fqc3FuMjFNZEx1R3lh?=
 =?utf-8?B?bU5mSXoyYmNyZ0tyeUJXMEx1V0R1ZGVGaHNscjNqaWJJOGZWMkc1SlZ3UWpv?=
 =?utf-8?B?c2FQSlVjdDhrV3NEak41VEpZeHlFeVoyd24xdjJHcnZOSXVZSXZDbzBlUjFJ?=
 =?utf-8?B?UHRsaDF0blFHWkJtRytDMjE4eHRBd3ZuTXh5UUt2SkVGbS9vTXpHWGM5djFB?=
 =?utf-8?B?V2NIcmF5QXFLY1NNNGJnU1ZHZ2p6NGV6SzFsTzhMekdmQ0FUSEZNRnd0NlRM?=
 =?utf-8?B?NlhaZGJGS2FtVk5CV0JzL1RJWkd2K0VCZ0RtVVIyYVNrcmRJUVFNM1BhUklj?=
 =?utf-8?B?bVJ1YVhCcjIzdG9QNHFFYWZPSWdLeTlwQVBTMXdNVE1ReHRBckZId1YxbmF2?=
 =?utf-8?B?SUhjeVFac1RqcGE5L3ZJc3g3RjZMZjVWS0dzZWFrUytjc3BObVlsUUQybjlv?=
 =?utf-8?B?QlFEWjl6bmhTYUhJejFLOUxZWnhKVkVNcCtnOEMwZ3p4dGVEdUV4OHlocExs?=
 =?utf-8?B?bGdLK0h2bWVvbk1PL2JwOXhWdkhrNU1RbUNNbmN5K2dmTXgxV3JBQWFDVW1H?=
 =?utf-8?B?SjNnL2JqVHF6amFENG1vOE5Ic0IvRU8xdDMvQ3lXYmJ1MUNQbnJ2RXNqdVRW?=
 =?utf-8?B?VCsrdXE4OHNXbWp2NHdPaHZuZ0V6UDQ5SkdGRkFCNXB2TjJQWkVwamhwemlU?=
 =?utf-8?B?SWdpcGswSnhWWGxBaGhZbUJsZks3cWc0UXV0VTV3NFFvQUVWRGFmcU1BZ1lB?=
 =?utf-8?B?U2hXaU1WRGFlaHRYK00vTnVtY3l4SU5vd2ZkR1dOenRWNElhMHRMTXRXOWYz?=
 =?utf-8?B?WTdaOFppVUNYcHd3SER2Qm5kNDJoTExCNGxaM2duSVBqNFM2Y1hWTmJnVnJy?=
 =?utf-8?B?SDMwajNYSitkeU9veEtIcGJwZzRmUkpYZDJLZXlZU1duSUZRV21TV2k1WUNo?=
 =?utf-8?B?VmZZVFhQMDhuckN1MG90UXdpc0VHUmVLVWJyR1RGNENsUHBoaEZaWmYwZmFD?=
 =?utf-8?B?bkk4SmVNVjduYVZjdXdMNXVPT1pUbGJUeXdhMllJbkR2TlFCamd4Z0lrNm1C?=
 =?utf-8?B?cGlBWjFNSUY5SDFzSmcvU3Zad0pzZWRyUGUzT2J3VzVZMmxYNzN5RUl6M3lY?=
 =?utf-8?B?eTRKQ1BwTk5JY1orejI1UFVuajhnQUV4MFVBRjh3amxMbkJFU2ZJMWhwSStP?=
 =?utf-8?B?SExOMkRmbytRME5KTk1lMVQzNUdpb1M3T3dWaTZZU1hiZ2JyVVYrUTQra3pK?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 287484ea-cb33-45de-ead7-08dbe74e32f6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 09:18:45.4439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 51DRUVt/6EMRDJhrV+ZbSRfYXiQUMdKDOTadkYsBEt7mApFDzAM16KsxqrG1IfDuMhbLaDXu3tuj7jcIiGqjybW6KT1rsjY4Sibhqbz9gts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8402
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 17 Nov 2023 01:19:04 -0800 (PST)

On 11/17/23 08:19, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
> 
> ./drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1254:50-51: WARNING opportunity for swap().
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7580
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   .../net/ethernet/mellanox/mlx5/core/steering/dr_action.c  | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> index e3ec559369fa..6f9790e97fed 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> @@ -1170,7 +1170,6 @@ mlx5dr_action_create_mult_dest_tbl(struct mlx5dr_domain *dmn,
>   				   bool ignore_flow_level,
>   				   u32 flow_source)
>   {
> -	struct mlx5dr_cmd_flow_destination_hw_info tmp_hw_dest;
>   	struct mlx5dr_cmd_flow_destination_hw_info *hw_dests;
>   	struct mlx5dr_action **ref_actions;
>   	struct mlx5dr_action *action;
> @@ -1249,11 +1248,8 @@ mlx5dr_action_create_mult_dest_tbl(struct mlx5dr_domain *dmn,
>   	 * one that done in the TX.
>   	 * So, if one of the ft target is wire, put it at the end of the dest list.
>   	 */
> -	if (is_ft_wire && num_dst_ft > 1) {
> -		tmp_hw_dest = hw_dests[last_dest];
> -		hw_dests[last_dest] = hw_dests[num_of_dests - 1];
> -		hw_dests[num_of_dests - 1] = tmp_hw_dest;
> -	}
> +	if (is_ft_wire && num_dst_ft > 1)
> +		swap(hw_dests[last_dest], hw_dests[num_of_dests - 1]);
>   
>   	action = dr_action_create_generic(DR_ACTION_TYP_FT);
>   	if (!action)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

For future non-bugfix contributions please target patches to net-next