Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 17 Nov 2023 10:25:47 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Albert Huang <huangjie.albert@bytedance.com>
Cc:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Toshiaki Makita <toshiaki.makita1@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] veth: fix ethtool statistical errors
Message-ID: <ZVcxmwm/DRTB8QwO@lore-desk>
References: <20231116114150.48639-1-huangjie.albert@bytedance.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wM0LZ3in3H4K3W0K"
Content-Disposition: inline
In-Reply-To: <20231116114150.48639-1-huangjie.albert@bytedance.com>
Precedence: bulk


--wM0LZ3in3H4K3W0K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> if peer->real_num_rx_queues > 1, the ethtool -s command for
> veth network device will display some error statistical values.
> The value of tx_idx is reset with each iteration, so even if
> peer->real_num_rx_queues is greater than 1, the value of tx_idx
> will remain constant. This results in incorrect statistical values.
> To fix this issue, assign the value of pp_idx to tx_idx.
>=20
> Fixes: 5fe6e56776ba ("veth: rely on peer veth_rq for ndo_xdp_xmit account=
ing")
> Signed-off-by: Albert Huang <huangjie.albert@bytedance.com>
> ---
>  drivers/net/veth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index 0deefd1573cf..3a8e3fc5eeb5 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -225,7 +225,7 @@ static void veth_get_ethtool_stats(struct net_device =
*dev,
>  	for (i =3D 0; i < peer->real_num_rx_queues; i++) {
>  		const struct veth_rq_stats *rq_stats =3D &rcv_priv->rq[i].stats;
>  		const void *base =3D (void *)&rq_stats->vs;
> -		unsigned int start, tx_idx =3D idx;
> +		unsigned int start, tx_idx =3D pp_idx;
>  		size_t offset;
> =20
>  		tx_idx +=3D (i % dev->real_num_tx_queues) * VETH_TQ_STATS_LEN;
> --=20
> 2.20.1
>=20

Hi Albert,

Can you please provide more details about the issue you are facing?
In particular, what is the number of configured tx and rx queues for both
peers?
tx_idx is the index of the current (local) tx queue and it must restart from
idx in each iteration otherwise we will have an issue when
peer->real_num_rx_queues is greater than dev->real_num_tx_queues.

Regards,
Lorenzo

--wM0LZ3in3H4K3W0K
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZVcxmwAKCRA6cBh0uS2t
rL8vAQCJSYOePaGYIAzOPQ5MeXrdFWCb6zjNMqja2zjHP45xGgEAwDNcSm8iPh7+
8RLoiNT+UNlBNyHWxEGBO5trDBfoRgg=
=15I0
-----END PGP SIGNATURE-----

--wM0LZ3in3H4K3W0K--