Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp416245rdb; Fri, 17 Nov 2023 02:33:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZLgU3GMN4nml4HwAR5fDW5MiFEdoqTKm/gCOUQHWVOeh6BM8q6jQcXLUrNNun6mbzUfM1 X-Received: by 2002:a17:903:25c2:b0:1cc:6101:2086 with SMTP id jc2-20020a17090325c200b001cc61012086mr4297924plb.11.1700217191919; Fri, 17 Nov 2023 02:33:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700217191; cv=none; d=google.com; s=arc-20160816; b=XmCqcdH2YxxhujutSMEa64Q5QffoQeLrlVo4DIqdtsp//ipa9k0FdmhI67aXbqAjJd fEDKFbEYYUdGSkMxW0XYYGeCwc+8I08XutFPosHzO7HY1nfMUkP2IvcNxb/jinEZT1JQ O8xYR900WwuhRaW0DvZFzdeb8g/HTbv3HnqTarhYCkBiAIhaocIIzMDlcyQz+6YOQ0te tXn/bNW6awIysXcZ6jDMLAJXAo0cbA4PWTH8rWXlDlgc+1ZHvp3vemWjsM7jx1NH5KZx cVcbEzHjlKaXwrpQtvIlWNi1z1dYlXD9oNCAPiwX9A+F4Lco1TjsOt5x6efCb3a758ml 0y6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=67VYQlHZA7kFDHxJ1xW0Qn9/se/uuPlka3r6xNnUCck=; fh=aoef0buGd0K3Fjj6U0Jy2MPFRtcrKpzALmuM2tAV0rs=; b=VhaQ+2v8CIWfJU3PogWfg+1JS74yJ47XXaNrHdQiKiEn9zPRO9ymBa84DIwKqGbRaK vMtGu/GdnLqCRiN9fLw6TN5ULdt1GmbmlMwEEvPFRviG5WK7C+7QfDj8ux6ApjBVE1ps iJC+I50CPY5YSCAviAnZmOmnvfQCXV13mgoV8WCOo6vQvMsxwNjY1LC0eT1ahTGKg/3I XyCiTeMeHkjyOxmMl330qNtJpvPr8otrIkhuUpkBnApOKpGHpzZu8zszFtNIf7r84VO6 2j8ahjvRJ0VG4EaGrPIiRNaYj1UkyBGC1Kz3//xP5HbCd+lAB0WtW3XHhFhAkXnLMIEx OnGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QBTa/kB4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id jd7-20020a170903260700b001c4062a0e43si1532333plb.169.2023.11.17.02.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 02:33:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QBTa/kB4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2AE5D8074784; Fri, 17 Nov 2023 02:33:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345960AbjKQKdK (ORCPT + 99 others); Fri, 17 Nov 2023 05:33:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345930AbjKQKdF (ORCPT ); Fri, 17 Nov 2023 05:33:05 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE45C127 for ; Fri, 17 Nov 2023 02:33:00 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-544455a4b56so2579465a12.1 for ; Fri, 17 Nov 2023 02:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700217179; x=1700821979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=67VYQlHZA7kFDHxJ1xW0Qn9/se/uuPlka3r6xNnUCck=; b=QBTa/kB4KjWNc0X4dSXX6kb1Dth6TZqpIUZHeJxswO9Zyfax79zh5upDoP+9/XfZGh aJ9B/Esqa8bgvHwVOYIzPny3CKaabibFfUrffhfqkSODjrB9hthzsaxpDMY7G7MQve3J Dwc8mCbgck3v1PNhLJIFoBpeXrk7yc4x8OKKEJHEKr5jqNfhlTILg5oChyl0YwSXANtY LRH3Nh+UytmsfqAteGkvECCfNmlEfC3wDrrr9Uxu2xmGTm1plhp07tfqcp72dbR/qpme WCI6QemGEFMfIwinOt7Bylc1iXQDhkxMk1sd6HnaAmpWbK4VRtteU7eBNuTB4+vmcMZE x96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700217179; x=1700821979; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=67VYQlHZA7kFDHxJ1xW0Qn9/se/uuPlka3r6xNnUCck=; b=G0u7FxfMMARkjz22F60h+eFgUO3prGovimqUju/at0dr1gepdAmDQWpRFxUJFUiHNJ tDdnxsHLYTN5B8bxfocSPgxMsMGoCfgsf77Rs9RR8aVtpW7gFFaXQT3Wd0JHEKFWWAV5 qqva41OeeTQAE3wyVrbmj1Iwlj8vInc7f/IDbKXlenkMXpCScpp3W/0GZGo8wxoFTAgG /KnLDJem506K4Xi9rUqURaFAwhBAJPeRu3il9JJgtjkQgq4gG7dggF9B33gi19MgNnVC J1YqanxZrVNLR17YKtvP878JZQ22wfBCzTQzUUq63SOlfiS3nfdmy4O1PH/P0FceMAOx D9AA== X-Gm-Message-State: AOJu0YwWDBKlorQHcYRzIhguZEvj9gOzJ/3VWdlIRFBXFHvSK5cNNygB 0j2tT2LyZ27tJN2ghvUytwtq7w== X-Received: by 2002:a05:6402:31e8:b0:543:bf55:248b with SMTP id dy8-20020a05640231e800b00543bf55248bmr13371775edb.13.1700217179340; Fri, 17 Nov 2023 02:32:59 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id v27-20020aa7cd5b000000b0053e43492ef1sm567026edw.65.2023.11.17.02.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 02:32:58 -0800 (PST) Message-ID: Date: Fri, 17 Nov 2023 11:32:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons Content-Language: en-US To: Tengfei Fan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, tglx@linutronix.de Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, -cc=kernel@quicinc.com References: <20231117101817.4401-1-quic_tengfan@quicinc.com> <20231117101817.4401-13-quic_tengfan@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231117101817.4401-13-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 02:33:10 -0800 (PST) On 17/11/2023 11:18, Tengfei Fan wrote: > The Volume Down & Power buttons are controlled by the PMIC via the PON > hardware, and the Volume Up is connected to a PMIC gpio. > > Enable the necessary hardware and setup the GPIO state for the Volume Up > gpio key. > > Signed-off-by: Tengfei Fan > --- No, really, necessary hardware? So why it is missing in the previous patch? Stop useless splitting of work which is done. You cannot have "release late, release often". The rule is: "release early, release often". NAK. Best regards, Krzysztof