Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Fri, 17 Nov 2023 18:35:25 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     LeoLiu-oc <LeoLiu-oc@zhaoxin.com>
Cc:     olivia@selenic.com, martin@kaiser.cx, jiajie.ho@starfivetech.com,
        jenny.zhang@starfivetech.com, mmyangfl@gmail.com, robh@kernel.org,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        CobeChen@zhaoxin.com, TonyWWang@zhaoxin.com, YunShen@zhaoxin.com,
        LeoLiu@zhaoxin.com
Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore
 instruction
Message-ID: <ZVdB7ZyjLay61mLp@gondor.apana.org.au>
References: <20231107070900.496827-1-LeoLiu-oc@zhaoxin.com>
 <20231108073454.521726-1-LeoLiu-oc@zhaoxin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231108073454.521726-1-LeoLiu-oc@zhaoxin.com>
Precedence: bulk

On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <LeoLiu-oc@zhaoxin.com>
> 
> Add support for Zhaoxin hardware random number generator.
> This driver base on rep_xstore instruction and uses the same
> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id
> array in the via-rng driver, so that the corresponding driver can be
> correctly loader on respective platforms.
> 
> ---
> 
> v1 -> v2:
> 1. Fix assembler code errors
> 2. Remove redundant CPU model check codes
> 
> Signed-off-by: LeoLiuoc <LeoLiu-oc@zhaoxin.com>
> ---
>  drivers/char/hw_random/Kconfig       | 13 ++++
>  drivers/char/hw_random/Makefile      |  1 +
>  drivers/char/hw_random/via-rng.c     | 23 +++----
>  drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++
>  4 files changed, 119 insertions(+), 13 deletions(-)
>  create mode 100644 drivers/char/hw_random/zhaoxin-rng.c

Please cc x86@vger.kernel.org as the same comments to the other
zhaoxin driver seems to be applicable here.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt