Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp417894rdb; Fri, 17 Nov 2023 02:37:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRxQtBLHWN5IPWufFGxMP69GMk9KWrdbwtQGLXUaCi+uhc/kOlatTUirEaRmUT0jxelhV+ X-Received: by 2002:a17:902:a985:b0:1cc:630d:8a5e with SMTP id bh5-20020a170902a98500b001cc630d8a5emr10749495plb.48.1700217437113; Fri, 17 Nov 2023 02:37:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700217437; cv=none; d=google.com; s=arc-20160816; b=JaH7X4Dx/8/2eKbtPuuW4KFcIzBH5UnaoFSq9IMpJO2+4MkUYNKAFpRj4WlsUq9mfE wNKKW4w+FAZF5zP7msz+J2L27da9awwl5TGrlBnzP8o1ppB3FrEy+XJMIWlnr1hHJxri tWGtIA0c8h42wg8e10Fam0z+aBoYZwMThUpGC0thL6OwtmhO1aMOM6UytXo23EGLHp3T AigSG76xs6nMR6rgfdw7KNXXyZMRawB9AyX6AJ1myKcyjy4fkiqR//2J0Z+NRuNh1BuG mxEOvR5LoXSbOgNoW3dVHMGm+ArBkpZAOOeyU8C6qM1uGsT83b+fDCJe4H1CJEESX0l+ NPBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=7eoRMfeDx8bgyuTtRS05O4OK20OW7eNC/rb8exPDIn8=; fh=SQX9E7k4WcmlQbTCVnn4NkZPscgC0JCUWn08LvXVm6Q=; b=PQS+uA14R/eHJmIrFxlAtKAkbZ1Qm0Tor6LkR6HjbvD1vkLG0OvAq8NtrXgj3hFl5u yTobmhmfShGGohHz4RRIG+5z1cIlu48H4iFp4VGCETl+OlFw5faFss80CPyj5RlF6/x5 c4JRrePDwS7ENpq26gykp0D+M77MqWPk23651UCs8EgKTuDJcSDm90STK8lhidbzD10E epWUXPBChx2pSsY9EVwmzS6kcFnFSrpo2MuSKBrqnjyojbMioQfNMwdA2jtbHBcofFeh TWQD+iw4OhzXoCCEjF5uvmlCe+61UOQ/x6DnCQGC5rmQznfMxf2kuF222KYGloBIm8FQ 50QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id n17-20020a170902e55100b001c370dc4445si1623153plf.210.2023.11.17.02.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 02:37:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 7291982C2DA4; Fri, 17 Nov 2023 02:37:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345915AbjKQKgo (ORCPT + 99 others); Fri, 17 Nov 2023 05:36:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345745AbjKQKgm (ORCPT ); Fri, 17 Nov 2023 05:36:42 -0500 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07A34BC; Fri, 17 Nov 2023 02:36:39 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1r3wD0-000cJb-BZ; Fri, 17 Nov 2023 18:36:23 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 17 Nov 2023 18:36:30 +0800 Date: Fri, 17 Nov 2023 18:36:30 +0800 From: Herbert Xu To: Weili Qian Cc: Chen Ni , wangzhou1@hisilicon.com, davem@davemloft.net, xuzaibo@huawei.com, tanshukun1@huawei.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: hisilicon - Add check for pci_find_ext_capability Message-ID: References: <20231109021308.1859881-1-nichen@iscas.ac.cn> <6eeced40-7951-ca0d-1bcd-62e1d329ca96@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6eeced40-7951-ca0d-1bcd-62e1d329ca96@huawei.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 17 Nov 2023 02:37:14 -0800 (PST) On Fri, Nov 17, 2023 at 10:07:00AM +0800, Weili Qian wrote: > > Thanks for your patch. The function qm_set_vf_mse() is called only after SRIOV > is enabled, so function pci_find_ext_capability() does not return 0. This check > makes no sense. Perhaps we could add a comment instead? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt