Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20230915094351.11120-1-victorshihgli@gmail.com>
 <20230915094351.11120-13-victorshihgli@gmail.com> <CAPDyKFpzuds6Ttbhw1cqZwisa+M6167DT3DUihcDqFjYJX95eA@mail.gmail.com>
 <CAK00qKDtXR2aV_h4KhAaWqjUfn8M2-yMsDHeFmz0ztjaF4wB=g@mail.gmail.com> <8c80f712-45c3-4c7a-a694-11efa4591078@intel.com>
In-Reply-To: <8c80f712-45c3-4c7a-a694-11efa4591078@intel.com>
From:   Victor Shih <victorshihgli@gmail.com>
Date:   Fri, 17 Nov 2023 18:49:57 +0800
Message-ID: <CAK00qKCAoousoi0Ly84Mvnycv99bizMmpAxRH1abpuGPT7VWEw@mail.gmail.com>
Subject: Re: [PATCH V12 12/23] mmc: sdhci-uhs2: skip signal_voltage_switch()
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, benchuanggli@gmail.com,
        HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
        takahiro.akashi@linaro.org, dlunev@chromium.org,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Victor Shih <victor.shih@genesyslogic.com.tw>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 6, 2023 at 6:51=E2=80=AFPM Adrian Hunter <adrian.hunter@intel.c=
om> wrote:
>
> On 6/10/23 13:30, Victor Shih wrote:
> > On Tue, Oct 3, 2023 at 5:58=E2=80=AFPM Ulf Hansson <ulf.hansson@linaro.=
org> wrote:
> >>
> >> On Fri, 15 Sept 2023 at 11:44, Victor Shih <victorshihgli@gmail.com> w=
rote:
> >>>
> >>> From: Victor Shih <victor.shih@genesyslogic.com.tw>
> >>>
> >>> For UHS2, the signal voltage is supplied by vdd2 which is already 1.8=
v,
> >>> so no voltage switch required.
> >>
> >> Can you please elaborate on this? I don't get anything of the above, s=
orry.
> >>
> >>>
> >>> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> >>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> >>> Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
> >>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> >>> ---
> >>>
> >>> Updates in V5:
> >>>  - Use sdhci_uhs2_mode() to simplify code in
> >>>    sdhci_uhs2_start_signal_voltage_switch().
> >>>
> >>> ---
> >>>
> >>>  drivers/mmc/host/sdhci-uhs2.c | 24 ++++++++++++++++++++++++
> >>>  1 file changed, 24 insertions(+)
> >>>
> >>> diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-u=
hs2.c
> >>> index fc37a34629c2..92fb69b7e209 100644
> >>> --- a/drivers/mmc/host/sdhci-uhs2.c
> >>> +++ b/drivers/mmc/host/sdhci-uhs2.c
> >>> @@ -142,6 +142,27 @@ static void sdhci_uhs2_set_power(struct sdhci_ho=
st *host, unsigned char mode, un
> >>>         }
> >>>  }
> >>>
> >>> +/*******************************************************************=
**********\
> >>> + *                                                                  =
         *
> >>> + * MMC callbacks                                                    =
         *
> >>> + *                                                                  =
         *
> >>> +\*******************************************************************=
**********/
> >>> +
> >>> +static int sdhci_uhs2_start_signal_voltage_switch(struct mmc_host *m=
mc,
> >>> +                                                 struct mmc_ios *ios=
)
> >>> +{
> >>> +       struct sdhci_host *host =3D mmc_priv(mmc);
> >>> +
> >>> +       /*
> >>> +        * For UHS2, the signal voltage is supplied by vdd2 which is
> >>> +        * already 1.8v so no voltage switch required.
> >>> +        */
> >>> +       if (sdhci_uhs2_mode(host))
> >>> +               return 0;
> >>
> >> This is just wrong. If we are initializing a uhs2 card, we certainly
> >> should call ->start_signal_voltage_switch() callback at all. This is
> >> for UHS-I cards, right?
> >>
> >
> > Hi, Ulf
> >
> > UHS-II does not need single_voltage.
> > I will modify the commit message in the next version.
> > sdhci_uhs2_start_signal_voltage_switch() is under
> > mmc_host_ops.start_signal_voltage_switch host ops,
> > therefore, we need to keep the UHS-I path here.
>
> You should be able to leave out the patch entirely
> because ->start_signal_voltage_switch() is not called
> for UHS2 mode
>

Hi, Ulf and Adrian

I will drop this patch in version 13.

Thanks, Victor Shih

> >
> > Thanks, Victor Shih
> >
> >>> +
> >>> +       return sdhci_start_signal_voltage_switch(mmc, ios);
> >>> +}
> >>> +
> >>>  /*******************************************************************=
**********\
> >>>   *                                                                  =
         *
> >>>   * Driver init/exit                                                 =
         *
> >>> @@ -150,6 +171,9 @@ static void sdhci_uhs2_set_power(struct sdhci_hos=
t *host, unsigned char mode, un
> >>>
> >>>  static int sdhci_uhs2_host_ops_init(struct sdhci_host *host)
> >>>  {
> >>> +       host->mmc_host_ops.start_signal_voltage_switch =3D
> >>> +               sdhci_uhs2_start_signal_voltage_switch;
> >>> +
> >>>         return 0;
> >>>  }
> >>>
> >>
> >> Kind regards
> >> Uffe
>