Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230915094351.11120-1-victorshihgli@gmail.com>
 <20230915094351.11120-21-victorshihgli@gmail.com> <CAPDyKFr4C8woRLzzz9FnhDvL0n8RObHNWCTP3WYxvraVYWYWXA@mail.gmail.com>
In-Reply-To: <CAPDyKFr4C8woRLzzz9FnhDvL0n8RObHNWCTP3WYxvraVYWYWXA@mail.gmail.com>
From:   Victor Shih <victorshihgli@gmail.com>
Date:   Fri, 17 Nov 2023 18:50:19 +0800
Message-ID: <CAK00qKBWv4=gnmULgHg-McOPgwqKp2eTPtW3vD6+dnyF_iAH9Q@mail.gmail.com>
Subject: Re: [PATCH V12 20/23] mmc: sdhci-uhs2: add add_host() and others to
 set up the driver
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, benchuanggli@gmail.com,
        HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
        takahiro.akashi@linaro.org, dlunev@chromium.org,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Victor Shih <victor.shih@genesyslogic.com.tw>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 5, 2023 at 7:39=E2=80=AFPM Ulf Hansson <ulf.hansson@linaro.org>=
 wrote:
>
> On Fri, 15 Sept 2023 at 11:44, Victor Shih <victorshihgli@gmail.com> wrot=
e:
> >
> > From: Victor Shih <victor.shih@genesyslogic.com.tw>
> >
> > This is a UHS-II version of sdhci's add_host/remove_host operation.
> > Any sdhci drivers which are capable of handling UHS-II cards must
> > call those functions instead of the corresponding sdhci's.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
> > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> [...]
>
> Just a few nitpicks, see below.
>
> > +static void __sdhci_uhs2_add_host_v4(struct sdhci_host *host, u32 caps=
1)
> > +{
> > +       struct mmc_host *mmc;
> > +       u32 max_current_caps2;
> > +
> > +       mmc =3D host->mmc;
> > +
> > +       /* Support UHS2 */
> > +       if (caps1 & SDHCI_SUPPORT_UHS2)
> > +               mmc->caps2 |=3D MMC_CAP2_SD_UHS2;
> > +
> > +       max_current_caps2 =3D sdhci_readl(host, SDHCI_MAX_CURRENT_1);
> > +
> > +       if ((caps1 & SDHCI_CAN_VDD2_180) &&
> > +           !max_current_caps2 &&
> > +           !IS_ERR(mmc->supply.vmmc2)) {
> > +               /* UHS2 - VDD2 */
> > +               int curr =3D regulator_get_current_limit(mmc->supply.vm=
mc2);
>
> As I also stated in another reply, please use vqmmc2 instead, which we
> added in patch4.
>

Hi, Ulf

I will update this in version 13.

Thanks, Victor Shih

> > +
> > +               if (curr > 0) {
> > +                       /* convert to SDHCI_MAX_CURRENT format */
> > +                       curr =3D curr / 1000;  /* convert to mA */
> > +                       curr =3D curr / SDHCI_MAX_CURRENT_MULTIPLIER;
> > +                       curr =3D min_t(u32, curr, SDHCI_MAX_CURRENT_LIM=
IT);
> > +                       max_current_caps2 =3D curr;
> > +               }
> > +       }
> > +
> > +       if (!(caps1 & SDHCI_CAN_VDD2_180))
> > +               mmc->caps2 &=3D ~MMC_CAP2_SD_UHS2;
> > +}
> > +
> > +static int sdhci_uhs2_host_ops_init(struct sdhci_host *host);
>
> Please try to re-order the code so this declaration isn't needed.
>

Hi, Ulf

I will update this in version 13.

Thanks, Victor Shih

> > +
> > +static void __sdhci_uhs2_remove_host(struct sdhci_host *host, int dead=
)
> > +{
> > +       if (!sdhci_uhs2_mode(host))
> > +               return;
> > +
> > +       if (!dead)
> > +               sdhci_uhs2_reset(host, SDHCI_UHS2_SW_RESET_FULL);
> > +}
> > +
>
> [...]
>
> Kind regards
> Uffe