Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Fri, 17 Nov 2023 11:29:37 +0000
From:   Will Deacon <will@kernel.org>
To:     Enlin Mu <enlin.mu@outlook.com>
Cc:     catalin.marinas@arm.com, enlin.mu@unisoc.com, enlinmu@gmail.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: remove kaslr-seed node when it had used
Message-ID: <20231117112936.GA28997@willie-the-truck>
References: <TYSPR04MB7084AFDB414AA7AE49A02D608AB2A@TYSPR04MB7084.apcprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYSPR04MB7084AFDB414AA7AE49A02D608AB2A@TYSPR04MB7084.apcprd04.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Nov 14, 2023 at 09:55:51PM +0800, Enlin Mu wrote:
> From: Enlin Mu <enlin.mu@unisoc.com>
> 
> If this node value is zero,it means that kaslr is enabled.
> Removing it for the system safe,nobody knows if this feature is
> enable or not.
> 
> Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> ---
>  arch/arm64/kernel/pi/kaslr_early.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/pi/kaslr_early.c b/arch/arm64/kernel/pi/kaslr_early.c
> index 17bff6e399e4..bc35d4ed84b7 100644
> --- a/arch/arm64/kernel/pi/kaslr_early.c
> +++ b/arch/arm64/kernel/pi/kaslr_early.c
> @@ -81,7 +81,7 @@ static u64 get_kaslr_seed(void *fdt)
>  		return 0;
>  
>  	ret = fdt64_to_cpu(*prop);
> -	*prop = 0;
> +	fdt_nop_property(fdt, node, "kaslr-seed");
>  	return ret;
>  }

Why is it a problem to know that KASLR is enabled? Wouldn't the presence
of the FDT_NOPs also give a pretty good hint?

Will