Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 17 Nov 2023 12:12:53 +0000
From:   Lee Jones <lee@kernel.org>
To:     m.brock@vanmierlo.com
Cc:     Florian Eckert <fe@dev.tdt.de>, Eckert.Florian@googlemail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz,
        kabel@kernel.org, u.kleine-koenig@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [Patch v8 6/6] leds: ledtrig-tty: add additional line state
 evaluation
Message-ID: <20231117121253.GB137434@google.com>
References: <20231109085038.371977-1-fe@dev.tdt.de>
 <20231109085038.371977-7-fe@dev.tdt.de>
 <39e7c892299c74821b1105a0967063ca@vanmierlo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <39e7c892299c74821b1105a0967063ca@vanmierlo.com>
Precedence: bulk

On Thu, 09 Nov 2023, m.brock@vanmierlo.com wrote:

> Florian Eckert schreef op 2023-11-09 09:50:
> > The serial tty interface also supports additional input signals, that
> > can also be evaluated within this trigger. This change is adding the
> > following additional input sources, which could be controlled
> > via the '/sys/class/<leds>/' sysfs interface.
> > 
> > Explanation:
> > DCE = Data Communication Equipment (Modem)
> > DTE = Data Terminal Equipment (Computer)
> > 
> > - cts:
> >   DCE is ready to accept data from the DTE (CTS = Clear To Send). If
> >   the line state is detected, the LED is switched on.
> >   If set to 0 (default), the LED will not evaluate CTS.
> >   If set to 1, the LED will evaluate CTS.
> > 
> > - dsr:
> >   DCE is ready to receive and send data (DSR = Data Set Ready). If the
> >   line state is detected, the LED is switched on.
> >   If set to 0 (default), the LED will not evaluate DSR.
> >   If set to 1, the LED will evaluate DSR.
> > 
> > - dcd:
> >   DTE is receiving a carrier from the DCE (DCD = Data Carrier Detect).
> >   If the line state is detected, the LED is switched on.
> >   If set to 0 (default), the LED will not evaluate DCD.
> >   If set to 1, the LED will evaluate DCD.
> > 
> > - rng:
> >   DCE has detected an incoming ring signal on the telephone line
> >   (RNG = Ring Indicator). If the line state is detected, the LED is
> >   switched on.
> >   If set to 0 (default), the LED will not evaluate RNG.
> >   If set to 1, the LED will evaluate RNG.
> > 
> > Also add an invert flag on LED blink, so that the LED blinks in the
> > correct order.
> > 
> > * If one off the new enabled input signals are evaluatet as 'enabled',
> >   and data are transmitted, then the LED should first blink 'off' and
> >   then 'on' (invert).
> > * If all the new enabled input signals are evaluatet as 'disabled',
> >   and data are transmitted, then the LED should first blink 'on' and
> >   then 'off'.
> > 
> > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> > ---
> >  .../ABI/testing/sysfs-class-led-trigger-tty   | 40 ++++++++++
> >  drivers/leds/trigger/ledtrig-tty.c            | 77 ++++++++++++++++++-
> >  2 files changed, 116 insertions(+), 1 deletion(-)

[...]

> Reviewed-by: Maarten Brock <m.brock@vanmierlo.com>

Please snip your replies.

-- 
Lee Jones [李琼斯]