Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <ecac085f-b957-4c96-8e45-63daf8a70904@wolfvision.net>
Date:   Fri, 17 Nov 2023 13:18:04 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 3/3] arm64: dts: rockchip: Add the camera interface
Content-Language: en-US
To:     Mehdi Djait <mehdi.djait@bootlin.com>, mchehab@kernel.org,
        heiko@sntech.de, hverkuil-cisco@xs4all.nl,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        conor+dt@kernel.org
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com,
        paul.kocialkowski@bootlin.com
References: <cover.1700132457.git.mehdi.djait@bootlin.com>
 <3566c176d1ef5ae93aa54587a14ccfa80974e872.1700132457.git.mehdi.djait@bootlin.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <3566c176d1ef5ae93aa54587a14ccfa80974e872.1700132457.git.mehdi.djait@bootlin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2NPK0MrWmFUNFNsY1QxWUxtOEtYMXNiMUdtY05DSVVMdE9vRDI1aHpiWFZM?=
 =?utf-8?B?aUFWdDVZVHRVR0pvbE9wbGNMWmpidVgyVk1oS3RkZFV3SEJtL05Da05KNFpK?=
 =?utf-8?B?SnNnalRPL0hrSElHN3FFTTFQNEFrekV0ZVQycEN4WVkyK1dqaUxhMTc2K2R4?=
 =?utf-8?B?elVVU0x5YWVtaHZLNkdmSjYzTVJMbStQSGI2YkNVdTdSWVZtdmgwTkE3cnRr?=
 =?utf-8?B?dU1TT1huUjZPUG1BUFRBczU2N2E5RFdpMm1pZDJCeFRXT3VKaGRvOVAwcnpv?=
 =?utf-8?B?RklvUHI4WFJrVC9aa3N0Z0E5TVZ6RmkxSjF1dlZKQ1FYdFlqV3JldlQya3FF?=
 =?utf-8?B?VFJoUjNqQUovRWtZZkExRnpocGd6SWcwdmNBbG92cnhVU1d4YmpRcFJkNjlS?=
 =?utf-8?B?Z2taTCtGQm5jWGYvcU9CT3lPSjJKRXNteVlGWUtrR0lBZ1dlcG9CZnRFTWRv?=
 =?utf-8?B?R3k4c3kxbTNHL0gvRHk3b28zaVh3eG0wZTB4WFc2UE55eHpKUHBGWWpHemJ3?=
 =?utf-8?B?T0hRblE5cUVHbTZ3bkJNb2N5L25FeDBmaXVjcU03TW9JYTlzREczcnlQYXZo?=
 =?utf-8?B?K0JXM2EvVzRRcEFteUtOYkE5b1VmbTR2byszT1d0R1laQlhmSVlFMlE3Nllj?=
 =?utf-8?B?QmlJNWE2UHBtNHZ1ZVEyMjBXZENXR1NDb2YrQ0hUY0dsQnNhbmx2TnlLVThh?=
 =?utf-8?B?TElQY2R5cGl6alZIcEhSRXNNU29OY1BGdFFtNTRobnV3WTNFUmI4OVJ6cEZB?=
 =?utf-8?B?b3o0cnlFeGoyRTJwa20ycWNmV1U3dHZOVjlpTVZTK0p3N240S1hwcVhLdHhw?=
 =?utf-8?B?VFlmem9haW9SM1dVcklYLzlFUURsT0NDbzA1M25JZDlxK1owQWJRWWEwUWY1?=
 =?utf-8?B?Ky9kT3ZKRFJNOEtFQW1lVXdXTm1GNUFkTEdNb2tHK3k3VTA0YjNleENzZ2s3?=
 =?utf-8?B?MkxsdklZVmwvQTFGb0txWDRSczhJeXA1TytTNWdRRi95Qy82N2lQZGFFOXFy?=
 =?utf-8?B?UENCTHprcWhHOWhSUEt5bjVHaGpNNXp6SEd0Z3RSdU9jUFVWMm1laW5NM2hl?=
 =?utf-8?B?dXRuQmc2dnFNYnNiaVBvZUYrL29ldHRrUUJTQklXRWFrNjZhdm1hdTg4d2ww?=
 =?utf-8?B?c3N4bEVSbDN2TXBMc2ttUE9RTkV0b2NiVjh2MjNYU0g2b01PMS9xZUJwbFRt?=
 =?utf-8?B?VmpvR1d1NFFNY3Y3T1hmYkx4MjZtdXFxVkxvcWhJTHJ0R3dEMXFuRnNsMGpW?=
 =?utf-8?B?S3dDWHQ3UHpNWDA0SFRFdlJHVzJLSUFKRFJRYzZ0bUhxVGZFakJ3ZzlHaUpF?=
 =?utf-8?B?eU5pV0dLYy94aSt6WmVybWNRcXd6Tkl6NExHSHk5SnZzMEdJL0h6a1BNakxH?=
 =?utf-8?B?R3cvZTNGRDFPdlhjUWw0MzZBZTVKeG5FS3Nid2R4Y0J2alIzcmVtK1phREI0?=
 =?utf-8?B?S0ZWTFIvREpOenExQ2hFK0xDUUNqM2xVSzY2TThqRDFkTnVFNXNNSzBWNjlR?=
 =?utf-8?B?bmMyZDNTOXIxcytvdzd2UEtvNjFGRFI0aGNJNzI2eFVkQUpGcUsya1oxdDYv?=
 =?utf-8?B?dUtlRjJ6ci9HT3ZhakwveVBaZ3RmZjJvOHl4RlAzT29YbVNkdmdYZ2ZRMGN1?=
 =?utf-8?B?dFJBTHg4VDF1V0FlSjFXZ3dwMmZJcGFBRjFlNUlzWk5Oc3krSVE3eHJRVlVr?=
 =?utf-8?B?QzJxd2ZVc09ZSndCR0JwK25PZERiWm8yQytsQ2pCSWcxNUF0dWJESUFWVHBK?=
 =?utf-8?B?blBjWFhlVk1MTGxrWXkxeFoxelBBL1hvdmEyYlRHemcxWjhxUTR4YkEzeU5H?=
 =?utf-8?B?V3BCOWZTcWF2UENyc1UramY4YnRQQXdxaHk5VHdFNnR6azhBSW1JVnorU2Js?=
 =?utf-8?B?clpUMzV1WTF4YnBZUE9HTGgzaGp0MDJwaHBSTlBueTNmR0Jsd1Nidmd0YkFR?=
 =?utf-8?B?L01NeWwyc2RTellxc0pEWlN3ZWsrNXV0V1hUbS96eTh5YzJTa0srb20vdUdD?=
 =?utf-8?B?dmY4YVpkTTYzQUN1OGN0VFZ5WVpHaGt5aUl5LzdhcjlsM1pxc2JMR0N5V25E?=
 =?utf-8?B?OFZaeUYrbjhtT1Joa1lWNXFVUG5EQlJ5R0RqWnFISjg2cEp1K1FiRWRrZVAw?=
 =?utf-8?B?Z01PeE1GWG1BK3ZTbTN4akFRN2wwekVNUk13Z1FsNDBzc3BsU3RvaHhwSXAx?=
 =?utf-8?B?a1E9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 07d7aa22-b9ed-4d4f-4add-08dbe7674169
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 12:18:06.9362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: flZOehDmzBPNrllBhdgKUlYPt5oWnSM3WhsBLR9okGVLSTFAerUFCYLKvnt6G6cQIQU1lcPxGbRz3CGawv/uup6FqOlZwcSi64ABEvmLTNI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB10381
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 04:18:21 -0800 (PST)

Hi Mehdi,

On 11/16/23 12:04, Mehdi Djait wrote:
> The PX30 has a video capture component, supporting the BT.656
> parallel interface. Add a DT description for it.
> 
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>

Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks and best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 42ce78beb413..3a4e859e5a49 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -1281,6 +1281,18 @@ isp_mmu: iommu@ff4a8000 {
>  		#iommu-cells = <0>;
>  	};
>  
> +	cif: video-capture@ff490000 {
> +		compatible = "rockchip,px30-vip";
> +		reg = <0x0 0xff490000 0x0 0x200>;
> +		interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>;
> +		clock-names = "aclk", "hclk", "pclk";
> +		power-domains = <&power PX30_PD_VI>;
> +		resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>;
> +		reset-names = "axi", "ahb", "pclkin";
> +		status = "disabled";
> +	};
> +
>  	qos_gmac: qos@ff518000 {
>  		compatible = "rockchip,px30-qos", "syscon";
>  		reg = <0x0 0xff518000 0x0 0x20>;