Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 17 Nov 2023 14:32:14 +0100
Message-ID: <87sf54jyjl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Oliver Sieber <ollisieber@gmail.com>
Cc:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Sound System <linux-sound@vger.kernel.org>,
        Linux ALSA Development <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: Fwd: acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen 7 PRO 5850U
In-Reply-To: <78149e00-12b5-459b-8754-a17dd974916d@gmail.com>
References: <8bd0e77f-720b-4804-bbd8-477bd7df938e@gmail.com>
        <251c1bea-8250-40dd-bdea-1cd739d1e77a@gmail.com>
        <a75ce6e7-5012-43d8-a222-dd2639c5969c@gmail.com>
        <78149e00-12b5-459b-8754-a17dd974916d@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 17 Nov 2023 08:17:48 +0100,
Oliver Sieber wrote:
> 
> 
> Hi,
> 
> in the following I provide my proposed patch for the bug report on Bugzilla
> [1]. Let me quote from it:
> 
>     Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. 
>     My audio output is fine but my internal microphone cannot be found.
>     
>     Running `dmidecode` yields:
>     
>     Handle 0x000F, DMI type 1, 27 bytes
>     System Information
>                   Manufacturer: LENOVO
>                   Product Name: 20XGS1KT02
>                   Version: ThinkPad T14s Gen 2a
>     
>     Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?
> 
>     It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270.
> 
> My proposed diff looks as follows:
> 
> diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/
> rn-pci-acp3x.c
> index b3812b70f5f9..754e24d55e6f 100644
> --- a/sound/soc/amd/renoir/rn-pci-acp3x.c
> +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c
> @@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] =
> {
> ???? ??? ??? DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
> ???? ??? }
> ???? },
> +??? {
> +??? ??? /* Lenovo ThinkPad T14s Gen 2 */
> +??? ??? .matches = {
> +??? ??? ??? DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +??? ??? ??? DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"),
> +??? ??? }
> +??? },
> ???? {}
> ?};
> 
> Please have in mind that this is my first patch for the kernel.

The kernel patch should be in a proper format, so that it can be
merged to the upstream.  e.g. The Subject line should have a brief
description with the proper prefix for the corresponding subsystem (in
your case, something like "ASoC: amd:").  It'll follow the patch
description, as well as your proper Signed-off-by tag.

The details are found in 
  https://docs.kernel.org/process/submitting-patches.html

Could you resubmit the patch in a proper format?


thanks,

Takashi