Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp519401rdb; Fri, 17 Nov 2023 05:42:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaK1DShgoCyS/YAZNtpHWqA9r3sHXACU4g1T5zAXZrWJqLI7HaBQBMkUGldnmAk8dUtu/6 X-Received: by 2002:a05:6a20:9153:b0:187:4bf3:fc50 with SMTP id x19-20020a056a20915300b001874bf3fc50mr6456240pzc.13.1700228564558; Fri, 17 Nov 2023 05:42:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700228564; cv=none; d=google.com; s=arc-20160816; b=CfcojEmqxevL5ns+fPVUMCRtxGg4pERh4ZadrvmlhR9PKWBl86xoQvzLu1TQje9JxH hNM5T/sgdUc0YZR/F3SBzZIKjX1aiBepO3AsWe0MxHoZCbMMENTcF+ydCKqeRJ5CZRav RHpQA+uky9uTFWqV6RZm54wiuwjIrYU4POOQ+PpZQkB4xF9VEBEbGY+PX2UDNTe+W1WW uiV8R00ue9qLtWpKnV5K3+VujXy4mp2JrNJa21bS4dPrgCG/Y8wqBN8nNHtz5zgsAb1m Oaxi+TxMVnyKE/vdSFe7gKAxG2cHRGsCeRPr1/yfpQ5dmwk+NOp8TQfu7EUhGE++13RB C8XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SiGMv/vnZ4v12NU81A3GF+oSLQQzlvJbOlPSS0J1KlE=; fh=zSdfwdfY54C9/udZTRlhmjTBbI0CKWDSGiWvzuMGAEs=; b=mpAXi5gCrvcRR8ptIqee8HVDU/KNQq9EDEUeHN2cB9SWXGGBPHS0d4vzqZgfHEC/qE rjfRUXBzzn4b1nr2ageJ4TgeWG5iIyOt7EyqXi86azskwLl3GCAaRqm6Tug9K/Z/dETd R/Hx8VA+ya173eAKUnKDOmq4OW+P1RtL422+r3wWP9v6ae6nE5v3IEBKiwtg9t6Z5Ade DiTiSRjdYiIYGN3LgGwfyhx6e+5Ra8rSd+dOImErR4tZhKmlse1HvxB11rHbWCJZjVxa 640f46Se5wEsJsTln3+gPK4anWlAsCr1/0nO0LouLMn9i+S9jMdqryRpjh1K+oMKt3tv 6f4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=AjzGQnSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id o185-20020a6341c2000000b005bdf5961e67si1926548pga.639.2023.11.17.05.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 05:42:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=AjzGQnSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 698A08028A48; Fri, 17 Nov 2023 05:42:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbjKQNmn (ORCPT + 99 others); Fri, 17 Nov 2023 08:42:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKQNml (ORCPT ); Fri, 17 Nov 2023 08:42:41 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B09A4D4B; Fri, 17 Nov 2023 05:42:38 -0800 (PST) Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AHDRKgO027838; Fri, 17 Nov 2023 13:42:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=SiGMv/vnZ4v12NU81A3GF+oSLQQzlvJbOlPSS0J1KlE=; b=AjzGQnSiUAFwXEKZExGJLqX7sdTCuv19TaI3NbRJs+zBPsmNvWCj8sLECVnVfW0j16qt 8aQvUAUk35USTWcCh/Ql+5GqqzNTR6ecapx54ZUj/IaVw5iq7ngmzGLrTIdcVoAjLrFl bOK4WQGseEQLaLk+yOFBHNoHVhaEMBI696/bgQrBWnz/dbA4tNQ7Qj8OAiz4fRH6kZ7B xCmq3UeOrWFi4iY1fwbKW7tO6+6VSneVwyF41v2q2qjegBrg0G3FxVf9yzvjlhSCHnJB cUti6iiM+BbyAPEeIWgTvaTDh6MdTjhEjak7Evfyas6dvfC+z7CEZAok57HuYKk/zNbe DA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ue92qgjhs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:26 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AHDRftW028593; Fri, 17 Nov 2023 13:42:25 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ue92qgjgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:25 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AHD3wsa018347; Fri, 17 Nov 2023 13:42:24 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uamayxesd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Nov 2023 13:42:24 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AHDgLwf61604120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Nov 2023 13:42:21 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 446F62004E; Fri, 17 Nov 2023 13:42:21 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70F5F2004B; Fri, 17 Nov 2023 13:42:20 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.27.169]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 17 Nov 2023 13:42:20 +0000 (GMT) Date: Fri, 17 Nov 2023 14:42:18 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: Re: [PATCH 1/8] mm/memory_hotplug: fix memory hotplug locking order Message-ID: References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-2-sumanthk@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dyw7Xo6KqsR6c8oDGkKQ_1p0Sp4qmHkP X-Proofpoint-ORIG-GUID: 2gXwp31rvRshSCG8Q2JJYzbXbTqd8ycy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-17_12,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=33 priorityscore=1501 bulkscore=0 impostorscore=0 mlxscore=33 phishscore=0 mlxlogscore=31 clxscore=1015 spamscore=33 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311170102 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 05:42:43 -0800 (PST) On Thu, Nov 16, 2023 at 07:40:34PM +0100, David Hildenbrand wrote: > Good point; can you similarly add comments to these two functions that they > need that lock in write mode? Ok, will add it. Thanks