Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp521953rdb; Fri, 17 Nov 2023 05:47:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXCZzc+LY/YoqJ/ZFJGGrg3RNHxDFRYX1LIT2nra4mfWKfzVcu/bQ72HsISHaRBlAnB8dF X-Received: by 2002:a05:6830:3109:b0:6d2:e1fc:f387 with SMTP id b9-20020a056830310900b006d2e1fcf387mr15024578ots.4.1700228842932; Fri, 17 Nov 2023 05:47:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700228842; cv=none; d=google.com; s=arc-20160816; b=NJB69eBb/FzvgOD9Y7RKuF3nd36U6fMw6yhTgOS+lVBOY74ctcl0jHTuoaQOs2B7oV duj2E0jUr97rqYIAr0xjd4qs3EW8hNoWdUpXdSMeRCUbxVDOyCogitpjZOzs+jZjv0HR 0AremhhtuTLpUr8bBtA+4RFp27HDMH1gVzFz2cct9XZVf8TiYPYjd7zL7wwhJgMZ3H1o nmKA4VhRf9IDpC4cthB0elpdhQCcFFofXuG6vkvAUovwm4h98cpk3b1SXhFQ4bMJ4Nmo rsZ7u1SfXHoFPDIzEs72H2D5wKqgHZ04AXMhLUxDM0LxgdaRcL7CjapqG+5cjCFK+1r8 N3rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=b8YXudB1ILOE7rfi/NMNhGTPG7d6eHxwlaahgV7WPCI=; fh=SXfelq6bue/Kl/fYOnFOl1iitAVIR6amstvULT7Ui4s=; b=OBze9YqFfZ63E1NGrP29Vel432zAHrMPHdj7IeRuxm82Ov/v8ppUmlV8QuUESCLM8K g83vdcJumFGwaWxaK8L7emguBk3fXLI9cy5JWeWqQ3ZPLHL3kgjxzzNsgAgx4z8D5Z54 U6hGUnErLCaC4xJ97lS710RnTD/N+yQvaOhyNoe2wxCljRKv6KZK/Rbf3mIHO1nC8Ljq 572ZlLiTOwFHZ9IPTP8U9R3GhMw8ze0EV/2SrVokH9xy6y5kV7oVAM+SvH/MPIyU0+vQ vAMyGPAFsyJ/ZN8ia9GIn7vYTaaDwWhTqKVYmUGXm5JDchpfu6QgEXkmjyRWiOhv0PJ2 c/ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="o/QSuwEY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id q204-20020a632ad5000000b005c18dd91684si1844847pgq.352.2023.11.17.05.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 05:47:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="o/QSuwEY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C1AEF80984AA; Fri, 17 Nov 2023 05:46:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbjKQNqL (ORCPT + 99 others); Fri, 17 Nov 2023 08:46:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKQNqJ (ORCPT ); Fri, 17 Nov 2023 08:46:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8A1BD5B for ; Fri, 17 Nov 2023 05:46:06 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14B91C433C8; Fri, 17 Nov 2023 13:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700228766; bh=ktdPd545ypOk5AeKiYVdmHQBmIBcRw2iJERqnxbHOrE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/QSuwEYdpWhRgd55gSgIJwk+s+xGg5wK+559QU6cG2qcWsRUsSdXWtA3prAgf66s w8Bl4Ll9q6ywDINxz/yoeZ/JfXSMVt+DbND6liWl4s5z5HKOSNJrq+zWilLr/Tm/6d nBwwXYYJ3Gc6DvWt95Coy101B9tyERUV2OSHEkcw= Date: Fri, 17 Nov 2023 08:45:59 -0500 From: Greg Kroah-Hartman To: Kory Maincent Cc: Luis Chamberlain , Russ Weight , "Rafael J. Wysocki" , Thomas Petazzoni , linux-kernel@vger.kernel.org, Conor Dooley , Andrew Lunn Subject: Re: [PATCH] firmware_loader: Expand Firmware upload error codes with firmware invalid error Message-ID: <2023111720-slicer-exes-7d9f@gregkh> References: <20231117-feature_firmware_error_code-v1-1-92c973a50847@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231117-feature_firmware_error_code-v1-1-92c973a50847@bootlin.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 05:46:14 -0800 (PST) On Fri, Nov 17, 2023 at 11:27:53AM +0100, Kory Maincent wrote: > No error code are available to signal an invalid firmware content. > Drivers that can check the firmware content validity can not return this > specific failure to the user-space > > Expand the firmware error code with an additional code: > - "firmware invalid" code which can be used when the provided firmware > is invalid > > Acked-by: Luis Chamberlain > Acked-by: Greg Kroah-Hartman > Signed-off-by: Kory Maincent > --- > > This patch was initially submitted as part of a net patch series. > Conor expressed interest in using it in a different subsystem. > Consequently, I extracted it from the series and submitted it separately > to the main tree, driver-core. > https://lore.kernel.org/netdev/20231116-feature_poe-v1-7-be48044bf249@bootlin.com/ So you want me to take it through my tree? Sure, but if you are relying on this for any other code, it will be a while before it gets into Linus's tree, not until 6.8-rc1, is that ok? thanks, greg k-h