Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp535850rdb; Fri, 17 Nov 2023 06:07:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPXUoqKaPmvvAxENwtqagGuXBYz7mwYpDp97dXYdJDeYGwbeYH+pWvlPMf9xNhzYlP1yFd X-Received: by 2002:a05:6a20:4409:b0:188:f1dd:62a7 with SMTP id ce9-20020a056a20440900b00188f1dd62a7mr884106pzb.35.1700230065176; Fri, 17 Nov 2023 06:07:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700230065; cv=none; d=google.com; s=arc-20160816; b=bp5NNE3251J+AEwMSd/HNH6DKVKEC08eW4LV8o9h3jHbg1INdGI0E3lL7Top+IEhb4 CZxnzgmRfi4iCdP+rMYStzYwVpwaV+0GZcqr3yVZpzUfh75cOUjZeXH2ybqNXcNFT8lR 6t8He+L2ajmWjLiwmuVnGysETgXOF+McspNF7WtJGcYflimCHklD/F+w144OExLrIV3p MJRrPQ23PlBSxjSbKkaIzHEPoGcoJ8WOVNN21SoDU4StF6Jsj4U2OzAx4KtBdGDfqCJK /4J+RT1ZbHXmDv5CxBEe0mVw+O47SoASkGD3rU7NSmgjbM7jtmKx/W0CUA0SXzBpQ73s J2xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=I5QXnegWS5VNgSpWhOlr98MjHSa5xU0gdds5Tc5IRi4=; fh=Fe6G9oHRKYhoxHrlZ11LjBzi04+pAPnU+Z9Zu8Vld2c=; b=f6tcW0o52Na+7+Mkih+BgyIHO9kHqNV0/XwI251qf1hAEKSCK5r5C4Hl/WeEHMozAf R+/jzvjiJ20BVsXYzBX1QbIT1izluTgQKbdhM2pJY1tDSm4klvIVFIZzBB+N9dpkRs+m ltAdPVIW377z3OVkZNqn0ZJqgfREoWZShyJIXTOe5MDze5Jjcve+IYqOnzdNmogbPQSC HxUv1fjrI66KmybcAHvhfzjzlZXRlHFbr6djy2huHv/TFf1Lf1yiHWJporO2C+LIhmHQ UlQMzRxhaO6k2ZtaTGOY03gpttph2058cymj+pBFrWy+YfjVljjxhU+g/M7JKYUHpgDn kBeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Oo8hYWjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u33-20020a632361000000b005b9293dea1bsi1970911pgm.645.2023.11.17.06.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 06:07:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Oo8hYWjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 749B280C65C8; Fri, 17 Nov 2023 06:07:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbjKQOHb (ORCPT + 99 others); Fri, 17 Nov 2023 09:07:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKQOH3 (ORCPT ); Fri, 17 Nov 2023 09:07:29 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BDD611F; Fri, 17 Nov 2023 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700230046; x=1731766046; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=I5QXnegWS5VNgSpWhOlr98MjHSa5xU0gdds5Tc5IRi4=; b=Oo8hYWjA0FmoGZEI2Am0a095LK/3HKqczYlTueb9+riPDFohMvrqTeWo Z5CjpYQwhy2KL77ru0z+lPRsgINx7RdH+7Y9Bihc3uYr1JpR58TwVbpbN aOyJdx7cPh1ZN/HrZAJolqLwsjOnNYaR1vGvcx+XJ0MggnV0OkWG4RzA+ C0vtMOmFcG443ARfmsSoNRmlK6VHSnflYnqrORyqIeJWir9irM4bXzBEB UnDVoZSwxlf5oA+o4Wdlfko1zKxWOoSdIYsqWXf3ZgUGyQMtZHVQCu/g4 e3X8IsJjwUhMd6kiA8jDnHuAdI5SjBJkdKzEJYYP6dLEgBLnVbvbOEHxt g==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="391087483" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="391087483" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 06:07:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="909442841" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="909442841" Received: from unknown (HELO [10.237.72.75]) ([10.237.72.75]) by fmsmga001.fm.intel.com with ESMTP; 17 Nov 2023 06:07:07 -0800 Message-ID: Date: Fri, 17 Nov 2023 16:07:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/25] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Content-Language: en-US To: Mario Limonciello , Andy Shevchenko , Herbert Xu , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , Hans de Goede References: <20231110182304.3894319-1-andriy.shevchenko@linux.intel.com> <20231110182304.3894319-10-andriy.shevchenko@linux.intel.com> From: Jarkko Nikula In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 06:07:32 -0800 (PST) On 11/10/23 21:39, Mario Limonciello wrote: > On 11/10/2023 12:11, Andy Shevchenko wrote: >> As Krzysztof Kozlowski pointed out the better is to use >> MODULE_DEVICE_TABLE() as it will be consistent with the content >> of the real ID table of the platform devices. >> >> While at it, drop unneeded and unused module alias in PCI glue >> driver as PCI already has its own ID table and automatic loading >> should just work. >> >> Reviewed-by: Andi Shyti >> Signed-off-by: Andy Shevchenko > Reviewed-by: Mario Limonciello I'm using modular build and modules get autoloaded fine after this patch. Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula