Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 17 Nov 2023 16:27:17 +0200
From:   Louis Peens <louis.peens@corigine.com>
To:     Denis Arefev <arefev@swemel.ru>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, oss-drivers@corigine.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH] nfp: flower: Added pointer check and continue.
Message-ID: <ZVd4RYURdHLL+F2h@LouisNoVo>
References: <20231117125701.58927-1-arefev@swemel.ru>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231117125701.58927-1-arefev@swemel.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y8O1pscKI5GbfD8zs9upvFQyezXHeASKH0LWjoTUHEU+NbM9Xa57fEu7b+aj?=
 =?us-ascii?Q?Sx4PsPdazRB0wmTKCiAcUgtEyIylnFLctu8sf7gdsGj1mE+r6Cran/8FeEsx?=
 =?us-ascii?Q?QhLC1Bf350ihH+hH2WrD4qbx8QIvjgdCnxtzkYqw+Us3Wqc+fhlGQiu414Vd?=
 =?us-ascii?Q?zvBxtpRXCM28SmZW61EkZ8QRJ9uRDyEcuUJT5NNrlA+6qZ12NmWSoyegqBlk?=
 =?us-ascii?Q?LiwEYyFkLW8GqsK7cCT4bpVqsjCU11nsOMr9gpc0z0m2Yq/PHQ0jDWnZIM2f?=
 =?us-ascii?Q?Qw9MnUWWrdQtcT5zqbbVmILl778ivHQWwyKZbnhMaX82thU6ApeTD+TYvJF2?=
 =?us-ascii?Q?c15E+digZA7kOEnpXwVd6tMFI1GEbn/nXl3mzXzmKFchn2gdzBYwJVrMuP21?=
 =?us-ascii?Q?ogc1vNzE5Et/2rNweX8cM03CiTjvK143pm5cUiHWA8bKmqDtD+JQXdUlgyWb?=
 =?us-ascii?Q?EiLQ53TnJajdvk0psKv1sdIgcUWYhzHtFn1+oAGdT1EFTGbcQZvF0q1g0+fA?=
 =?us-ascii?Q?86+D5Xuc5QSF00pVs9uN0Gc5o4z1p2yHZ6SC14PQ9mk2AlmYkTWE/qmgILQr?=
 =?us-ascii?Q?O7+S3Mi6nnH20uwP0XRbt9FgM8mJ2kqRu0vcLj8ZAWuCoiNJ7dT3Qo+3LIxs?=
 =?us-ascii?Q?3NGVNgZ+atYUmJiV2ojce5m0Kq5cyY1fFsYTB3hgkPF27exA4zPoPM2914m7?=
 =?us-ascii?Q?lDbc1xV1mT/nR3/nh6TKw81FAt2ot60YQp9QrUL4zWZfHUvayZb9O8W4GB16?=
 =?us-ascii?Q?78cT3jLNePfwsffQL38ECBbLCXlMtqO0QkF2W3Pp7Syw94ceiAjD1FYav+wf?=
 =?us-ascii?Q?MRdLr0ayHWxZ8RLc01P3wahclCsVf/YDR63JuXnpRWb/FXyj9pAv2zEwM/iv?=
 =?us-ascii?Q?gBnuQVkKI5y/ble5Gst4zDGvJVP60nPj5aB5JD5hxw7zXNqM8HhYBZl4gCCm?=
 =?us-ascii?Q?tJuhaZba9RNqPEEBBUHiL8TwYrxcYcTF+WlGX12yY5GuonuDi+gdik1sAJw5?=
 =?us-ascii?Q?Xyy+6CkiN9VFYIxW4U0l+snDblQzcdQ/THvPJM3Ep7e8S+BhbVPwbpiUH379?=
 =?us-ascii?Q?NAXJEZ6L6cjRORz9H1r+DpPYR8mxFNPI/L9nCmVr95Jo4TcPBYf9veCNqC1n?=
 =?us-ascii?Q?gXyYg0Xzx5lzBYtKmRpOKlsQI8xJTFaW56G7Q6gn3XrFSet+6a+svh3KRsZa?=
 =?us-ascii?Q?tr6fSWRRccRpjkdFgdCV9pTnYR+IbCfv8RFI6awxEc3NDLsFhzHKL3uAsXuw?=
 =?us-ascii?Q?gvByu0lyLTgGsyTIfrtE6jmL7wtrke5E/wCGiwqeWNBYjGhjLN6mir3lsFup?=
 =?us-ascii?Q?3LbHe6lq6moHb7mQX+1SWvg4tgF6WUB5fbMnmbwA4nIAb+AHznAnDJhCEOfq?=
 =?us-ascii?Q?sQWGqDBk8QHa3cNZmBPv2FBKXbLlvbyKow0zDY9NdzNq8G1GFFUUmuQAtdBf?=
 =?us-ascii?Q?RABSm5vKJ0L0ecBaOCc0Hbeavt+FhFA90U3PRQa9vi5aw7JLXPZ9fR2hIk8q?=
 =?us-ascii?Q?J2j+CzVUWoYPJj5+gnAWTtCzCzy16ivUfuQ+sUfBZf9BlrtGcuXuFIlxbvr2?=
 =?us-ascii?Q?aiLQPEPB0zsQTaP9i2tWu1YCqyZR/r2Mbu+V6K8kpPGxpo5Zm6C3FO6Ylt+B?=
 =?us-ascii?Q?vA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a94540e7-97fb-4e99-05b8-08dbe779539b
X-MS-Exchange-CrossTenant-AuthSource: BL0PR13MB4403.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 14:27:28.4215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ATifGmkNhDgQUytDuiiRKS0XmyZOZIOgl4sPrWs5rJG834TuyoLG9Q+oWmu1nsy18pGikqHOfJd4zViJZucPAH/pS8v/8eelerGVelGTiM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4994
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 17 Nov 2023 06:27:45 -0800 (PST)

On Fri, Nov 17, 2023 at 03:57:01PM +0300, Denis Arefev wrote:
> 
> Return value of a function 'kmalloc_array' is dereferenced at
> lag_conf.c without checking for null, but it is usually
> checked for this function.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Denis Arefev <arefev@swemel.ru>
> ---
>  drivers/net/ethernet/netronome/nfp/flower/lag_conf.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c b/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> index 88d6d992e7d0..8cc6cce73283 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> @@ -339,6 +339,11 @@ static void nfp_fl_lag_do_work(struct work_struct *work)
>                 acti_netdevs = kmalloc_array(entry->slave_cnt,
>                                              sizeof(*acti_netdevs), GFP_KERNEL);
> 
> +               if (!acti_netdevs) {
> +                       schedule_delayed_work(&lag->work, NFP_FL_LAG_DELAY);
> +                       continue;
> +               }
> +
Thanks for reporting this Denis, it definitely seems to be an oversight.
Would you mind adding a 'nfp_flower_cmsg_warn' here as well, so that
this case does not go undetected? Maybe something like "cannot
allocate memory for group processing" can work.

>                 /* Include sanity check in the loop. It may be that a bond has
>                  * changed between processing the last notification and the
>                  * work queue triggering. If the number of slaves has changed
> --
> 2.25.1
>