Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp637030rdb; Fri, 17 Nov 2023 08:29:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSGb44C1dnvImv48RIF49ak0xbtknxgkIsttfpRalYqMkj5ifmyU9KTDnBoy7FIQKcjg2t X-Received: by 2002:a05:6a20:1581:b0:187:c184:58dc with SMTP id h1-20020a056a20158100b00187c18458dcmr6245702pzj.17.1700238560788; Fri, 17 Nov 2023 08:29:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700238560; cv=none; d=google.com; s=arc-20160816; b=R5cr4OWIR//dSoUU2kkPzieph6fw1W9iPZVTHcSOrfHRCdFNYNsKkgx/lE5H+gk88D QR+oGkJLo63N0ldUHF8tJhdMKlxlaIH+wn1C6/LS7E9geg+HSvRmJLI58AD+38dBn+FQ yUQvEShU1PoDKpCbjMo+o8gVKBmMty6f46YD6o4QzL9i2wzQyOGYyDGJR6kM5fJ63zY1 sNzRJO0rOQDpjJye9sQ7aDrTcYKXBwAaNvWQ+0iX0UicwqWTsZYVBx4oakoynqOmS7xO SBT0tY4ST41x/A0ma84hvJtKfr8o9s8OrCtocN5CBSisfRCWS9cE8cONMLmWK8ftXTwE KUYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=dUnEsnv22gc/BIC0xQJ8qHzM4XTZX5dR9S2CZMTebdY=; fh=9fueZXoaXZf+NkjA6/z5qIa61ElNXItpe1Du8rxZYKI=; b=g2/mVs2ckJsVOGKqNShBMuFjaMBkziqZ9gXQyRpAFDNXi+1LHF68F8w0MR5w99B4zi cuQuodfnQLhxQjNOpLk2EI1TtQY966ClHO1BzdH6ktvxpVMLUZ/wwtW49IfqY1k8qEkJ jpsPZZlZIOdWZjK3qbjaa4i585Rnr340Pja9GWcGmYe30ZJOdUYGfuWlYYzqUyU00h6K xQgQU8SOhqPffsPhqzyi5oAtmK4/H63ohOW0XFDK4uEi3huiElAH9QAoBv8j1FplfojU Vf3ODOEZbVOyoI6V86BG8+WiKdUtH4OPnAy6mIIbJU9DFw8ZckhMy+DHPi9PczqDzCXt DK/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id a1-20020a17090a8c0100b0027d11201a11si4640286pjo.170.2023.11.17.08.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:29:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id F2DE081ECCCC; Fri, 17 Nov 2023 08:29:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346106AbjKQQ2e (ORCPT + 99 others); Fri, 17 Nov 2023 11:28:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235725AbjKQQ2b (ORCPT ); Fri, 17 Nov 2023 11:28:31 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74F07D50; Fri, 17 Nov 2023 08:28:24 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AHGSB7Z03225394, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AHGSB7Z03225394 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2023 00:28:11 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Sat, 18 Nov 2023 00:28:12 +0800 Received: from james-bs01.realtek.com.tw (172.21.190.247) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Sat, 18 Nov 2023 00:28:11 +0800 From: James Tai To: Thomas Gleixner , Marc Zyngier , "Rob Herring" , Krzysztof Kozlowski , Conor Dooley , James Tai CC: , Subject: [PATCH v2 2/6] irqchip: Add interrupt controller support for Realtek DHC SoCs Date: Sat, 18 Nov 2023 00:27:05 +0800 Message-ID: <20231117162709.1096585-3-james.tai@realtek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231117162709.1096585-1-james.tai@realtek.com> References: <20231117162709.1096585-1-james.tai@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.190.247] X-ClientProxiedBy: RTEXH36505.realtek.com.tw (172.21.6.25) To RTEXMBS03.realtek.com.tw (172.21.6.96) X-KSE-ServerInfo: RTEXMBS03.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 17 Nov 2023 08:29:10 -0800 (PST) Realtek DHC (Digital Home Center) SoCs share a common interrupt controller design. This universal interrupt controller driver provides support for various variants within the Realtek DHC SoC family. Each DHC SoC features two sets of extended interrupt controllers, each capable of handling up to 32 interrupts. These expansion controllers are connected to the GIC (Generic Interrupt Controller). CC: Thomas Gleixner CC: Marc Zyngier CC: linux-kernel@vger.kernel.org Signed-off-by: James Tai --- v1 to v2 change: - Fixed code style issues - Removed the realtek_intc_set_affinity funcation - Replaced spin_lock_irqsave with raw_spin_lock drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-realtek-intc-common.c | 192 ++++++++++++++++++++++ drivers/irqchip/irq-realtek-intc-common.h | 77 +++++++++ 4 files changed, 274 insertions(+) create mode 100644 drivers/irqchip/irq-realtek-intc-common.c create mode 100644 drivers/irqchip/irq-realtek-intc-common.h diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index f7149d0f3d45..267c3429b48d 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -218,6 +218,10 @@ config RDA_INTC bool select IRQ_DOMAIN +config REALTEK_DHC_INTC + tristate + select IRQ_DOMAIN + config RENESAS_INTC_IRQPIN bool "Renesas INTC External IRQ Pin Support" if COMPILE_TEST select IRQ_DOMAIN diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index ffd945fe71aa..f6774af7fde2 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -47,6 +47,7 @@ obj-$(CONFIG_IRQ_MIPS_CPU) += irq-mips-cpu.o obj-$(CONFIG_IXP4XX_IRQ) += irq-ixp4xx.o obj-$(CONFIG_JCORE_AIC) += irq-jcore-aic.o obj-$(CONFIG_RDA_INTC) += irq-rda-intc.o +obj-$(CONFIG_REALTEK_DHC_INTC) += irq-realtek-intc-common.o obj-$(CONFIG_RENESAS_INTC_IRQPIN) += irq-renesas-intc-irqpin.o obj-$(CONFIG_RENESAS_IRQC) += irq-renesas-irqc.o obj-$(CONFIG_RENESAS_RZA1_IRQC) += irq-renesas-rza1.o diff --git a/drivers/irqchip/irq-realtek-intc-common.c b/drivers/irqchip/irq-realtek-intc-common.c new file mode 100644 index 000000000000..f701d9e7d141 --- /dev/null +++ b/drivers/irqchip/irq-realtek-intc-common.c @@ -0,0 +1,192 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek DHC SoCs interrupt controller driver + * + * Copyright (c) 2023 Realtek Semiconductor Corporation + */ + +#include +#include +#include +#include +#include + +#include "irq-realtek-intc-common.h" + +struct realtek_intc_data; + +static inline unsigned int realtek_intc_get_ints(struct realtek_intc_data *data) +{ + return readl(data->base + data->info->isr_offset); +} + +static inline void realtek_intc_clear_ints_bit(struct realtek_intc_data *data, int bit) +{ + writel(BIT(bit) & ~1, data->base + data->info->isr_offset); +} + +static inline unsigned int realtek_intc_get_inte(struct realtek_intc_data *data) +{ + unsigned int val; + + raw_spin_lock(&data->lock); + val = readl(data->base + data->info->scpu_int_en_offset); + raw_spin_unlock(&data->lock); + + return val; +} + +static void realtek_intc_handler(struct irq_desc *desc) +{ + struct realtek_intc_subset_data *subset_data = irq_desc_get_handler_data(desc); + struct realtek_intc_data *data = subset_data->common; + struct irq_chip *chip = irq_desc_get_chip(desc); + u32 ints, inte, mask; + int irq; + + chained_irq_enter(chip, desc); + + ints = realtek_intc_get_ints(data) & subset_data->cfg->ints_mask; + inte = realtek_intc_get_inte(data); + + while (ints) { + irq = __ffs(ints); + ints &= ~BIT(irq); + + mask = data->info->isr_to_scpu_int_en_mask[irq]; + if (mask != IRQ_ALWAYS_ENABLED && !(inte & mask)) + continue; + + generic_handle_irq(irq_find_mapping(data->domain, irq)); + realtek_intc_clear_ints_bit(data, irq); + } + + chained_irq_exit(chip, desc); +} + +static void realtek_intc_mask_irq(struct irq_data *data) +{ + struct realtek_intc_data *intc_data = irq_data_get_irq_chip_data(data); + + writel(BIT(data->hwirq), intc_data->base + intc_data->info->isr_offset); +} + +static void realtek_intc_unmask_irq(struct irq_data *data) +{ + struct realtek_intc_data *intc_data = irq_data_get_irq_chip_data(data); + + writel(BIT(data->hwirq), intc_data->base + intc_data->info->umsk_isr_offset); +} + +static void realtek_intc_enable_irq(struct irq_data *data) +{ + struct realtek_intc_data *intc_data = irq_data_get_irq_chip_data(data); + u32 scpu_int_en, mask; + + mask = intc_data->info->isr_to_scpu_int_en_mask[data->hwirq]; + if (!mask) + return; + + raw_spin_lock(&intc_data->lock); + scpu_int_en = readl(intc_data->base + intc_data->info->scpu_int_en_offset); + scpu_int_en |= mask; + writel(scpu_int_en, intc_data->base + intc_data->info->umsk_isr_offset); + raw_spin_unlock(&intc_data->lock); +} + +static void realtek_intc_disable_irq(struct irq_data *data) +{ + struct realtek_intc_data *intc_data = irq_data_get_irq_chip_data(data); + u32 scpu_int_en, mask; + + mask = intc_data->info->isr_to_scpu_int_en_mask[data->hwirq]; + if (!mask) + return; + + raw_spin_lock(&intc_data->lock); + scpu_int_en = readl(intc_data->base + intc_data->info->scpu_int_en_offset); + scpu_int_en &= ~mask; + writel(scpu_int_en, intc_data->base + intc_data->info->umsk_isr_offset); + raw_spin_unlock(&intc_data->lock); +} + +static struct irq_chip realtek_intc_chip = { + .name = "realtek-intc", + .irq_mask = realtek_intc_mask_irq, + .irq_unmask = realtek_intc_unmask_irq, + .irq_enable = realtek_intc_enable_irq, + .irq_disable = realtek_intc_disable_irq, +}; + +static int realtek_intc_domain_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) +{ + struct realtek_intc_data *data = d->host_data; + + irq_set_chip_and_handler(irq, &realtek_intc_chip, handle_level_irq); + irq_set_chip_data(irq, data); + irq_set_probe(irq); + + return 0; +} + +static const struct irq_domain_ops realtek_intc_domain_ops = { + .xlate = irq_domain_xlate_onecell, + .map = realtek_intc_domain_map, +}; + +static int realtek_intc_subset(struct device_node *node, struct realtek_intc_data *data, int index) +{ + struct realtek_intc_subset_data *subset_data = &data->subset_data[index]; + const struct realtek_intc_subset_cfg *cfg = &data->info->cfg[index]; + int irq; + + irq = irq_of_parse_and_map(node, index); + if (irq <= 0) + return irq; + + subset_data->common = data; + subset_data->cfg = cfg; + subset_data->parent_irq = irq; + irq_set_chained_handler_and_data(irq, realtek_intc_handler, subset_data); + + return 0; +} + +int realtek_intc_probe(struct platform_device *pdev, const struct realtek_intc_info *info) +{ + struct realtek_intc_data *data; + struct device *dev = &pdev->dev; + struct device_node *node = dev->of_node; + int ret, i; + + data = devm_kzalloc(dev, struct_size(data, subset_data, info->cfg_num), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->base = of_iomap(node, 0); + if (!data->base) + return -ENOMEM; + + data->info = info; + + raw_spin_lock_init(&data->lock); + + data->domain = irq_domain_add_linear(node, 32, &realtek_intc_domain_ops, data); + if (!data->domain) + return -ENOMEM; + + data->subset_data_num = info->cfg_num; + for (i = 0; i < info->cfg_num; i++) { + ret = realtek_intc_subset(node, data, i); + WARN(ret, "failed to init subset %d: %d", i, ret); + return -ENOMEM; + } + + platform_set_drvdata(pdev, data); + + return 0; +} +EXPORT_SYMBOL(realtek_intc_probe); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Realtek DHC SoC Interrupt Controller Driver"); diff --git a/drivers/irqchip/irq-realtek-intc-common.h b/drivers/irqchip/irq-realtek-intc-common.h new file mode 100644 index 000000000000..38be116dba60 --- /dev/null +++ b/drivers/irqchip/irq-realtek-intc-common.h @@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) */ +/* + * Copyright (c) 2023 Realtek Semiconductor Corporation + */ + +#ifndef _IRQ_REALTEK_COMMON_H +#define _IRQ_REALTEK_COMMON_H + +#include +#include +#include + +/** + * realtek_intc_subset_cfg - subset interrupt mask + * @ints_mask: inetrrupt mask + */ +struct realtek_intc_subset_cfg { + unsigned int ints_mask; +}; + +/** + * realtek_intc_info - interrupt controller data. + * @isr_offset: interrupt status register offset. + * @umsk_isr_offset: unmask interrupt status register offset. + * @scpu_int_en_offset: interrupt enable register offset. + * @cfg: cfg of the subset. + * @cfg_num: number of cfg. + */ +struct realtek_intc_info { + const struct realtek_intc_subset_cfg *cfg; + unsigned int isr_offset; + unsigned int umsk_isr_offset; + unsigned int scpu_int_en_offset; + const u32 *isr_to_scpu_int_en_mask; + int cfg_num; +}; + +/** + * realtek_intc_subset_data - handler of a interrupt source only handles ints + * bits in the mask. + * @cfg: cfg of the subset. + * @common: common data. + * @parent_irq: interrupt source. + */ +struct realtek_intc_subset_data { + const struct realtek_intc_subset_cfg *cfg; + struct realtek_intc_data *common; + int parent_irq; +}; + +/** + * realtek_intc_data - configuration data for realtek interrupt controller driver. + * @base: base of interrupt register + * @info: info of intc + * @domain: interrupt domain + * @lock: lock + * @saved_en: status of interrupt enable + * @subset_data_num: number of subset data + * @subset_data: subset data + */ +struct realtek_intc_data { + void __iomem *base; + const struct realtek_intc_info *info; + struct irq_domain *domain; + struct raw_spinlock lock; + unsigned int saved_en; + int subset_data_num; + struct realtek_intc_subset_data subset_data[]; +}; + +#define IRQ_ALWAYS_ENABLED U32_MAX +#define DISABLE_INTC (0) +#define CLEAN_INTC_STATUS GENMASK(31, 1) + +int realtek_intc_probe(struct platform_device *pdev, const struct realtek_intc_info *info); + +#endif /* _IRQ_REALTEK_COMMON_H */ -- 2.25.1