Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp637237rdb; Fri, 17 Nov 2023 08:29:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvue4OGqk1o2uOhhTxEGCmKxhPsgTR88NqJFpqDfQuxRL74OHCyPwRaqKq0fGFIQ0xS3yD X-Received: by 2002:a17:903:1252:b0:1cc:251c:c381 with SMTP id u18-20020a170903125200b001cc251cc381mr93731plh.29.1700238581084; Fri, 17 Nov 2023 08:29:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700238581; cv=none; d=google.com; s=arc-20160816; b=akMOfTl86Q0GEz96kd7OPpDbXzYGSo6Zj4AVOu60dSF7KxbEVJxRUOhB9RnaDjGC8s jOvBClTym1LoBGQ/NTz8HkcpKetlFNM7tAb+zxUF//NkFXPEl4SAh0UjCXY6jUj65rss n6fx0k6eUWYd7rzu95swh/swg2sQvKE1x1sV8uoj4PefijxEysoeKlPV/J7LWh3y9hrf Xov2emQcBEZ4uXecxQWDaAOVbZFjxUAqX1WMxsnpvjIv5JJqGULHhwFyp5RFyL/itWwS LF9BsJezJ97KYxhKqJ3MlvDb/lJRECR/BRdX36c/QfAouip+tCIjlrn65EYe9zf8CP9L aQgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kIUUS0Kx6LL5ZE2MXzMQe269JENKyNzxIN0/N8XgQ70=; fh=9fueZXoaXZf+NkjA6/z5qIa61ElNXItpe1Du8rxZYKI=; b=VD7MgtzuCoj5lNkl1Ba0Wg5CcunowUzQ/IQRFgPIxUqHjQh1lJQnm/0xf2uJsK2NRy tXoQRduNPXOICJL6i1FzPce83H8CLpqlVDPmvVGt7N2c2KsfoUyM1Q3u673CsRomDTPP qlh+n45PJQc+QAYEtJp3EQ57yODWIUDpWVStw45ZkJZrHqKP+rozZAHhs+TP5M/4jjVk lChj9wDxW6QONo9E6t3N2ob+GqCbdrnvX6iOiKMI1MNOSXYvFZpxj4EHGm6coosFrAMq JIHCr63u1564BWDcGCgXdFfzVtOe+sKptkbleT4l9g9qeR0S8z66v16yLcDMs5d+5A+h ckJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id l7-20020a170903120700b001b025aba9f2si2194852plh.22.2023.11.17.08.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:29:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 01A078340139; Fri, 17 Nov 2023 08:29:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346081AbjKQQ2f (ORCPT + 99 others); Fri, 17 Nov 2023 11:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbjKQQ2b (ORCPT ); Fri, 17 Nov 2023 11:28:31 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777C5171A; Fri, 17 Nov 2023 08:28:27 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AHGSFEu83225397, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AHGSFEu83225397 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2023 00:28:15 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Sat, 18 Nov 2023 00:28:16 +0800 Received: from james-bs01.realtek.com.tw (172.21.190.247) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Sat, 18 Nov 2023 00:28:15 +0800 From: James Tai To: Thomas Gleixner , Marc Zyngier , "Rob Herring" , Krzysztof Kozlowski , Conor Dooley , James Tai CC: , Subject: [PATCH v2 3/6] irqchip: Introduce RTD1319 support using the Realtek common interrupt controller driver Date: Sat, 18 Nov 2023 00:27:06 +0800 Message-ID: <20231117162709.1096585-4-james.tai@realtek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231117162709.1096585-1-james.tai@realtek.com> References: <20231117162709.1096585-1-james.tai@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.190.247] X-ClientProxiedBy: RTEXH36505.realtek.com.tw (172.21.6.25) To RTEXMBS03.realtek.com.tw (172.21.6.96) X-KSE-ServerInfo: RTEXMBS03.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 17 Nov 2023 08:29:31 -0800 (PST) Add support for the RTD1319 platform. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311061208.hJmxGqym-lkp@intel.com/ CC: Thomas Gleixner CC: Marc Zyngier CC: linux-kernel@vger.kernel.org Signed-off-by: James Tai --- v1 to v2 change: - Resolved kernel test robot build warnings - Replaced magic number with macro - Fixed code style issues drivers/irqchip/Kconfig | 6 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-realtek-rtd1319.c | 218 ++++++++++++++++++++++++++ 3 files changed, 225 insertions(+) create mode 100644 drivers/irqchip/irq-realtek-rtd1319.c diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 267c3429b48d..05856ce885fa 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -222,6 +222,12 @@ config REALTEK_DHC_INTC tristate select IRQ_DOMAIN +config REALTEK_RTD1319_INTC + tristate "Realtek RTD1319 interrupt controller" + select REALTEK_DHC_INTC + help + Support for Realtek RTD1319 Interrupt Controller. + config RENESAS_INTC_IRQPIN bool "Renesas INTC External IRQ Pin Support" if COMPILE_TEST select IRQ_DOMAIN diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index f6774af7fde2..6a2650b0a924 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -48,6 +48,7 @@ obj-$(CONFIG_IXP4XX_IRQ) += irq-ixp4xx.o obj-$(CONFIG_JCORE_AIC) += irq-jcore-aic.o obj-$(CONFIG_RDA_INTC) += irq-rda-intc.o obj-$(CONFIG_REALTEK_DHC_INTC) += irq-realtek-intc-common.o +obj-$(CONFIG_REALTEK_RTD1319_INTC) += irq-realtek-rtd1319.o obj-$(CONFIG_RENESAS_INTC_IRQPIN) += irq-renesas-intc-irqpin.o obj-$(CONFIG_RENESAS_IRQC) += irq-renesas-irqc.o obj-$(CONFIG_RENESAS_RZA1_IRQC) += irq-renesas-rza1.o diff --git a/drivers/irqchip/irq-realtek-rtd1319.c b/drivers/irqchip/irq-realtek-rtd1319.c new file mode 100644 index 000000000000..23c13c218b04 --- /dev/null +++ b/drivers/irqchip/irq-realtek-rtd1319.c @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1319 interrupt controller driver + * + * Copyright (c) 2023 Realtek Semiconductor Corporation + */ + +#include +#include +#include +#include +#include + +#include "irq-realtek-intc-common.h" + +#define ISO_NORMAL_MASK 0xffffcffe +#define ISO_RTC_MASK 0x00003001 +#define MISC_NMI_WDT_MASK 0x00000004 +#define MISC_NORMAL_MASK 0xffffc0d2 +#define MISC_UART1_MASK 0x00000028 +#define MISC_UART2_MASK 0x00002100 + +#define ISO_ISR_EN_OFFSET 0x40 +#define ISO_ISR_OFFSET 0 +#define ISO_ISR_UMSK_OFFSET 0x4 +#define MISC_ISR_EN_OFFSET 0x80 +#define MISC_ISR_OFFSET 0xc +#define MISC_ISR_UMSK_OFFSET 0x8 + +enum rtd1319_iso_isr_bits { + RTD1319_ISO_ISR_TC3_SHIFT = 1, + RTD1319_ISO_ISR_UR0_SHIFT = 2, + RTD1319_ISO_ISR_LSADC0_SHIFT = 3, + RTD1319_ISO_ISR_IRDA_SHIFT = 5, + RTD1319_ISO_ISR_SPI1_SHIFT = 6, + RTD1319_ISO_ISR_WDOG_NMI_SHIFT = 7, + RTD1319_ISO_ISR_I2C0_SHIFT = 8, + RTD1319_ISO_ISR_TC4_SHIFT = 9, + RTD1319_ISO_ISR_TC7_SHIFT = 10, + RTD1319_ISO_ISR_I2C1_SHIFT = 11, + RTD1319_ISO_ISR_RTC_HSEC_SHIFT = 12, + RTD1319_ISO_ISR_RTC_ALARM_SHIFT = 13, + RTD1319_ISO_ISR_GPIOA_SHIFT = 19, + RTD1319_ISO_ISR_GPIODA_SHIFT = 20, + RTD1319_ISO_ISR_ISO_MISC_SHIFT = 21, + RTD1319_ISO_ISR_CBUS_SHIFT = 22, + RTD1319_ISO_ISR_ETN_SHIFT = 23, + RTD1319_ISO_ISR_USB_HOST_SHIFT = 24, + RTD1319_ISO_ISR_USB_U3_DRD_SHIFT = 25, + RTD1319_ISO_ISR_USB_U2_DRD_SHIFT = 26, + RTD1319_ISO_ISR_PORB_HV_SHIFT = 28, + RTD1319_ISO_ISR_PORB_DV_SHIFT = 29, + RTD1319_ISO_ISR_PORB_AV_SHIFT = 30, + RTD1319_ISO_ISR_I2C1_REQ_SHIFT = 31, +}; + +static const u32 rtd1319_iso_isr_to_scpu_int_en_mask[32] = { + [RTD1319_ISO_ISR_SPI1_SHIFT] = BIT(1), + [RTD1319_ISO_ISR_UR0_SHIFT] = BIT(2), + [RTD1319_ISO_ISR_LSADC0_SHIFT] = BIT(3), + [RTD1319_ISO_ISR_IRDA_SHIFT] = BIT(5), + [RTD1319_ISO_ISR_I2C0_SHIFT] = BIT(8), + [RTD1319_ISO_ISR_I2C1_SHIFT] = BIT(11), + [RTD1319_ISO_ISR_RTC_HSEC_SHIFT] = BIT(12), + [RTD1319_ISO_ISR_RTC_ALARM_SHIFT] = BIT(13), + [RTD1319_ISO_ISR_GPIOA_SHIFT] = BIT(19), + [RTD1319_ISO_ISR_GPIODA_SHIFT] = BIT(20), + [RTD1319_ISO_ISR_PORB_HV_SHIFT] = BIT(28), + [RTD1319_ISO_ISR_PORB_DV_SHIFT] = BIT(29), + [RTD1319_ISO_ISR_PORB_AV_SHIFT] = BIT(30), + [RTD1319_ISO_ISR_I2C1_REQ_SHIFT] = BIT(31), +}; + +enum rtd1319_misc_isr_bits { + RTD1319_ISR_WDOG_NMI_SHIFT = 2, + RTD1319_ISR_UR1_SHIFT = 3, + RTD1319_ISR_TC5_SHIFT = 4, + RTD1319_ISR_UR1_TO_SHIFT = 5, + RTD1319_ISR_TC0_SHIFT = 6, + RTD1319_ISR_TC1_SHIFT = 7, + RTD1319_ISR_UR2_SHIFT = 8, + RTD1319_ISR_RTC_HSEC_SHIFT = 9, + RTD1319_ISR_RTC_MIN_SHIFT = 10, + RTD1319_ISR_RTC_HOUR_SHIFT = 11, + RTD1319_ISR_RTC_DATE_SHIFT = 12, + RTD1319_ISR_UR2_TO_SHIFT = 13, + RTD1319_ISR_I2C5_SHIFT = 14, + RTD1319_ISR_I2C3_SHIFT = 23, + RTD1319_ISR_SC0_SHIFT = 24, + RTD1319_ISR_SC1_SHIFT = 25, + RTD1319_ISR_SPI_SHIFT = 27, + RTD1319_ISR_FAN_SHIFT = 29, +}; + +static const u32 rtd1319_misc_isr_to_scpu_int_en_mask[32] = { + [RTD1319_ISR_UR1_SHIFT] = BIT(3), + [RTD1319_ISR_UR1_TO_SHIFT] = BIT(5), + [RTD1319_ISR_UR2_TO_SHIFT] = BIT(6), + [RTD1319_ISR_UR2_SHIFT] = BIT(7), + [RTD1319_ISR_RTC_MIN_SHIFT] = BIT(10), + [RTD1319_ISR_RTC_HOUR_SHIFT] = BIT(11), + [RTD1319_ISR_RTC_DATE_SHIFT] = BIT(12), + [RTD1319_ISR_I2C5_SHIFT] = BIT(14), + [RTD1319_ISR_SC0_SHIFT] = BIT(24), + [RTD1319_ISR_SC1_SHIFT] = BIT(25), + [RTD1319_ISR_SPI_SHIFT] = BIT(27), + [RTD1319_ISR_I2C3_SHIFT] = BIT(28), + [RTD1319_ISR_FAN_SHIFT] = BIT(29), + [RTD1319_ISR_WDOG_NMI_SHIFT] = IRQ_ALWAYS_ENABLED, +}; + +static struct realtek_intc_subset_cfg rtd1319_intc_iso_cfgs[] = { + { ISO_NORMAL_MASK, }, + { ISO_RTC_MASK, }, +}; + +static const struct realtek_intc_info rtd1319_intc_iso_info = { + .isr_offset = ISO_ISR_OFFSET, + .umsk_isr_offset = ISO_ISR_UMSK_OFFSET, + .scpu_int_en_offset = ISO_ISR_EN_OFFSET, + .isr_to_scpu_int_en_mask = rtd1319_iso_isr_to_scpu_int_en_mask, + .cfg = rtd1319_intc_iso_cfgs, + .cfg_num = ARRAY_SIZE(rtd1319_intc_iso_cfgs), +}; + +static struct realtek_intc_subset_cfg rtd1319_intc_misc_cfgs[] = { + { MISC_NORMAL_MASK, }, + { MISC_NMI_WDT_MASK, }, + { MISC_UART1_MASK, }, + { MISC_UART2_MASK, }, +}; + +static const struct realtek_intc_info rtd1319_intc_misc_info = { + .isr_offset = MISC_ISR_OFFSET, + .umsk_isr_offset = MISC_ISR_UMSK_OFFSET, + .scpu_int_en_offset = MISC_ISR_EN_OFFSET, + .isr_to_scpu_int_en_mask = rtd1319_misc_isr_to_scpu_int_en_mask, + .cfg = rtd1319_intc_misc_cfgs, + .cfg_num = ARRAY_SIZE(rtd1319_intc_misc_cfgs), +}; + +static const struct of_device_id realtek_intc_rtd1319_dt_matches[] = { + { + .compatible = "realtek,rtd1319-intc-iso", + .data = &rtd1319_intc_iso_info, + }, { + .compatible = "realtek,rtd1319-intc-misc", + .data = &rtd1319_intc_misc_info, + }, + { /* sentinel */ } +}; + +static int realtek_intc_rtd1319_suspend(struct device *dev) +{ + struct realtek_intc_data *data = dev_get_drvdata(dev); + const struct realtek_intc_info *info = data->info; + + data->saved_en = readl(data->base + info->scpu_int_en_offset); + + writel(DISABLE_INTC, data->base + info->scpu_int_en_offset); + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); + + return 0; +} + +static int realtek_intc_rtd1319_resume(struct device *dev) +{ + struct realtek_intc_data *data = dev_get_drvdata(dev); + const struct realtek_intc_info *info = data->info; + + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); + writel(data->saved_en, data->base + info->scpu_int_en_offset); + + return 0; +} + +static const struct dev_pm_ops realtek_intc_rtd1319_pm_ops = { + .suspend_noirq = realtek_intc_rtd1319_suspend, + .resume_noirq = realtek_intc_rtd1319_resume, +}; + +static int rtd1319_intc_probe(struct platform_device *pdev) +{ + const struct realtek_intc_info *info; + + info = of_device_get_match_data(&pdev->dev); + if (!info) + return -EINVAL; + + return realtek_intc_probe(pdev, info); +} + +static struct platform_driver realtek_intc_rtd1319_driver = { + .probe = rtd1319_intc_probe, + .driver = { + .name = "realtek_intc_rtd1319", + .of_match_table = realtek_intc_rtd1319_dt_matches, + .suppress_bind_attrs = true, + .pm = &realtek_intc_rtd1319_pm_ops, + }, +}; + +static int __init realtek_intc_rtd1319_init(void) +{ + return platform_driver_register(&realtek_intc_rtd1319_driver); +} +core_initcall(realtek_intc_rtd1319_init); + +static void __exit realtek_intc_rtd1319_exit(void) +{ + platform_driver_unregister(&realtek_intc_rtd1319_driver); +} +module_exit(realtek_intc_rtd1319_exit); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Realtek RTD1319 Interrupt Controller Driver"); -- 2.25.1