Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp642036rdb; Fri, 17 Nov 2023 08:36:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcQVTO4RN4igKnp/TuBSgyxCy1OcQhtvnifNzx6AcyLRbck99iNIduj0KZlRORa6kNNJ0Q X-Received: by 2002:a05:6808:650b:b0:3a8:6693:135d with SMTP id fm11-20020a056808650b00b003a86693135dmr24347365oib.49.1700239005606; Fri, 17 Nov 2023 08:36:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700239005; cv=none; d=google.com; s=arc-20160816; b=sbrWskWgRJ9aGdQRk3b6CCPm7P01QkRzWW4zk7e7bMC1KTVBNyvBW+5d9x6hp0OX7p N6qqMNPhbnP/KGvtE2xcqspitBOdgKIJ0lRt2GJCSq+3ASdXq3cUqokMzM01Rnx3KfnE 0ismHHRm9nLMAEgGlB8h0kaTTUwhTKY27RFs3xABlxHZKUyYubWX+MHNPUHiA3Ujhqcp uimJG+E5hgoYk/rvQOBcTM1va//7Nmte6E7+1quRoTkUrlsNWVMRNxpKbk9jMhcIwtsW mftWSPxU9EPBMa440TPOT4Qunc+w47BxZVjjlk/cAP05gyxm/2q/JwJQAPr0aqP6olBM D6+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t+eo7dZP8W2MTkUGsAYqzcqMVYhe+o7Ujw1FnGUNr4Y=; fh=qUkrJQnG0bwm5GewlKIvHpXFEcyt1/mYGGjp8FEOCAM=; b=J3a/0AqDxSUCJ67l5THCbUuCHnPuZ3pNN5/OxTs9LfjArIDksUUZLb7Yy4v56d3PhM XPKST2BNKd7YPrS2kMZFOXKUM3pTJ8ZoIRWMcDTf73X4T2n01E+i6+JhrIiITvU6TcC/ 9hgUa/lUMDqdg1s77EXnzTc6ILacrGXaPeGcLzQo56HfcLYC3Uuw83YRxKar3EFc643u Zz9itlw8WzLQaKkztSf8jrv007mc3B6XQePyiWSn9jJmdmEbgCgMolFhiSEmghF01nJ5 RjoB4zEIhTzJnsPIkxfRoh02nnSi6Jf9XYHqwU1pM5H1rw5E6Ye0n07ZoSiJJRUdn83l Hh9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WG0Grb75; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id o185-20020a6341c2000000b005bdf5961e67si2212032pga.639.2023.11.17.08.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 08:36:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WG0Grb75; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0CBFE80309B2; Fri, 17 Nov 2023 08:36:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbjKQQgW (ORCPT + 99 others); Fri, 17 Nov 2023 11:36:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbjKQQgV (ORCPT ); Fri, 17 Nov 2023 11:36:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB19194; Fri, 17 Nov 2023 08:36:18 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76D0DC433C9; Fri, 17 Nov 2023 16:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700238976; bh=y6Shd7bmKCsekpBRoYhpQ2ZpMh78XJxTVe4sGB2BHac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WG0Grb750dwkd6qBwm5RB8YkQ4mrl5JAMjtpfNcuKssNdb9OFAXz5WSD1cW2RBtc8 ClVZ3YDwldl+qYkE1FOjKn/WsD+PpkuS3Yl7yGRorawaOkEt8KIDS96SkhL+IQCDkp uXNgQgoQWmAVXE6fdypg0aPN0VzVlCrIz9Sa1KlV+bnaAiqtNa8ka1FPlp24rezmVN BF9cUwKKWGxy+RpUfjQw9WGTXZzQzBAWFm7DziGEA9fMuutr3/WDyQTiT16XTMDnjd 9MCPWsP+YbQuMjWKYRcTEasvcdYbJdvbxYRxBVPMS7EodVsrZqNgB5MUEW3zPjsAlC koOKG9Jof7kBg== Date: Fri, 17 Nov 2023 16:36:13 +0000 From: Mark Brown To: Maciej Strozek Cc: James Schulman , David Rhodes , Liam Girdwood , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] ASoC: cs43130: Allow driver to work without IRQ thread Message-ID: References: <20231117141344.64320-1-mstrozek@opensource.cirrus.com> <20231117141344.64320-7-mstrozek@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jNsZootFS+OqjmoX" Content-Disposition: inline In-Reply-To: <20231117141344.64320-7-mstrozek@opensource.cirrus.com> X-Cookie: Slow day. Practice crawling. X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 08:36:22 -0800 (PST) --jNsZootFS+OqjmoX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 17, 2023 at 02:13:43PM +0000, Maciej Strozek wrote: > Signed-off-by: Maciej Strozek > --- > sound/soc/codecs/cs43130.c | 56 +++++++++++++++++++++++++++++++------- > sound/soc/codecs/cs43130.h | 1 + > 2 files changed, 47 insertions(+), 10 deletions(-) Why? This isn't some obvious fix, you need to write a changelog motivating open coding interrupt handling if there's some reason for doing that. --jNsZootFS+OqjmoX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVXlngACgkQJNaLcl1U h9AIgAf/YwFU+24iTCyBD2p7T4hTxXe88GHpeNfoDy4xmZqQ93P5hdHXUVgC/dPC YyQ10xS2vXHlTdHUF61h7mI8sK7SQ19P+1bdNGEKc5JDok4qKxG8k9PxWlbS09n+ uOGhfpKyH326+gLfbNn5PyDg8O5JG8w0rCDSq4xEaeR0Vw1eMmNB8Ub1TCUlNvtB sI6xGKkyi7gw8kqk8tQza69iPYJNXsIW4ar/oM6FjH3ZjzPhDS8ZKMEbJWGhtUda YsYIk47TfXUs0f+bZNRcmhYUnTJfdy8VgHQSrSKp9Lmb51q6q2sqhS+Ah3icNlJU uwTHiuhzkeufob+mFz0/IyIqoKcA+g== =qhs0 -----END PGP SIGNATURE----- --jNsZootFS+OqjmoX--