Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231117154831.2518110-1-chentao@kylinos.cn>
In-Reply-To: <20231117154831.2518110-1-chentao@kylinos.cn>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 17 Nov 2023 18:29:10 +0100
Message-ID: <CANn89iKJ=Na2hWGv9Dau36Ojivt-icnd1BRgke033Z=a+E9Wcw@mail.gmail.com>
Subject: Re: [PATCH] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys
To:     Kunwu Chan <chentao@kylinos.cn>
Cc:     davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org,
        pabeni@redhat.com, kunwu.chan@hotmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 17, 2023 at 6:06=E2=80=AFPM Kunwu Chan <chentao@kylinos.cn> wro=
te:
>
> net/ipv6/route.c:2332:39: warning: incorrect type in assignment (differen=
t base types)
> net/ipv6/route.c:2332:39:    expected unsigned int [usertype] flow_label
> net/ipv6/route.c:2332:39:    got restricted __be32
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Same remark, we need a Fixes: tag

> ---
>  net/ipv6/route.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index b132feae3393..692c811eb786 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -2329,7 +2329,7 @@ static void ip6_multipath_l3_keys(const struct sk_b=
uff *skb,
>         } else {
>                 keys->addrs.v6addrs.src =3D key_iph->saddr;
>                 keys->addrs.v6addrs.dst =3D key_iph->daddr;
> -               keys->tags.flow_label =3D ip6_flowlabel(key_iph);
> +               keys->tags.flow_label =3D be32_to_cpu(ip6_flowlabel(key_i=
ph));
>                 keys->basic.ip_proto =3D key_iph->nexthdr;
>         }

This is not consistent with line 2541 doing:

hash_keys.tags.flow_label =3D (__force u32)flowi6_get_flowlabel(fl6);