Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231117-rk-lvds-defer-msg-v1-1-1e6894cf9a74@theobroma-systems.com>
In-Reply-To: <20231117-rk-lvds-defer-msg-v1-1-1e6894cf9a74@theobroma-systems.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 17 Nov 2023 16:27:47 -0300
Message-ID: <CAOMZO5BVX3UmZ-45OphM6WDhz_ENkxm+Sr1dXkt4jR+Mmo-1Gg@mail.gmail.com>
Subject: Re: [PATCH] drm/rockchip: lvds: do not print error message when
 deferring probe
To:     Quentin Schulz <foss+kernel@0leil.net>
Cc:     Sandy Huang <hjc@rock-chips.com>,
        =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Mark Yao <markyao0591@gmail.com>,
        linux-rockchip@lists.infradead.org,
        Quentin Schulz <quentin.schulz@theobroma-systems.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Quentin,

On Fri, Nov 17, 2023 at 3:31=E2=80=AFPM Quentin Schulz <foss+kernel@0leil.n=
et> wrote:
>
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> This scary message may happen if the panel or bridge is not probed
> before the LVDS controller is, resulting in some head scratching because
> the LVDS panel is actually working, since a later try will eventually
> find the panel or bridge.
>
> Therefore let's demote this error message into a debug message to not
> scare users unnecessarily.
...

> diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/r=
ockchip/rockchip_lvds.c
> index f0f47e9abf5a..52e2ce2a61a8 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
> @@ -577,7 +577,7 @@ static int rockchip_lvds_bind(struct device *dev, str=
uct device *master,
>                 ret =3D -EINVAL;
>                 goto err_put_port;
>         } else if (ret) {
> -               DRM_DEV_ERROR(dev, "failed to find panel and bridge node\=
n");
> +               DRM_DEV_DEBUG(dev, "failed to find panel and bridge node\=
n");
>                 ret =3D -EPROBE_DEFER;

What about using dev_err_probe() instead?