Date: Mon, 26 Nov 2007 21:47:26 -0800
From: Greg KH <greg@kroah.com>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Kay Sievers <kay.sievers@vrfy.org>,
       Matt Tolentino <matthew.e.tolentino@intel.com>
Subject: Re: [PATCH 38/54] efivars: remove new_var and del_var files from
	sysfs
Message-ID: <20071127054726.GA1400@kroah.com>
References: <20071102235758.GA9803@kroah.com> <1194047972-9850-38-git-send-email-gregkh@suse.de> <20071116150116.GA8901@auslistsprd01.us.dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071116150116.GA8901@auslistsprd01.us.dell.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 27

On Fri, Nov 16, 2007 at 09:01:16AM -0600, Matt Domsch wrote:
> On Fri, Nov 02, 2007 at 04:59:16PM -0700, Greg Kroah-Hartman wrote:
> > WTF?  Passing binary structures into a sysfs file, expecting it to be in
> > the correct format/endianness?  That's just wrong on so many levels.
> > 
> > So, these files are deleted.  If you want to add them back, please do so
> > in configfs, or in debugfs.  Or use text strings, which is what sysfs is
> > only for.
> 
> 
> I have tested gregkh's patches tree, which includes this patch, the
> patch to put these back as binary blob interfaces, as well as other
> cleanups, on an Itanium2 system.  The efibootmgr userspace application
> continues to work as it did before this patch series, which I claim is
> success.  For the patches that touch drivers/firmware/efivars.c I can
> say:
> 
> Tested-by: Matt Domsch <Matt_Domsch@dell.com>

Great, thanks for doing this, I appreciate it.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/